[Bug other/110669] New: [24 regression] ICE in gcc.dg/torture/pr105132.c since r14-2515-gb77161e60bce7b

[Bug other/110669] New: [24 regression] ICE in gcc.dg/torture/pr105132.c since r14-2515-gb77161e60bce7b

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110669

            Bug ID: 110669
           Summary: [24 regression] ICE in gcc.dg/torture/pr105132.c since
                    r14-2515-gb77161e60bce7b
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:b77161e60bce7b4416319defe5f141f14fd375c4, r14-2515-gb77161e60bce7b
make  -k check-gcc RUNTESTFLAGS="dg-torture.exp=gcc.dg/torture/pr105132.c"
FAIL: gcc.dg/torture/pr105132.c   -O1  (internal compiler error: in
gimple_phi_arg_def_from_edge, at gimple.h:4699)
FAIL: gcc.dg/torture/pr105132.c   -O1  (test for excess errors)
# of expected passes            7
# of unexpected failures        2

spawn -ignore SIGHUP /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/torture/pr105132.c
-fdiagnostics-plain-output -O1 -S -o pr105132.s
during GIMPLE pass: sccp
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/torture/pr105132.c: In
function 'd':
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/torture/pr105132.c:7:6:
internal compiler error: in gimple_phi_arg_def_from_edge, at gimple.h:4699
0x10e0f357 gimple_phi_arg_def_from_edge(gphi const*, edge_def const*)
        /home/seurer/gcc/git/gcc-test/gcc/gimple.h:4699
0x10e0f357 gimple_phi_arg_def_from_edge(gphi const*, edge_def const*)
        /home/seurer/gcc/git/gcc-test/gcc/gimple.h:4697
0x10e0f357 final_value_replacement_loop(loop*)
        /home/seurer/gcc/git/gcc-test/gcc/tree-scalar-evolution.cc:3732
0x10f0e01f execute
        /home/seurer/gcc/git/gcc-test/gcc/tree-ssa-loop.cc:411

commit b77161e60bce7b4416319defe5f141f14fd375c4 (HEAD)
Author: Richard Biener <rguenther@suse.de>
Date:   Fri Jul 14 10:01:39 2023 +0200

    Provide extra checking for phi argument access from edge

[Bug other/110669] [24 regression] ICE in gcc.dg/torture/pr105132.c since r14-2515-gb77161e60bce7b

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110669

David Binderman <dcb314 at hotmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcb314 at hotmail dot com

--- Comment #1 from David Binderman <dcb314 at hotmail dot com> ---
I also see this. Reduction running now.

[Bug other/110669] [14 regression] ICE in gcc.dg/torture/pr105132.c since r14-2515-gb77161e60bce7b

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110669

--- Comment #2 from David Binderman <dcb314 at hotmail dot com> ---
Reduced C code seems to be:

int g_29, func_47_p_48, func_47_p_51_l_129;
void func_47_p_51() {
  for (;;) {
    func_47_p_51_l_129 = 0;
    for (; func_47_p_51_l_129 <= 1; func_47_p_51_l_129 += 1) {
      short *l_160 = func_47_p_48 || *l_160;
      *l_160 &= g_29;
    }
  }
}

$ ~/gcc/results/bin/gcc -c -Ofast bug942.c
bug942.c: In function ‘func_47_p_51’:
bug942.c:6:22: warning: initialization of ‘short int *’ from ‘int’ makes
pointer from integer without a cast [-Wint-conversion]
    6 |       short *l_160 = func_47_p_48 || *l_160;
      |                      ^~~~~~~~~~~~
during GIMPLE pass: sccp
bug942.c:2:6: internal compiler error: in gimple_phi_arg_def_from_edge, at
gimple.h:4699
    2 | void func_47_p_51() {
      |      ^~~~~~~~~~~~
0xf4f20f final_value_replacement_loop(loop*)
        ../../trunk.year/gcc/tree-scalar-evolution.cc:0

[Bug other/110669] [14 regression] ICE in gcc.dg/torture/pr105132.c since r14-2515-gb77161e60bce7b

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110669

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0

[Bug other/110669] [14 regression] ICE in gcc.dg/torture/pr105132.c since r14-2515-gb77161e60bce7b

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110669

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lehua.ding at rivai dot ai

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 110695 has been marked as a duplicate of this bug. ***

[Bug other/110669] [14 regression] ICE in gcc.dg/torture/pr105132.c since r14-2515-gb77161e60bce7b

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110669

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 110673 has been marked as a duplicate of this bug. ***

[Bug other/110669] [14 regression] ICE in gcc.dg/torture/pr105132.c since r14-2515-gb77161e60bce7b

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110669

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zhendong.su at inf dot ethz.ch

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 110671 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/110669] [14 regression] ICE in gcc.dg/torture/pr105132.c since r14-2515-gb77161e60bce7b

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110669

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2023-07-17

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Mine.

[Bug tree-optimization/110669] [14 regression] ICE in gcc.dg/torture/pr105132.c since r14-2515-gb77161e60bce7b

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110669

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Exactly the thing the patch was supposed to catch ... testing fix.

[Bug tree-optimization/110669] [14 regression] ICE in gcc.dg/torture/pr105132.c since r14-2515-gb77161e60bce7b

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110669

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:3228e5c078ed2b505e4ad238b09c1817b38f9cfb

commit r14-2559-g3228e5c078ed2b505e4ad238b09c1817b38f9cfb
Author: Richard Biener <rguenther@suse.de>
Date:   Mon Jul 17 09:20:33 2023 +0200

    tree-optimization/110669 - bogus matching of loop bitop

    The matching code lacked a check that we end up with a PHI node
    in the loop header.  This caused us to match a random PHI argument
    now catched by the extra PHI_ARG_DEF_FROM_EDGE checking.

            PR tree-optimization/110669
            * tree-scalar-evolution.cc
(analyze_and_compute_bitop_with_inv_effect):
            Check we matched a header PHI.

            * gcc.dg/torture/pr110669.c: New testcase.

[Bug tree-optimization/110669] [14 regression] ICE in gcc.dg/torture/pr105132.c since r14-2515-gb77161e60bce7b

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110669

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:b8a15313766661309698ad5cd4f000152ce74a52

commit r13-7569-gb8a15313766661309698ad5cd4f000152ce74a52
Author: Richard Biener <rguenther@suse.de>
Date:   Mon Jul 17 09:20:33 2023 +0200

    tree-optimization/110669 - bogus matching of loop bitop

    The matching code lacked a check that we end up with a PHI node
    in the loop header.  This caused us to match a random PHI argument
    now catched by the extra PHI_ARG_DEF_FROM_EDGE checking.

            PR tree-optimization/110669
            * tree-scalar-evolution.cc
(analyze_and_compute_bitop_with_inv_effect):
            Check we matched a header PHI.

            * gcc.dg/torture/pr110669.c: New testcase.

[Bug tree-optimization/110669] [14 regression] ICE in gcc.dg/torture/pr105132.c since r14-2515-gb77161e60bce7b

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110669

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.

[Bug tree-optimization/110669] [14 regression] ICE in gcc.dg/torture/pr105132.c since r14-2515-gb77161e60bce7b

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110669

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Roger Sayle <sayle@gcc.gnu.org>:

https://gcc.gnu.org/g:cfe53af09364d94fb86013f85ef598a1d47e0657

commit r14-2721-gcfe53af09364d94fb86013f85ef598a1d47e0657
Author: Roger Sayle <roger@nextmovesoftware.com>
Date:   Fri Jul 21 20:37:59 2023 +0100

    PR c/110699: Defend against error_mark_node in gimplify.cc.

    This patch resolves PR c/110669, an ICE-after-error regression, by adding
    a check that the array type isn't error_mark_node in
gimplify_compound_lval.

    2023-07-21  Roger Sayle  <roger@nextmovesoftware.com>
                Richard Biener  <rguenther@suse.de>

    gcc/ChangeLog
            PR c/110699
            * gimplify.cc (gimplify_compound_lval):  If the array's type
            is error_mark_node then return GS_ERROR.

    gcc/testsuite/ChangeLog
            PR c/110699
            * gcc.dg/pr110699.c: New test case.