public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/110727] New: gcc.target/aarch64/sve/aarch64-sve.exp has two new failures since commit 061f74c0673
@ 2023-07-18 19:24 thiago.bauermann at linaro dot org
  2023-07-19  6:49 ` [Bug target/110727] [14 Regression] " rguenth at gcc dot gnu.org
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: thiago.bauermann at linaro dot org @ 2023-07-18 19:24 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110727

            Bug ID: 110727
           Summary: gcc.target/aarch64/sve/aarch64-sve.exp has two new
                    failures since commit 061f74c0673
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: thiago.bauermann at linaro dot org
  Target Milestone: ---

Created attachment 55574
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55574&action=edit
Tarball containing testsuite log files for first bad and last good commits.

Our CI detected that commit 061f74c06735 "Fix profile update in
scale_profile_for_vect_loop" introduced these testsuite failures on
aarch64-linux:

Running gcc:gcc.target/aarch64/sve/aarch64-sve.exp ...
FAIL: gcc.target/aarch64/sve/live_1.c scan-assembler-times
\\twhilelo\\tp[0-7].b,  2
FAIL: gcc.target/aarch64/sve/live_1.c scan-assembler-times
\\twhilelo\\tp[0-7].h,  4

I confirmed that they are still present in trunk as of commit c11a3aedec26
"tree-ssa-loop-ch improvements, part 3" from today.

Tested on Ubuntu 22.04 with:

$ ~/src/gcc/configure --disable-bootstrap --disable-multilib && make -j 60
$ make -C gcc check-c RUNTESTFLAGS=gcc.target/aarch64/sve/aarch64-sve.exp

I'll attach gcc.sum and gcc.log from commit c11a3aedec26 as well as gcc.sum and
gcc.log from its parent, which was the last commit where the test passed.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug target/110727] [14 Regression] gcc.target/aarch64/sve/aarch64-sve.exp has two new failures since commit 061f74c0673
  2023-07-18 19:24 [Bug target/110727] New: gcc.target/aarch64/sve/aarch64-sve.exp has two new failures since commit 061f74c0673 thiago.bauermann at linaro dot org
@ 2023-07-19  6:49 ` rguenth at gcc dot gnu.org
  2023-07-21 17:38 ` cvs-commit at gcc dot gnu.org
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-07-19  6:49 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110727

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0
                 CC|                            |hubicka at gcc dot gnu.org
             Target|                            |aarch64
            Summary|gcc.target/aarch64/sve/aarc |[14 Regression]
                   |h64-sve.exp has two new     |gcc.target/aarch64/sve/aarc
                   |failures since commit       |h64-sve.exp has two new
                   |061f74c0673                 |failures since commit
                   |                            |061f74c0673
           Keywords|                            |testsuite-fail

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug target/110727] [14 Regression] gcc.target/aarch64/sve/aarch64-sve.exp has two new failures since commit 061f74c0673
  2023-07-18 19:24 [Bug target/110727] New: gcc.target/aarch64/sve/aarch64-sve.exp has two new failures since commit 061f74c0673 thiago.bauermann at linaro dot org
  2023-07-19  6:49 ` [Bug target/110727] [14 Regression] " rguenth at gcc dot gnu.org
@ 2023-07-21 17:38 ` cvs-commit at gcc dot gnu.org
  2023-07-21 22:46 ` thiago.bauermann at linaro dot org
  2023-08-06 20:49 ` hubicka at gcc dot gnu.org
  3 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-07-21 17:38 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110727

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jan Hubicka <hubicka@gcc.gnu.org>:

https://gcc.gnu.org/g:a31ef26b056d0c4f0a9f08b6eb81456ea257298e

commit r14-2716-ga31ef26b056d0c4f0a9f08b6eb81456ea257298e
Author: Jan Hubicka <jh@suse.cz>
Date:   Fri Jul 21 19:38:26 2023 +0200

    Avoid scaling flat loop profiles of vectorized loops

    As discussed, when vectorizing loop with static profile, it is not always
good idea
    to divide the header frequency by vectorization factor because the profile
may
    not realistically represent the expected number of iterations.  Since in
such cases
    we default to relatively low iteration counts (based on average for
spec2k17), this
    will make vectorized loop body look cold.

    This patch makes vectorizer to look for flat profiles and only possibly
reduce the
    profile by known upper bound on iteration counts.

    gcc/ChangeLog:

            PR target/110727
            * tree-vect-loop.cc (scale_profile_for_vect_loop): Avoid scaling
flat
            profiles by vectorization factor.
            (vect_transform_loop): Check for flat profiles.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug target/110727] [14 Regression] gcc.target/aarch64/sve/aarch64-sve.exp has two new failures since commit 061f74c0673
  2023-07-18 19:24 [Bug target/110727] New: gcc.target/aarch64/sve/aarch64-sve.exp has two new failures since commit 061f74c0673 thiago.bauermann at linaro dot org
  2023-07-19  6:49 ` [Bug target/110727] [14 Regression] " rguenth at gcc dot gnu.org
  2023-07-21 17:38 ` cvs-commit at gcc dot gnu.org
@ 2023-07-21 22:46 ` thiago.bauermann at linaro dot org
  2023-08-06 20:49 ` hubicka at gcc dot gnu.org
  3 siblings, 0 replies; 5+ messages in thread
From: thiago.bauermann at linaro dot org @ 2023-07-21 22:46 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110727

--- Comment #2 from Thiago Jung Bauermann <thiago.bauermann at linaro dot org> ---
Thanks! I confirmed that I can't reproduce the problem anymore in trunk.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug target/110727] [14 Regression] gcc.target/aarch64/sve/aarch64-sve.exp has two new failures since commit 061f74c0673
  2023-07-18 19:24 [Bug target/110727] New: gcc.target/aarch64/sve/aarch64-sve.exp has two new failures since commit 061f74c0673 thiago.bauermann at linaro dot org
                   ` (2 preceding siblings ...)
  2023-07-21 22:46 ` thiago.bauermann at linaro dot org
@ 2023-08-06 20:49 ` hubicka at gcc dot gnu.org
  3 siblings, 0 replies; 5+ messages in thread
From: hubicka at gcc dot gnu.org @ 2023-08-06 20:49 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110727

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Fixed.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-08-06 20:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-18 19:24 [Bug target/110727] New: gcc.target/aarch64/sve/aarch64-sve.exp has two new failures since commit 061f74c0673 thiago.bauermann at linaro dot org
2023-07-19  6:49 ` [Bug target/110727] [14 Regression] " rguenth at gcc dot gnu.org
2023-07-21 17:38 ` cvs-commit at gcc dot gnu.org
2023-07-21 22:46 ` thiago.bauermann at linaro dot org
2023-08-06 20:49 ` hubicka at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).