* [Bug libfortran/110759] IEEE Fortran change broke RISC-V linux build
2023-07-20 22:15 [Bug libfortran/110759] New: IEEE Fortran change broke RISC-V linux build patrick at rivosinc dot com
@ 2023-07-20 22:16 ` patrick at rivosinc dot com
2023-07-20 22:18 ` [Bug libfortran/110759] [14 Regression] " pinskia at gcc dot gnu.org
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: patrick at rivosinc dot com @ 2023-07-20 22:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110759
--- Comment #1 from Patrick O'Neill <patrick at rivosinc dot com> ---
Created attachment 55593
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55593&action=edit
Failing build log
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libfortran/110759] [14 Regression] IEEE Fortran change broke RISC-V linux build
2023-07-20 22:15 [Bug libfortran/110759] New: IEEE Fortran change broke RISC-V linux build patrick at rivosinc dot com
2023-07-20 22:16 ` [Bug libfortran/110759] " patrick at rivosinc dot com
@ 2023-07-20 22:18 ` pinskia at gcc dot gnu.org
2023-07-20 22:19 ` pinskia at gcc dot gnu.org
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-07-20 22:18 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110759
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |14.0
Summary|IEEE Fortran change broke |[14 Regression] IEEE
|RISC-V linux build |Fortran change broke RISC-V
| |linux build
Keywords| |build
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libfortran/110759] [14 Regression] IEEE Fortran change broke RISC-V linux build
2023-07-20 22:15 [Bug libfortran/110759] New: IEEE Fortran change broke RISC-V linux build patrick at rivosinc dot com
2023-07-20 22:16 ` [Bug libfortran/110759] " patrick at rivosinc dot com
2023-07-20 22:18 ` [Bug libfortran/110759] [14 Regression] " pinskia at gcc dot gnu.org
@ 2023-07-20 22:19 ` pinskia at gcc dot gnu.org
2023-07-20 22:21 ` patrick at rivosinc dot com
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-07-20 22:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110759
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I don't see how it could have broke riscv only ...
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libfortran/110759] [14 Regression] IEEE Fortran change broke RISC-V linux build
2023-07-20 22:15 [Bug libfortran/110759] New: IEEE Fortran change broke RISC-V linux build patrick at rivosinc dot com
` (2 preceding siblings ...)
2023-07-20 22:19 ` pinskia at gcc dot gnu.org
@ 2023-07-20 22:21 ` patrick at rivosinc dot com
2023-07-21 2:10 ` pinskia at gcc dot gnu.org
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: patrick at rivosinc dot com @ 2023-07-20 22:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110759
--- Comment #3 from Patrick O'Neill <patrick at rivosinc dot com> ---
It may have broken other targets - I can only confirm with builds for RISCV so
I didn't want to speculate too much
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libfortran/110759] [14 Regression] IEEE Fortran change broke RISC-V linux build
2023-07-20 22:15 [Bug libfortran/110759] New: IEEE Fortran change broke RISC-V linux build patrick at rivosinc dot com
` (3 preceding siblings ...)
2023-07-20 22:21 ` patrick at rivosinc dot com
@ 2023-07-21 2:10 ` pinskia at gcc dot gnu.org
2023-07-21 2:19 ` patrick at rivosinc dot com
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-07-21 2:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110759
--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
What exact target? Is this the elf target or the linux target?
I just bootstrapped on x86_64-linux-gnu and it works.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libfortran/110759] [14 Regression] IEEE Fortran change broke RISC-V linux build
2023-07-20 22:15 [Bug libfortran/110759] New: IEEE Fortran change broke RISC-V linux build patrick at rivosinc dot com
` (4 preceding siblings ...)
2023-07-21 2:10 ` pinskia at gcc dot gnu.org
@ 2023-07-21 2:19 ` patrick at rivosinc dot com
2023-07-21 2:24 ` pinskia at gcc dot gnu.org
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: patrick at rivosinc dot com @ 2023-07-21 2:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110759
--- Comment #5 from Patrick O'Neill <patrick at rivosinc dot com> ---
Linux target rv32gc-ilp32d, rv64gc-lp64d.
Newlib still builds successfully.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libfortran/110759] [14 Regression] IEEE Fortran change broke RISC-V linux build
2023-07-20 22:15 [Bug libfortran/110759] New: IEEE Fortran change broke RISC-V linux build patrick at rivosinc dot com
` (5 preceding siblings ...)
2023-07-21 2:19 ` patrick at rivosinc dot com
@ 2023-07-21 2:24 ` pinskia at gcc dot gnu.org
2023-07-21 2:30 ` pinskia at gcc dot gnu.org
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-07-21 2:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110759
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
Last reconfirmed| |2023-07-21
--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I see the problem now.
537 #ifdef HAVE_GFC_REAL_16
538 # define EXPAND_INTER_MACRO_16(TYPE,OP)
_gfortran_ieee_/**/TYPE/**/_/**/OP/**/_16
539 #else
540 # define EXPAND_INTER_MACRO_16(TYPE,OP)
541 #endif
542
...
552 EXPAND_INTER_MACRO_16(TYPE,OP) , \
The comma should be part of EXPAND_INTER_MACRO_16 macro instead.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libfortran/110759] [14 Regression] IEEE Fortran change broke RISC-V linux build
2023-07-20 22:15 [Bug libfortran/110759] New: IEEE Fortran change broke RISC-V linux build patrick at rivosinc dot com
` (6 preceding siblings ...)
2023-07-21 2:24 ` pinskia at gcc dot gnu.org
@ 2023-07-21 2:30 ` pinskia at gcc dot gnu.org
2023-07-21 2:31 ` patrick at rivosinc dot com
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-07-21 2:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110759
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Target| |!=x86_64
Assignee|unassigned at gcc dot gnu.org |pinskia at gcc dot gnu.org
--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I will commit a fix in a hour or two; just going to build to make sure it
works.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libfortran/110759] [14 Regression] IEEE Fortran change broke RISC-V linux build
2023-07-20 22:15 [Bug libfortran/110759] New: IEEE Fortran change broke RISC-V linux build patrick at rivosinc dot com
` (7 preceding siblings ...)
2023-07-21 2:30 ` pinskia at gcc dot gnu.org
@ 2023-07-21 2:31 ` patrick at rivosinc dot com
2023-07-21 5:30 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: patrick at rivosinc dot com @ 2023-07-21 2:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110759
--- Comment #8 from Patrick O'Neill <patrick at rivosinc dot com> ---
Awesome, thank you!
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libfortran/110759] [14 Regression] IEEE Fortran change broke RISC-V linux build
2023-07-20 22:15 [Bug libfortran/110759] New: IEEE Fortran change broke RISC-V linux build patrick at rivosinc dot com
` (8 preceding siblings ...)
2023-07-21 2:31 ` patrick at rivosinc dot com
@ 2023-07-21 5:30 ` cvs-commit at gcc dot gnu.org
2023-07-21 5:31 ` pinskia at gcc dot gnu.org
2023-07-21 7:47 ` fxcoudert at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-07-21 5:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110759
--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:
https://gcc.gnu.org/g:f32518726ee8e836d12d49aec8432679fcc42503
commit r14-2695-gf32518726ee8e836d12d49aec8432679fcc42503
Author: Andrew Pinski <apinski@marvell.com>
Date: Fri Jul 21 02:26:09 2023 +0000
libfortran: Fix build for targets that don't have 10byte or 16 byte
floating point
So the problem here is EXPAND_INTER_MACRO_16 expands to nothing if 16 byte
FP does not
exist but we still add a comma after it and that causes a build failure.
The same is true for EXPAND_INTER_MACRO_10 too.
Committed as obvious after a bootstrap and test on x86_64-linux-gnu and
aarch64-linux-gnu.
libgfortran/ChangeLog:
PR libfortran/110759
* ieee/ieee_arithmetic.F90
(COMP_INTERFACE): Remove the comma after EXPAND_INTER_MACRO_16
and EXPAND_INTER_MACRO_10.
(EXPAND_INTER_MACRO_16): Add comma here if 16 byte fp exist.
(EXPAND_INTER_MACRO_10): Likewise.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libfortran/110759] [14 Regression] IEEE Fortran change broke RISC-V linux build
2023-07-20 22:15 [Bug libfortran/110759] New: IEEE Fortran change broke RISC-V linux build patrick at rivosinc dot com
` (9 preceding siblings ...)
2023-07-21 5:30 ` cvs-commit at gcc dot gnu.org
@ 2023-07-21 5:31 ` pinskia at gcc dot gnu.org
2023-07-21 7:47 ` fxcoudert at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-07-21 5:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110759
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #10 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libfortran/110759] [14 Regression] IEEE Fortran change broke RISC-V linux build
2023-07-20 22:15 [Bug libfortran/110759] New: IEEE Fortran change broke RISC-V linux build patrick at rivosinc dot com
` (10 preceding siblings ...)
2023-07-21 5:31 ` pinskia at gcc dot gnu.org
@ 2023-07-21 7:47 ` fxcoudert at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: fxcoudert at gcc dot gnu.org @ 2023-07-21 7:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110759
--- Comment #11 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Thanks Andrew for fixing it, my mistake. Apologies to everyone.
^ permalink raw reply [flat|nested] 13+ messages in thread