public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "linkw at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/110776] [14 Regression] powerpc-darwin bootstrap broken after r14-2490 with ICE rs6000.cc:5069 building libgfortran Date: Wed, 26 Jul 2023 02:54:56 +0000 [thread overview] Message-ID: <bug-110776-4-HJFaOb9CLa@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-110776-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110776 --- Comment #9 from Kewen Lin <linkw at gcc dot gnu.org> --- (In reply to Iain Sandoe from comment #8) > (In reply to rguenther@suse.de from comment #7) > > On Tue, 25 Jul 2023, linkw at gcc dot gnu.org wrote: > > > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110776 > > > > > > --- Comment #6 from Kewen Lin <linkw at gcc dot gnu.org> --- > > > (In reply to rguenther@suse.de from comment #5) > > > > On Tue, 25 Jul 2023, linkw at gcc dot gnu.org wrote: > > > > > > > > I think apart from the consideration what a single element vector > > > > is compared to a scalar, a more to-the-point fix is > > > > > > > > if (VECTOR_TYPE_P (ltype) > > > > && memory_access_type != VMAT_ELEMENTWISE) > > > > > > Thanks for the suggestion! I thought checking lnel can also cover > > > VMAT_STRIDED_SLP's special case having const_nunits 1, but it seems impossible > > > to have? > > > > I think so, unless I'm convinced with a testcase ;) I guess there is no such test case. ;) > > (sorry for being a bit slow - we had a power outage that wasted most of the > day) > > Richi's suggested patch fixes build of a cross-build for powerpc-darwin and > the test results look OK too. A non-expert look at the code suggests that > VMAT_ELEMENTWISE is already accounted for on the write side, so that we > should not see a call to the costing code for the equivalent write-side. Thanks Iain, I also bootstrapped and regtested the suggested fix on x86 and powerpc64{,le}, just posted it for review at https://gcc.gnu.org/pipermail/gcc-patches/2023-July/625484.html.
next prev parent reply other threads:[~2023-07-26 2:54 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-22 15:45 [Bug target/110776] New: " iains at gcc dot gnu.org 2023-07-22 15:48 ` [Bug target/110776] " iains at gcc dot gnu.org 2023-07-22 16:07 ` pinskia at gcc dot gnu.org 2023-07-24 1:49 ` linkw at gcc dot gnu.org 2023-07-25 2:52 ` linkw at gcc dot gnu.org 2023-07-25 2:54 ` linkw at gcc dot gnu.org 2023-07-25 6:34 ` rguenther at suse dot de 2023-07-25 6:53 ` linkw at gcc dot gnu.org 2023-07-25 11:05 ` rguenther at suse dot de 2023-07-25 19:44 ` iains at gcc dot gnu.org 2023-07-26 2:54 ` linkw at gcc dot gnu.org [this message] 2023-07-27 2:43 ` cvs-commit at gcc dot gnu.org 2023-07-27 2:45 ` linkw at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-110776-4-HJFaOb9CLa@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).