[Bug c++/110835] New: -fsanitize=address causes slowdown from std::rethrow_exception not called

[Bug c++/110835] New: -fsanitize=address causes slowdown from std::rethrow_exception not called

[ed at catmur dot uk]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110835

            Bug ID: 110835
           Summary: -fsanitize=address causes slowdown from
                    std::rethrow_exception not called
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ed at catmur dot uk
  Target Milestone: ---

#include <exception>
std::exception_ptr p;
void f() {
  try { throw 1; } catch(char) { std::rethrow_exception(p); }
}
int main() {
  for (int i = 0; i != 100000; ++i)
    try { f(); } catch (...) { }
}

Compiled with -fsanitize=address (and at -O0 through -O3), this is roughly 30x
slower under gcc 13 than under gcc 12 (4.7s vs 0.15s on my Core i7 3 GHz).

Note that the std::rethrow_exception() is not called, but is still essential to
exhibit the bug. Also `f` needs to be a separate function (and not `static`).
At low optimization levels it can be an iife.

[Bug c++/110835] -fsanitize=address causes slowdown from std::rethrow_exception not called

[ed at catmur dot uk]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110835

--- Comment #1 from Ed Catmur <ed at catmur dot uk> ---
Motivation is
https://github.com/boostorg/exception/blob/b039b4ea18ef752d0c1684b3f715ce493b778060/include/boost/exception/detail/exception_ptr.hpp#L550
; the half-reduced code is:

#include <boost/exception_ptr.hpp>
struct S {};
int main() {
    auto ep = boost::copy_exception(S());
    for (int i = 0; i != 100000; ++i)
        try { boost::rethrow_exception(ep); } catch (...) {}
}

[Bug sanitizer/110835] -fsanitize=address causes slowdown from std::rethrow_exception not called

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110835

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dodji at gcc dot gnu.org,
                   |                            |dvyukov at gcc dot gnu.org,
                   |                            |jakub at gcc dot gnu.org,
                   |                            |kcc at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org
          Component|c++                         |sanitizer

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
The code generation does not look any difference ...
So I am suspecting this was a library change.
Which might mean it is an issue in LLVM too ...

[Bug sanitizer/110835] -fsanitize=address causes slowdown from std::rethrow_exception not called

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110835

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #2)
> Which might mean it is an issue in LLVM too ...

Yes the same runtime regression shows up between clang 15 and clang 16. This
should reported upstream to them too.

[Bug sanitizer/110835] [13/14 Regression] -fsanitize=address causes huge runtime slowdown from std::rethrow_exception not called

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110835

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|-fsanitize=address causes   |[13/14 Regression]
                   |slowdown from               |-fsanitize=address causes
                   |std::rethrow_exception not  |huge runtime slowdown from
                   |called                      |std::rethrow_exception not
                   |                            |called
   Target Milestone|---                         |13.3
   Last reconfirmed|                            |2023-07-28
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed.

[Bug sanitizer/110835] [13/14 Regression] -fsanitize=address causes huge runtime slowdown from std::rethrow_exception not called

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110835

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #3)
> (In reply to Andrew Pinski from comment #2)
> > Which might mean it is an issue in LLVM too ...
> 
> Yes the same runtime regression shows up between clang 15 and clang 16. This
> should reported upstream to them too.

What is interesting is that with -stdlib=libc++ the regression for clang/LLVM
shows up between their 14 and 15 releases.

Anyways this should be filed upstream ...

[Bug sanitizer/110835] [13/14 Regression] -fsanitize=address causes huge runtime slowdown from std::rethrow_exception not called

[ed at catmur dot uk]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110835

--- Comment #6 from Ed Catmur <ed at catmur dot uk> ---
Thanks, filed https://github.com/llvm/llvm-project/issues/64190 .

[Bug sanitizer/110835] [13/14 Regression] -fsanitize=address causes huge runtime slowdown from std::rethrow_exception not called

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110835

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tnfchris at gcc dot gnu.org

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 112981 has been marked as a duplicate of this bug. ***

[Bug sanitizer/110835] [13/14 Regression] -fsanitize=address causes huge runtime slowdown from std::rethrow_exception not called

[law at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110835

Jeffrey A. Law <law at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |law at gcc dot gnu.org
           Priority|P3                          |P2

[Bug sanitizer/110835] [13/14/15 Regression] -fsanitize=address causes huge runtime slowdown from std::rethrow_exception not called

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110835

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|13.3                        |13.4

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 13.3 is being released, retargeting bugs to GCC 13.4.