[Bug target/110843] New: ICE in convert_insn, at config/i386/i386-features.cc:1438 since r14-2405-g4814b63c3c2326

[Bug target/110843] New: ICE in convert_insn, at config/i386/i386-features.cc:1438 since r14-2405-g4814b63c3c2326

[jamborm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110843

            Bug ID: 110843
           Summary: ICE in convert_insn, at
                    config/i386/i386-features.cc:1438 since
                    r14-2405-g4814b63c3c2326
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jamborm at gcc dot gnu.org
                CC: sayle at gcc dot gnu.org
  Target Milestone: ---
              Host: x86_64-linux
            Target: x86_64-linux

Since r14-2405-g4814b63c3c2326 (i386: Add AVX512 support for STV of
SI/DImode rotation by constant), I can see an ICE when compiling
testcase gcc.target/i386/pr70007.c with options -Oz -mavx512ifma:

mjambor@scala:/tmp$ ~/gcc/mine/inst/bin/gcc
~/gcc/mine/src/gcc/testsuite/gcc.target/i386/pr70007.c -Oz -mavx512ifma
/home/mjambor/gcc/mine/src/gcc/testsuite/gcc.target/i386/pr70007.c: In function
‘foo’:
/home/mjambor/gcc/mine/src/gcc/testsuite/gcc.target/i386/pr70007.c:22:1: error:
unrecognizable insn:
   22 | }
      | ^
(insn 11 10 86 3 (set (subreg:V2DI (reg:DI 160) 0)
        (rotatert:V2DI (subreg:V2DI (reg:DI 106) 0)
            (const_int 19 [0x13])))
"/home/mjambor/gcc/mine/src/gcc/testsuite/gcc.target/i386/pr70007.c":17:55 -1
     (expr_list:REG_DEAD (reg:DI 106)
        (expr_list:REG_UNUSED (reg:CC 17 flags)
            (nil))))
during RTL pass: stv
/home/mjambor/gcc/mine/src/gcc/testsuite/gcc.target/i386/pr70007.c:22:1:
internal compiler error: in convert_insn, at config/i386/i386-features.cc:1438
0x7cc810 _fatal_insn(char const*, rtx_def const*, char const*, int, char
const*)
        /home/mjambor/gcc/mine/src/gcc/rtl-error.cc:108
0x7cc82c _fatal_insn_not_found(rtx_def const*, char const*, int, char const*)
        /home/mjambor/gcc/mine/src/gcc/rtl-error.cc:116
0x86e6d4 convert_insn
        /home/mjambor/gcc/mine/src/gcc/config/i386/i386-features.cc:1438
0x141e59e convert
        /home/mjambor/gcc/mine/src/gcc/config/i386/i386-features.cc:1975
0x141e59e convert_scalars_to_vector
        /home/mjambor/gcc/mine/src/gcc/config/i386/i386-features.cc:2515
0x141e59e execute
        /home/mjambor/gcc/mine/src/gcc/config/i386/i386-features.cc:2678
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug target/110843] ICE in convert_insn, at config/i386/i386-features.cc:1438 since r14-2405-g4814b63c3c2326

[roger at nextmovesoftware dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110843

Roger Sayle <roger at nextmovesoftware dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
                 CC|                            |roger at nextmovesoftware dot com
           Assignee|unassigned at gcc dot gnu.org      |roger at nextmovesoftware dot com
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2023-07-28

--- Comment #1 from Roger Sayle <roger at nextmovesoftware dot com> ---
My STV patch should check TARGET_AVX512VL (which is required for V2DI in
VI48_AVX512VL) and not TARGET_AVX512F which is the condition in the define_insn
for vp<rotate>.  Bootstrapping and regression testing a fix.

[Bug target/110843] [14 Regression] ICE in convert_insn, at config/i386/i386-features.cc:1438 since r14-2405-g4814b63c3c2326

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110843

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0
            Summary|ICE in convert_insn, at     |[14 Regression] ICE in
                   |config/i386/i386-features.c |convert_insn, at
                   |c:1438 since                |config/i386/i386-features.c
                   |r14-2405-g4814b63c3c2326    |c:1438 since
                   |                            |r14-2405-g4814b63c3c2326

[Bug target/110843] [14 Regression] ICE in convert_insn, at config/i386/i386-features.cc:1438 since r14-2405-g4814b63c3c2326

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110843

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Roger Sayle <sayle@gcc.gnu.org>:

https://gcc.gnu.org/g:129feec0ba4f8ce74edf1fdf7da37b54968d3d37

commit r14-2874-g129feec0ba4f8ce74edf1fdf7da37b54968d3d37
Author: Roger Sayle <roger@nextmovesoftware.com>
Date:   Mon Jul 31 08:08:11 2023 +0100

    [Committed] PR target/110843: Check TARGET_AVX512VL for V2DI rotates in
STV.

    This patch resolves PR target/110843, an ICE caused by my enhancement to
    support AVX512 DImode and SImode rotates in the scalar-to-vector (STV)
pass.
    Although the vprotate instructions are available on all TARGET_AVX512F
    microarchitectures, the V2DI and V4SI variants are only available on the
    TARGET_AVX512VL subset, leading to problems when command line options
    enable AVX512 (i.e. AVX512F) but not the required AVX512VL functionality.
    The simple fix is to update/correct the target checks.

    2023-07-31  Roger Sayle  <roger@nextmovesoftware.com>

    gcc/ChangeLog
            PR target/110843
            * config/i386/i386-features.cc (compute_convert_gain): Check
            TARGET_AVX512VL (not TARGET_AVX512F) when considering V2DImode
            and V4SImode rotates in STV.
            (general_scalar_chain::convert_rotate): Likewise.

    gcc/testsuite/ChangeLog
            PR target/110843
            * gcc.target/i386/pr110843.c: New test case.

[Bug target/110843] [14 Regression] ICE in convert_insn, at config/i386/i386-features.cc:1438 since r14-2405-g4814b63c3c2326

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110843

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.