[Bug middle-end/110864] New: [14 Regression] ICE in combine.cc causes stage2 build failure on RISCV

[Bug middle-end/110864] New: [14 Regression] ICE in combine.cc causes stage2 build failure on RISCV

[patrick at rivosinc dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110864

            Bug ID: 110864
           Summary: [14 Regression] ICE in combine.cc causes stage2 build
                    failure on RISCV
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: patrick at rivosinc dot com
  Target Milestone: ---

Created attachment 55667
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55667&action=edit
Full build log with the error

Using https://github.com/riscv-collab/riscv-gnu-toolchain with tip-of-tree GCC
fails to build rv32gc linux target.

Here's the error:
during RTL pass: combine
../../../../gcc/libitm/beginend.cc: In static member function 'static uint32_t
GTM::gtm_thread::begin_transaction(uint32_t, const GTM::gtm_jmpbuf*)':
../../../../gcc/libitm/beginend.cc:425:1: internal compiler error: in
decompose, at rtl.h:2297
  425 | }
      | ^

The full log with the traceback is attached.

Affects rv32gc linux. rv64gc linux and rv{32|64}gc Newlib/musl still build.

I haven't attempted to bootstrap other architectures so it may affect those as
well.

I've partially bisected it down to 5 possible commits:
Known to fail: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=75d62394
Known to succeed: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=05986af

I'll continue bisecting and keep this issue updated.

[Bug middle-end/110864] [14 Regression] ICE in combine.cc causes stage2 build failure on RISCV

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110864

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Most likely the same issue as on arm:
https://gcc.gnu.org/pipermail/gcc-patches/2023-July/625913.html

[Bug middle-end/110864] [14 Regression] ICE in combine.cc causes stage2 build failure on RISCV

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110864

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0
           Keywords|                            |ice-on-valid-code

[Bug middle-end/110864] [14 Regression] ICE in combine.cc causes stage2 build failure on RISCV

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110864

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
That is:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=7cdd0860949c6c3232e6cff1d7ca37bb5234074c

[Bug rtl-optimization/110864] [14 Regression] ICE in combine.cc causes stage2 build failure on RISCV

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110864

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Can you test the patch in bug 110867 comment #1 to see if fixes the issue here
too?

[Bug rtl-optimization/110864] [14 Regression] ICE in combine.cc causes stage2 build failure on RISCV

[patrick at rivosinc dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110864

--- Comment #4 from Patrick O'Neill <patrick at rivosinc dot com> ---
Yep! Running bootstrap+regtests with the fix now.

[Bug rtl-optimization/110864] [14 Regression] ICE in combine.cc causes stage2 build failure on RISCV

[patrick at rivosinc dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110864

--- Comment #5 from Patrick O'Neill <patrick at rivosinc dot com> ---
The fix resolves the bootstrap error. Still running the testsuite.

[Bug rtl-optimization/110864] [14 Regression] ICE in combine.cc causes stage2 build failure on RISCV

[patrick at rivosinc dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110864

--- Comment #6 from Patrick O'Neill <patrick at rivosinc dot com> ---
No new regressions in the testsuite - that fix will work!

[Bug rtl-optimization/110864] [14 Regression] ICE in combine.cc causes stage2 build failure on RISCV

[patrick at rivosinc dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110864

Patrick O'Neill <patrick at rivosinc dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Patrick O'Neill <patrick at rivosinc dot com> ---
Resolved by PR110867 fix: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110867

[Bug rtl-optimization/110864] [14 Regression] ICE in combine.cc causes stage2 build failure on RISCV

[xry111 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110864
Bug 110864 depends on bug 110867, which changed state.

Bug 110867 Summary: [14 Regression] ICE in combine after 7cdd0860949c6c3232e6cff1d7ca37bb5234074c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110867

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |DUPLICATE