public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libfortran/110966] New: should matmul_c8_avx512f be updated with matmul_c8_x86-64-v4.
@ 2023-08-10 6:29 crazylht at gmail dot com
2023-08-10 8:09 ` [Bug libfortran/110966] " rguenth at gcc dot gnu.org
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: crazylht at gmail dot com @ 2023-08-10 6:29 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110966
Bug ID: 110966
Summary: should matmul_c8_avx512f be updated with
matmul_c8_x86-64-v4.
Product: gcc
Version: 14.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libfortran
Assignee: unassigned at gcc dot gnu.org
Reporter: crazylht at gmail dot com
Target Milestone: ---
In libgfortran/m4/matmul.m4, we have
#ifdef HAVE_AVX512F
'define(`matmul_name',`matmul_'rtype_code`_avx512f')dnl
`static void
'matmul_name` ('rtype` * const restrict retarray,
'rtype` * const restrict a, 'rtype` * const restrict b, int try_blas,
int blas_limit, blas_call gemm) __attribute__((__target__("avx512f")));
static' include(matmul_internal.m4)dnl
`#endif /* HAVE_AVX512F */
But target ("avx512f") only enable -mavx512f which has quite limited capability
of AVX512. Since now we have arch level, should we use target("arch=x86-64-v4")
instead.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libfortran/110966] should matmul_c8_avx512f be updated with matmul_c8_x86-64-v4.
2023-08-10 6:29 [Bug libfortran/110966] New: should matmul_c8_avx512f be updated with matmul_c8_x86-64-v4 crazylht at gmail dot com
@ 2023-08-10 8:09 ` rguenth at gcc dot gnu.org
2023-08-10 8:33 ` crazylht at gmail dot com
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-08-10 8:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110966
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target| |x86_64-*-*
--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
I think matmul is fine with avx512f or avx, so requiring/using only the base
ISA level sounds fine to me.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libfortran/110966] should matmul_c8_avx512f be updated with matmul_c8_x86-64-v4.
2023-08-10 6:29 [Bug libfortran/110966] New: should matmul_c8_avx512f be updated with matmul_c8_x86-64-v4 crazylht at gmail dot com
2023-08-10 8:09 ` [Bug libfortran/110966] " rguenth at gcc dot gnu.org
@ 2023-08-10 8:33 ` crazylht at gmail dot com
2023-08-13 20:24 ` anlauf at gcc dot gnu.org
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: crazylht at gmail dot com @ 2023-08-10 8:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110966
--- Comment #2 from Hongtao.liu <crazylht at gmail dot com> ---
(In reply to Richard Biener from comment #1)
> I think matmul is fine with avx512f or avx, so requiring/using only the base
> ISA level sounds fine to me.
Could be potential miss-optimization.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libfortran/110966] should matmul_c8_avx512f be updated with matmul_c8_x86-64-v4.
2023-08-10 6:29 [Bug libfortran/110966] New: should matmul_c8_avx512f be updated with matmul_c8_x86-64-v4 crazylht at gmail dot com
2023-08-10 8:09 ` [Bug libfortran/110966] " rguenth at gcc dot gnu.org
2023-08-10 8:33 ` crazylht at gmail dot com
@ 2023-08-13 20:24 ` anlauf at gcc dot gnu.org
2023-08-14 2:26 ` crazylht at gmail dot com
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: anlauf at gcc dot gnu.org @ 2023-08-13 20:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110966
--- Comment #3 from anlauf at gcc dot gnu.org ---
(In reply to Hongtao.liu from comment #2)
> (In reply to Richard Biener from comment #1)
> > I think matmul is fine with avx512f or avx, so requiring/using only the base
> > ISA level sounds fine to me.
>
> Could be potential miss-optimization.
Do you mean a missed optimzation?
Or really wrong code?
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libfortran/110966] should matmul_c8_avx512f be updated with matmul_c8_x86-64-v4.
2023-08-10 6:29 [Bug libfortran/110966] New: should matmul_c8_avx512f be updated with matmul_c8_x86-64-v4 crazylht at gmail dot com
` (2 preceding siblings ...)
2023-08-13 20:24 ` anlauf at gcc dot gnu.org
@ 2023-08-14 2:26 ` crazylht at gmail dot com
2023-11-13 20:50 ` tkoenig at gcc dot gnu.org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: crazylht at gmail dot com @ 2023-08-14 2:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110966
--- Comment #4 from Hongtao.liu <crazylht at gmail dot com> ---
(In reply to anlauf from comment #3)
> (In reply to Hongtao.liu from comment #2)
> > (In reply to Richard Biener from comment #1)
> > > I think matmul is fine with avx512f or avx, so requiring/using only the base
> > > ISA level sounds fine to me.
> >
> > Could be potential miss-optimization.
>
> Do you mean a missed optimzation?
>
> Or really wrong code?
a missed optimzation.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libfortran/110966] should matmul_c8_avx512f be updated with matmul_c8_x86-64-v4.
2023-08-10 6:29 [Bug libfortran/110966] New: should matmul_c8_avx512f be updated with matmul_c8_x86-64-v4 crazylht at gmail dot com
` (3 preceding siblings ...)
2023-08-14 2:26 ` crazylht at gmail dot com
@ 2023-11-13 20:50 ` tkoenig at gcc dot gnu.org
2023-11-14 2:31 ` crazylht at gmail dot com
2024-01-08 1:57 ` liuhongt at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2023-11-13 20:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110966
Thomas Koenig <tkoenig at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
CC| |tkoenig at gcc dot gnu.org
Status|UNCONFIRMED |WAITING
Last reconfirmed| |2023-11-13
--- Comment #5 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
(In reply to Hongtao.liu from comment #4)
> (In reply to anlauf from comment #3)
> > (In reply to Hongtao.liu from comment #2)
> > > (In reply to Richard Biener from comment #1)
> > > > I think matmul is fine with avx512f or avx, so requiring/using only the base
> > > > ISA level sounds fine to me.
> > >
> > > Could be potential miss-optimization.
> >
> > Do you mean a missed optimzation?
> >
> > Or really wrong code?
>
> a missed optimzation.
Are there benchmarks which show that the code would indeed run
faster?
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libfortran/110966] should matmul_c8_avx512f be updated with matmul_c8_x86-64-v4.
2023-08-10 6:29 [Bug libfortran/110966] New: should matmul_c8_avx512f be updated with matmul_c8_x86-64-v4 crazylht at gmail dot com
` (4 preceding siblings ...)
2023-11-13 20:50 ` tkoenig at gcc dot gnu.org
@ 2023-11-14 2:31 ` crazylht at gmail dot com
2024-01-08 1:57 ` liuhongt at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: crazylht at gmail dot com @ 2023-11-14 2:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110966
--- Comment #6 from Hongtao.liu <crazylht at gmail dot com> ---
(In reply to Thomas Koenig from comment #5)
> (In reply to Hongtao.liu from comment #4)
> > (In reply to anlauf from comment #3)
> > > (In reply to Hongtao.liu from comment #2)
> > > > (In reply to Richard Biener from comment #1)
> > > > > I think matmul is fine with avx512f or avx, so requiring/using only the base
> > > > > ISA level sounds fine to me.
> > > >
> > > > Could be potential miss-optimization.
> > >
> > > Do you mean a missed optimzation?
> > >
> > > Or really wrong code?
> >
> > a missed optimzation.
>
> Are there benchmarks which show that the code would indeed run
> faster?
Not yet, just better in theory .
But considering that there might be some tweaks regarding x86-64-v4, I think
it's best to leave it unchanged for the time being.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libfortran/110966] should matmul_c8_avx512f be updated with matmul_c8_x86-64-v4.
2023-08-10 6:29 [Bug libfortran/110966] New: should matmul_c8_avx512f be updated with matmul_c8_x86-64-v4 crazylht at gmail dot com
` (5 preceding siblings ...)
2023-11-14 2:31 ` crazylht at gmail dot com
@ 2024-01-08 1:57 ` liuhongt at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: liuhongt at gcc dot gnu.org @ 2024-01-08 1:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110966
Hongtao Liu <liuhongt at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |INVALID
Status|WAITING |RESOLVED
CC| |liuhongt at gcc dot gnu.org
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-01-08 1:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-10 6:29 [Bug libfortran/110966] New: should matmul_c8_avx512f be updated with matmul_c8_x86-64-v4 crazylht at gmail dot com
2023-08-10 8:09 ` [Bug libfortran/110966] " rguenth at gcc dot gnu.org
2023-08-10 8:33 ` crazylht at gmail dot com
2023-08-13 20:24 ` anlauf at gcc dot gnu.org
2023-08-14 2:26 ` crazylht at gmail dot com
2023-11-13 20:50 ` tkoenig at gcc dot gnu.org
2023-11-14 2:31 ` crazylht at gmail dot com
2024-01-08 1:57 ` liuhongt at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).