[Bug c++/111066] New: g++.dg/special/initpri3.C fails on darwin

[Bug c++/111066] New: g++.dg/special/initpri3.C fails on darwin

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111066

            Bug ID: 111066
           Summary: g++.dg/special/initpri3.C fails on darwin
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: fxcoudert at gcc dot gnu.org
  Target Milestone: ---

A warning there triggers the failure:

FAIL: g++.dg/special/initpri3.C  at line 10 (test for warnings, line 9)
FAIL: g++.dg/special/initpri3.C (test for excess errors)
Excess errors:
/tmp/gcc-darwin-arm64/gcc/testsuite/g++.dg/special/initpri3.C:9:55: warning:
'init_priority' attribute ignored [-Wattributes]

[Bug c++/111066] g++.dg/special/initpri3.C fails on darwin

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111066

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
             Target|                            |x86_64-apple-darwin20
              Build|                            |x86_64-apple-darwin20
                 CC|                            |ppalka at gcc dot gnu.org
               Host|                            |x86_64-apple-darwin20
   Last reconfirmed|                            |2023-08-18

--- Comment #1 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Seen in multiple test runs, like this one:
https://gcc.gnu.org/pipermail/gcc-testresults/2023-August/793205.html

[Bug testsuite/111066] g++.dg/special/initpri3.C fails on darwin

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111066

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
The wording of the warning is different from what dg-warning directive in the
testcase expects.

diff --git a/gcc/testsuite/g++.dg/special/initpri3.C
b/gcc/testsuite/g++.dg/special/initpri3.C
index 3d745a42a6a..63ed3208228 100644
--- a/gcc/testsuite/g++.dg/special/initpri3.C
+++ b/gcc/testsuite/g++.dg/special/initpri3.C
@@ -7,4 +7,4 @@
 #endif

 struct A { A(); } a __attribute__((init_priority(500)));
-// { dg-warning "attribute directive ignored" "" { target { ! init_priority }
} .-1 }
+// { dg-warning "attribute ignored" "" { target { ! init_priority } } .-1 }


Is the correct fix I think. The directive in the warning only comes from
namespace and using uses.

[Bug testsuite/111066] g++.dg/special/initpri3.C fails on darwin

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111066

--- Comment #3 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Makes sense, patch posted:
https://gcc.gnu.org/pipermail/gcc-patches/2023-August/627922.html

[Bug testsuite/111066] g++.dg/special/initpri3.C fails on darwin

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111066

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Fixed on mainline (14).

[Bug testsuite/111066] g++.dg/special/initpri3.C fails on darwin

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111066

--- Comment #5 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Iain D Sandoe
<iains@gcc.gnu.org>:

https://gcc.gnu.org/g:f650cfccc61f0352f9c3a0993457e1cb7845bc7a

commit r13-8564-gf650cfccc61f0352f9c3a0993457e1cb7845bc7a
Author: Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Date:   Sat Aug 19 22:37:33 2023 +0200

    Testsuite: fix contructor priority test

    Fix the expected warning wording for targets without constructor
    priority, like Darwin, making the test pass.

    gcc/testsuite/ChangeLog:

            PR testsuite/111066
            * g++.dg/special/initpri3.C: Fix wording.

    (cherry picked from commit 78f636d979530c8a649262dbd44914bdfb6f7290)