[Bug c++/111091] New: Split view with double quoted string

[Bug c++/111091] New: Split view with double quoted string

[deco33000 at yandex dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111091

            Bug ID: 111091
           Summary: Split view with double quoted string
           Product: gcc
           Version: 13.2.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: deco33000 at yandex dot com
  Target Milestone: ---

Hi,

I have just been caught by an overlook using range split, but it may happen to
others.

The issue is the Try1 bypasses the delimiter (maybe because of a char
conversion?)
The other versions work fine though..

As usual, to ease your life: https://godbolt.org/z/7nMK46bjq

--------------------------------------------
#include <iostream>
#include <ranges>
#include <string>
#include <string_view>

using namespace std; // for simplicity

int main() {

    string a{"Part A / Part B"};

    {
        cout << "Try 1 : with double quote (wrong behavior? delim is
bypassed)\n";

        auto v = ::ranges::views::split(a, "/");

        for (auto &&word : v) {

            cout << string_view(word) << ' ';
        }

        cout << "\n\n";
    }
    {
        cout << "Try 1bis : explicitly convert to string: OK\n";

        auto v = ::ranges::views::split(a, string("/"));

        for (auto &&word : v) {

            cout << string_view(word) << ' ';
        }

        cout << "\n\n";
    }
    {
        cout << "Try 2 : with single quote: OK\n";

        auto v = ::ranges::views::split(a, '/');

        for (auto &&word : v) {

            cout << string_view(word) << ' ';
        }

        cout << "\n\n";
    }

    {
        cout << "Try 3 : with string delimiter: OK\n";
        string delim{"/"};
        auto v = ::ranges::views::split(a, delim);

        for (auto &&word : v) {

            cout << string_view(word) << ' ';
        }

        cout << "\n\n";
    }

    {
        cout << "Try 4 : with string delimiter: OK\n";
        string delim{'/'};
        auto v = ::ranges::views::split(a, delim);

        for (auto &&word : v) {

            cout << string_view(word) << ' ';
        }

        cout << "\n\n";
    }

    return 0;
}

Do you think we could make Try1 to work properly ?
Thanks

[Bug c++/111091] Split view with double quoted string

[deco33000 at yandex dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111091

--- Comment #1 from KL <deco33000 at yandex dot com> ---
The godbolt has the clang compiler set but it was just to compare the output
(which has the same output given the same libstdc++).
Sorry for this.

[Bug libstdc++/111091] Split view with double quoted string

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111091

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Both libstdc++ and libc++ have the same behavior for Try1 ...

[Bug libstdc++/111091] Split view with double quoted string

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111091

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ppalka at gcc dot gnu.org
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #3 from Patrick Palka <ppalka at gcc dot gnu.org> ---
Thanks for the report.  Although the behavior may seem surprising I believe
it's working as specified.  The string literal "/" when treated as a range
includes the null terminator, so we're actually splitting at occurrences of '/'
followed by '\0', of which there are none in the input string.  The
corresponding std::string or std::string_view doesn't include the null
terminator and so does the expected thing.

[Bug libstdc++/111091] Split view with double quoted string

[deco33000 at yandex dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111091

--- Comment #4 from KL <deco33000 at yandex dot com> ---
I get it.

Must be more careful :)

Thanks