public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/111271] New: gcc/fortran/trans-expr.cc:1134:8: warning: duplicated ‘if’ condition [-Wduplicated-cond]
@ 2023-09-01 15:00 dcb314 at hotmail dot com
2023-09-01 15:09 ` [Bug fortran/111271] " dcb314 at hotmail dot com
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: dcb314 at hotmail dot com @ 2023-09-01 15:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111271
Bug ID: 111271
Summary: gcc/fortran/trans-expr.cc:1134:8: warning: duplicated
‘if’ condition [-Wduplicated-cond]
Product: gcc
Version: unknown
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: fortran
Assignee: unassigned at gcc dot gnu.org
Reporter: dcb314 at hotmail dot com
Target Milestone: ---
Source code is
if (unlimited_poly)
{
// ...
}
else if (unlimited_poly)
{
ctree = gfc_class_len_get (var);
gfc_add_modify (&parmse->pre, ctree,
fold_convert (TREE_TYPE (ctree),
integer_zero_node));
}
Suggest code rework.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug fortran/111271] gcc/fortran/trans-expr.cc:1134:8: warning: duplicated ‘if’ condition [-Wduplicated-cond]
2023-09-01 15:00 [Bug fortran/111271] New: gcc/fortran/trans-expr.cc:1134:8: warning: duplicated ‘if’ condition [-Wduplicated-cond] dcb314 at hotmail dot com
@ 2023-09-01 15:09 ` dcb314 at hotmail dot com
2023-09-12 16:54 ` pault at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: dcb314 at hotmail dot com @ 2023-09-01 15:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111271
David Binderman <dcb314 at hotmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pault at gcc dot gnu.org
--- Comment #1 from David Binderman <dcb314 at hotmail dot com> ---
git blame says
6c95fe9bc0 (Paul Thomas 2023-05-16 06:35:40 +0100 1087) if
(unlimited_poly)
...
6c95fe9bc0 (Paul Thomas 2023-05-16 06:35:40 +0100 1134) else if
(unlimited_poly)
Adding Paul for their best advice.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug fortran/111271] gcc/fortran/trans-expr.cc:1134:8: warning: duplicated ‘if’ condition [-Wduplicated-cond]
2023-09-01 15:00 [Bug fortran/111271] New: gcc/fortran/trans-expr.cc:1134:8: warning: duplicated ‘if’ condition [-Wduplicated-cond] dcb314 at hotmail dot com
2023-09-01 15:09 ` [Bug fortran/111271] " dcb314 at hotmail dot com
@ 2023-09-12 16:54 ` pault at gcc dot gnu.org
2023-09-24 8:01 ` cvs-commit at gcc dot gnu.org
2023-09-24 8:03 ` pault at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: pault at gcc dot gnu.org @ 2023-09-12 16:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111271
Paul Thomas <pault at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2023-09-12
Ever confirmed|0 |1
Assignee|unassigned at gcc dot gnu.org |pault at gcc dot gnu.org
Status|UNCONFIRMED |NEW
--- Comment #2 from Paul Thomas <pault at gcc dot gnu.org> ---
(In reply to David Binderman from comment #1)
> git blame says
>
> 6c95fe9bc0 (Paul Thomas 2023-05-16 06:35:40 +0100 1087) if
> (unlimited_poly)
>
> ...
>
> 6c95fe9bc0 (Paul Thomas 2023-05-16 06:35:40 +0100 1134) else
> if (unlimited_poly)
>
> Adding Paul for their best advice.
Hah! You got me.
r14-870-g6c95fe9bc0553743098eeaa739f14b885050fa42
Thanks for pointing it out. The fix is easy enough.....
Paul
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug fortran/111271] gcc/fortran/trans-expr.cc:1134:8: warning: duplicated ‘if’ condition [-Wduplicated-cond]
2023-09-01 15:00 [Bug fortran/111271] New: gcc/fortran/trans-expr.cc:1134:8: warning: duplicated ‘if’ condition [-Wduplicated-cond] dcb314 at hotmail dot com
2023-09-01 15:09 ` [Bug fortran/111271] " dcb314 at hotmail dot com
2023-09-12 16:54 ` pault at gcc dot gnu.org
@ 2023-09-24 8:01 ` cvs-commit at gcc dot gnu.org
2023-09-24 8:03 ` pault at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-09-24 8:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111271
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Paul Thomas <pault@gcc.gnu.org>:
https://gcc.gnu.org/g:c23ce23e9ce162c49bca8900c8a20079b49501c9
commit r14-4242-gc23ce23e9ce162c49bca8900c8a20079b49501c9
Author: Paul Thomas <pault@gcc.gnu.org>
Date: Sun Sep 24 09:00:52 2023 +0100
Fortran: Pad mismatched charlens in component initializers [PR68155]
2023-09-24 Paul Thomas <pault@gcc.gnu.org>
gcc/fortran
PR fortran/68155
* decl.cc (fix_initializer_charlen): New function broken out of
add_init_expr_to_sym.
(add_init_expr_to_sym, build_struct): Call the new function.
PR fortran/111271
* trans-expr.cc (gfc_conv_intrinsic_to_class): Remove repeated
condition.
gcc/testsuite/
PR fortran/68155
* gfortran.dg/pr68155.f90: New test.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug fortran/111271] gcc/fortran/trans-expr.cc:1134:8: warning: duplicated ‘if’ condition [-Wduplicated-cond]
2023-09-01 15:00 [Bug fortran/111271] New: gcc/fortran/trans-expr.cc:1134:8: warning: duplicated ‘if’ condition [-Wduplicated-cond] dcb314 at hotmail dot com
` (2 preceding siblings ...)
2023-09-24 8:01 ` cvs-commit at gcc dot gnu.org
@ 2023-09-24 8:03 ` pault at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: pault at gcc dot gnu.org @ 2023-09-24 8:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111271
Paul Thomas <pault at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Paul Thomas <pault at gcc dot gnu.org> ---
Fixed - thanks for the report.
Paul
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-09-24 8:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-01 15:00 [Bug fortran/111271] New: gcc/fortran/trans-expr.cc:1134:8: warning: duplicated ‘if’ condition [-Wduplicated-cond] dcb314 at hotmail dot com
2023-09-01 15:09 ` [Bug fortran/111271] " dcb314 at hotmail dot com
2023-09-12 16:54 ` pault at gcc dot gnu.org
2023-09-24 8:01 ` cvs-commit at gcc dot gnu.org
2023-09-24 8:03 ` pault at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).