[Bug modula2/111330] New: [13 Regression] Bootstrap failure building SeqFile.lo

[Bug modula2/111330] New: [13 Regression] Bootstrap failure building SeqFile.lo

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111330

            Bug ID: 111330
           Summary: [13 Regression] Bootstrap failure building SeqFile.lo
           Product: gcc
           Version: 13.2.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: modula2
          Assignee: gaius at gcc dot gnu.org
          Reporter: jakub at gcc dot gnu.org
  Target Milestone: ---

I've done a successful Fedora distro build of GCC 13
r13-7622-g3e9aaa9bcb2fc64e64
based snapshot and that and all earlier ones went fine, but when trying to
build
a r13-7778-g78f63dd9fa9ff29949 based snapshot, I'm seeing weird Modula 2
failures.
See https://kojipkgs.fedoraproject.org//work/tasks/4565/105824565/build.log
or https://kojipkgs.fedoraproject.org//work/tasks/4525/105824525/build.log
etc., it is all arches.  What I see in the logs is:
/bin/sh ../libtool --tag=CC   --mode=compile
/builddir/build/BUILD/gcc-13.2.1-20230906/obj-x86_64-redhat-linux/./gcc/gm2
-B/builddir/build/BUILD/gcc-13.2.1-20230906/obj-x86_64-redhat-linux/./gcc/ -c
-O2 -fexceptions -g -grecord-gcc-switches -Wall -Wformat-security
-Wp,-D_GLIBCXX_ASSERTIONS -mtune=generic -fasynchronous-unwind-tables
-fstack-clash-protection -fcf-protection -O2 -fexceptions -g
-grecord-gcc-switches -Wall -Wformat-security -Wp,-D_GLIBCXX_ASSERTIONS
-mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection
-fcf-protection -fm2-pathname=m2iso -I. -Ilibm2iso
-I/builddir/build/BUILD/gcc-13.2.1-20230906/gcc/m2/gm2-libs-iso
-fm2-pathname=m2pim -I/builddir/build/BUILD/gcc-13.2.1-20230906/gcc/m2/gm2-libs
-fiso -fextended-opaque -fm2-g -g -Wreturn-type -fcase -fm2-prefix=m2iso
../../../../libgm2/libm2iso/../../gcc/m2/gm2-libs-iso/SeqFile.mod -o SeqFile.lo
libtool: compile: 
/builddir/build/BUILD/gcc-13.2.1-20230906/obj-x86_64-redhat-linux/./gcc/gm2
-B/builddir/build/BUILD/gcc-13.2.1-20230906/obj-x86_64-redhat-linux/./gcc/ -c
-O2 -fexceptions -g -grecord-gcc-switches -Wall -Wformat-security
-Wp,-D_GLIBCXX_ASSERTIONS -mtune=generic -fasynchronous-unwind-tables
-fstack-clash-protection -fcf-protection -O2 -fexceptions -g
-grecord-gcc-switches -Wall -Wformat-security -Wp,-D_GLIBCXX_ASSERTIONS
-mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection
-fcf-protection -fm2-pathname=m2iso -I. -Ilibm2iso
-I/builddir/build/BUILD/gcc-13.2.1-20230906/gcc/m2/gm2-libs-iso
-fm2-pathname=m2pim -I/builddir/build/BUILD/gcc-13.2.1-20230906/gcc/m2/gm2-libs
-fiso -fextended-opaque -fm2-g -g -Wreturn-type -fcase -fm2-prefix=m2iso
../../../../libgm2/libm2iso/../../gcc/m2/gm2-libs-iso/SeqFile.mod  -fPIC -DPIC
-o .libs/SeqFile.o
../../gcc/m2/gm2-compiler/M2SymInit.def:1:case statement has no matching
selection
make[5]: *** [Makefile:912: SeqFile.lo] Error 1

Now, I have no idea if this case statement has no matching selection message is
an error or not and if it is, if it is what caused SeqFile.lo to fail building.

I've reproduced it in a local Fedora mock, but when I do make -j32 in the
libgm2 build directory afterwards, everything including SeqFile.lo builds fine,
so I wonder if it isn't another case of missing Makefile dependencies or
something similar.

Any ideas (including ideas what I could try to understand what's going on)?

[Bug modula2/111330] [13 Regression] Bootstrap failure building SeqFile.lo

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111330

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
So far bisected to between r13-7647 (builds fine) and r13-7660 (fails to
build), and can reproduce even without bootstrap.  I suspect r13-7650 but will
confirm it or not soon.

[Bug modula2/111330] [13 Regression] Bootstrap failure building SeqFile.lo

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111330

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.3

[Bug modula2/111330] [13 Regression] Bootstrap failure building SeqFile.lo

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111330

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Though, bisection points to r13-7651-g824a37d0bfa9f5c232 as first commit which
fails to build.

[Bug modula2/111330] [13 Regression] Bootstrap failure building SeqFile.lo

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111330

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
So, narrowed it down to Fedora build doing essentially (stripped down from all
languages etc.):
CC=gcc \
CXX=g++ \
CFLAGS='-O2 -fexceptions -g -grecord-gcc-switches -Wall -Wformat-security
-Wp,-D_GLIBCXX_ASSERTIONS -mtune=generic -fasynchronous-unwind-tables
-fstack-clash-protection -fcf-protection' \
CXXFLAGS=' -O2 -g -grecord-gcc-switches -Wformat -Wformat-security
-Wp,-D_GLIBCXX_ASSERTIONS -mtune=generic -fasynchronous-unwind-tables
-fstack-clash-protection -fcf-protection ' \
XCFLAGS='-O2 -fexceptions -g -grecord-gcc-switches -Wall -Wformat-security
-Wp,-D_GLIBCXX_ASSERTIONS -mtune=generic -fasynchronous-unwind-tables
-fstack-clash-protection -fcf-protection' \
TCFLAGS='-O2 -fexceptions -g -grecord-gcc-switches -Wall -Wformat-security
-Wp,-D_GLIBCXX_ASSERTIONS -mtune=generic -fasynchronous-unwind-tables
-fstack-clash-protection -fcf-protection' \
../configure --disable-bootstrap --enable-languages=c,c++,m2,lto
--enable-checking=release --enable-multilib --disable-libsanitizer
--with-gcc-major-version-only --enable-plugin --enable-gnu-indirect-function
--enable-cet --with-tune=generic --with-arch_32=i686
--build=x86_64-redhat-linux
make -j32 'BOOT_CFLAGS=-O2 -fexceptions -g -grecord-gcc-switches -Wall
-Wformat-security -Wp,-D_GLIBCXX_ASSERTIONS -mtune=generic
-fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection'
LDFLAGS_FOR_TARGET=-Wl,-z,relro,-z,now

And what matters is using -Wall during the build in *FLAGS.
/builddir/build/BUILD/gcc-13.2.1-20230728/obj-x86_64-redhat-linux/./gcc/gm2
-B/builddir/build/BUILD/gcc-13.2.1-20230728/obj-x86_64-redhat-linux/./gcc/ -c
-O2 -Wall -fm2-pathname=m2iso -I. -Ilibm2iso
-I/builddir/build/BUILD/gcc-13.2.1-20230728/gcc/m2/gm2-libs-iso
-fm2-pathname=m2pim -I/builddir/build/BUILD/gcc-13.2.1-20230728/gcc/m2/gm2-libs
-fiso -fextended-opaque -fm2-g -g -Wreturn-type -fcase -fm2-prefix=m2iso
../../../../libgm2/libm2iso/../../gcc/m2/gm2-libs-iso/SeqFile.mod  -fPIC -DPIC
-o .libs/SeqFile.o; echo $?
../../gcc/m2/gm2-compiler/M2SymInit.def:1:case statement has no matching
selection
1
while
/builddir/build/BUILD/gcc-13.2.1-20230728/obj-x86_64-redhat-linux/./gcc/gm2
-B/builddir/build/BUILD/gcc-13.2.1-20230728/obj-x86_64-redhat-linux/./gcc/ -c
-O2 -fm2-pathname=m2iso -I. -Ilibm2iso
-I/builddir/build/BUILD/gcc-13.2.1-20230728/gcc/m2/gm2-libs-iso
-fm2-pathname=m2pim -I/builddir/build/BUILD/gcc-13.2.1-20230728/gcc/m2/gm2-libs
-fiso -fextended-opaque -fm2-g -g -Wreturn-type -fcase -fm2-prefix=m2iso
../../../../libgm2/libm2iso/../../gcc/m2/gm2-libs-iso/SeqFile.mod  -fPIC -DPIC
-o .libs/SeqFile.o; echo $?
0

Shouldn't -Wall affect just warnings (without -Werror) and not whether
compilation succeeds or fails?

[Bug modula2/111330] [13 Regression] Bootstrap failure building SeqFile.lo

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111330

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Seems
sed -i -e 's/ -fcase / -fcase -Wno-all /' libgm2/*/Makefile.am
sed -i -e 's/ -fcase / -fcase -Wno-all /' libgm2/*/Makefile.in
can work as a work-around for this bug, but it would still be nice to
understand what's going on and get it fixed.

[Bug modula2/111330] [13 Regression] Bootstrap failure building SeqFile.lo

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111330

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2023-09-09
     Ever confirmed|0                           |1

--- Comment #5 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Ah yes I think the culprit is the largest case statement inside M2SymInit.mod
(at line 1272).

[Bug modula2/111330] [13 Regression] Bootstrap failure building SeqFile.lo

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111330

--- Comment #6 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 55864
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55864&action=edit
Proposed fix

Here is a proposed interim patch.  In the meantime I'll hunt down the missing
case clause (and fix the error location for the original bug).

(Although a caveat that I'm currently still bootstrapping on:
 Linux fedora 6.2.14-300.fc38.x86_64)

[Bug modula2/111330] [13 Regression] Bootstrap failure building SeqFile.lo

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111330

--- Comment #7 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 55876
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55876&action=edit
Proposed fix v2

Here is the second version of the patch which contains the missing case clauses
(rather than the else catch all).  I've a followup patch for gm2 -fcase to
enumerate all missing clauses which will follow shortly.

[Bug modula2/111330] [13 Regression] Bootstrap failure building SeqFile.lo

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111330

--- Comment #8 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 55880
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55880&action=edit
Proposed fix v3

Here is v2 together with the -Wcase-enum switch implemented (and related
fixes).
I'll git commit v2 and separately v3 on master and back port to gcc-13.

[Bug modula2/111330] [13 Regression] Bootstrap failure building SeqFile.lo

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111330

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:fbd72a2108d1c05ef7f50acd71d518e769abcced

commit r14-3856-gfbd72a2108d1c05ef7f50acd71d518e769abcced
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Mon Sep 11 22:28:01 2023 +0100

    PR modula2/111330 Bootstrap failure building SeqFile.lo

    cc1gm2 issues a runtime case statement error and terminates
    when building SeqFile.lo on Fedora mock.  There are four
    missing labels from the largest case statement in M2SymInit.mod.
    This patch adds the case labels and appropriate actions.

    gcc/m2/ChangeLog:

            PR modula2/111330
            * gm2-compiler/M2SymInit.mod (CheckReadBeforeInitQuad): Add
            case labels LogicalDiffOp, DummyOp, OptParamOp and
            InitAddressOp.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

[Bug modula2/111330] [13 Regression] Bootstrap failure building SeqFile.lo

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111330

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Gaius Mulley
<gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:6facc94692fe1a6a64a68c2dec2b87fb79ac853d

commit r13-7790-g6facc94692fe1a6a64a68c2dec2b87fb79ac853d
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Mon Sep 11 22:29:27 2023 +0100

    PR modula2/111330 Bootstrap failure building SeqFile.lo

    cc1gm2 issues a runtime case statement error and terminates
    when building SeqFile.lo on Fedora mock.  There are four
    missing labels from the largest case statement in M2SymInit.mod.
    This patch adds the case labels and appropriate actions.

    gcc/m2/ChangeLog:

            PR modula2/111330
            * gm2-compiler/M2SymInit.mod (CheckReadBeforeInitQuad): Add
            case labels LogicalDiffOp, DummyOp, OptParamOp and
            InitAddressOp.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

[Bug modula2/111330] [13 Regression] Bootstrap failure building SeqFile.lo

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111330

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
           Keywords|                            |build
         Resolution|---                         |FIXED

--- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed then.