[Bug tree-optimization/111349] New: `Optimize (a CMP CST1) ? max<a,CST2> : a` pattern's cmp is missing :c

[Bug tree-optimization/111349] New: `Optimize (a CMP CST1) ? max<a,CST2> : a` pattern's cmp is missing :c

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111349

            Bug ID: 111349
           Summary: `Optimize (a CMP CST1) ? max<a,CST2> : a` pattern's
                    cmp is missing :c
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: missed-optimization
          Severity: enhancement
          Priority: P3
         Component: tree-optimization
          Assignee: pinskia at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---

```
/* Optimize (a CMP CST1) ? max<a,CST2> : a */
(for cmp    (gt  ge  lt  le)
     minmax (min min max max)
 (simplify
  (cond (cmp @0 @1) (minmax:c@2 @0 @3) @4)
```
Just like PR 111348 really.

[Bug tree-optimization/111349] `Optimize (a CMP CST1) ? max<a,CST2> : a` pattern's cmp is missing :c

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111349

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-09-08
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1

[Bug tree-optimization/111349] `Optimize (a CMP CST1) ? max<a,CST2> : a` pattern's cmp is missing :c

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111349

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Created attachment 55874
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55874&action=edit
testcase

Currently test1_  is only able to optimize to `return a;` during fold.
test1 is caught via phiopt (minmax replacement still) and then during ccp1 is
simplified down to a.

[Bug tree-optimization/111349] `Optimize (a CMP CST1) ? max<a,CST2> : a` pattern's cmp is missing :c

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111349

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:b59e9de990a17bfd5fa7252b76339c35bff7f2e8

commit r14-3842-gb59e9de990a17bfd5fa7252b76339c35bff7f2e8
Author: Andrew Pinski <apinski@marvell.com>
Date:   Sun Sep 10 21:58:12 2023 -0700

    MATCH: [PR111349] add missing :c to cmp in the `(a CMP CST1) ? max<a,CST2>
: a` pattern

    When I added this pattern in r14-1411-g17cca3c43e2f49, I had missed the :c
on the cmp
    part of the pattern meaning there might be some missing optimizations
happening.
    The testcase shows an example of the missed optmization.

    Committed as obvious after a bootstrap/test on x86_64-linux-gnu.

            PR tree-optimization/111349

    gcc/ChangeLog:

            * match.pd (`(a CMP CST1) ? max<a,CST2> : a`): Add :c on
            the cmp part of the pattern.

    gcc/testsuite/ChangeLog:

            * gcc.dg/tree-ssa/minmax-25.c: New test.

[Bug tree-optimization/111349] `Optimize (a CMP CST1) ? max<a,CST2> : a` pattern's cmp is missing :c

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111349

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
   Target Milestone|---                         |14.0

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed.