public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug modula2/111510] New: Modula-2 runtime ICE on arm-linux-gnueabihf: iso/RTentity.mod:245:in findChildAndParent has caused internal runtime error, RTentity is either corrupt or the module storage has not been initialized yet
@ 2023-09-21  4:34 doko at gcc dot gnu.org
  2023-09-21 10:18 ` [Bug modula2/111510] " gaius at gcc dot gnu.org
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: doko at gcc dot gnu.org @ 2023-09-21  4:34 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111510

            Bug ID: 111510
           Summary: Modula-2 runtime ICE on arm-linux-gnueabihf:
                    iso/RTentity.mod:245:in findChildAndParent has caused
                    internal runtime error, RTentity is either corrupt or
                    the module storage has not been initialized yet
           Product: gcc
           Version: 13.2.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: modula2
          Assignee: gaius at gcc dot gnu.org
          Reporter: doko at gcc dot gnu.org
  Target Milestone: ---

seen with current gcc-13 branch, that used to work with GCC 12 before (although
M2 was not yet merged at this time). running a simple HelloWorld.mod on
arm-linux-gnueabihf fails with:

2746s autopkgtest [17:26:10]: test libgm2-link: [-----------------------
2748s build: OK
2748s   libm2cor.so.18 => /lib/arm-linux-gnueabihf/libm2cor.so.18 (0xf7eec000)
2748s   libm2pim.so.18 => /lib/arm-linux-gnueabihf/libm2pim.so.18 (0xf7ec8000)
2748s   libm2iso.so.18 => /lib/arm-linux-gnueabihf/libm2iso.so.18 (0xf7ea1000)
2748s   libstdc++.so.6 => /lib/arm-linux-gnueabihf/libstdc++.so.6 (0xf7cf6000)
2748s   libgcc_s.so.1 => /lib/arm-linux-gnueabihf/libgcc_s.so.1 (0xf7cdc000)
2748s   libc.so.6 => /lib/arm-linux-gnueabihf/libc.so.6 (0xf7bac000)
2748s   /lib/ld-linux-armhf.so.3 (0xf7eff000)
2748s   libm.so.6 => /lib/arm-linux-gnueabihf/libm.so.6 (0xf7b6a000)
2748s
../../../../src/libgm2/libm2iso/../../gcc/m2/gm2-libs-iso/RTentity.mod:245:in
findChildAndParent has caused internal runtime error, RTentity is either
corrupt or the module storage has not been initialized yet
2749s autopkgtest [17:26:13]: test libgm2-link: -----------------------]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug modula2/111510] Modula-2 runtime ICE on arm-linux-gnueabihf: iso/RTentity.mod:245:in findChildAndParent has caused internal runtime error, RTentity is either corrupt or the module storage has not been initialized yet
  2023-09-21  4:34 [Bug modula2/111510] New: Modula-2 runtime ICE on arm-linux-gnueabihf: iso/RTentity.mod:245:in findChildAndParent has caused internal runtime error, RTentity is either corrupt or the module storage has not been initialized yet doko at gcc dot gnu.org
@ 2023-09-21 10:18 ` gaius at gcc dot gnu.org
  2023-09-26 13:46 ` gaius at gcc dot gnu.org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: gaius at gcc dot gnu.org @ 2023-09-21 10:18 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111510

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-09-21
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #1 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Thanks for the bug report - I'm rebuilding gcc-13 for arm-linux-gnueabihf - but
the build will complete after I leave for the cauldron.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug modula2/111510] Modula-2 runtime ICE on arm-linux-gnueabihf: iso/RTentity.mod:245:in findChildAndParent has caused internal runtime error, RTentity is either corrupt or the module storage has not been initialized yet
  2023-09-21  4:34 [Bug modula2/111510] New: Modula-2 runtime ICE on arm-linux-gnueabihf: iso/RTentity.mod:245:in findChildAndParent has caused internal runtime error, RTentity is either corrupt or the module storage has not been initialized yet doko at gcc dot gnu.org
  2023-09-21 10:18 ` [Bug modula2/111510] " gaius at gcc dot gnu.org
@ 2023-09-26 13:46 ` gaius at gcc dot gnu.org
  2023-09-26 17:09 ` cvs-commit at gcc dot gnu.org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: gaius at gcc dot gnu.org @ 2023-09-26 13:46 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111510

--- Comment #2 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 55996
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55996&action=edit
Proposed fix

Here is a proposed fix - the bug was the lack of a nul terminated string -
resulting in garbled init order of modules.  This affects all targets and is
present in gcc-13 and gcc-14.  When (if) it bootstraps (on both gcc-14 and
gcc-13) - I'll apply the patch.  Thanks for the bug report!

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug modula2/111510] Modula-2 runtime ICE on arm-linux-gnueabihf: iso/RTentity.mod:245:in findChildAndParent has caused internal runtime error, RTentity is either corrupt or the module storage has not been initialized yet
  2023-09-21  4:34 [Bug modula2/111510] New: Modula-2 runtime ICE on arm-linux-gnueabihf: iso/RTentity.mod:245:in findChildAndParent has caused internal runtime error, RTentity is either corrupt or the module storage has not been initialized yet doko at gcc dot gnu.org
  2023-09-21 10:18 ` [Bug modula2/111510] " gaius at gcc dot gnu.org
  2023-09-26 13:46 ` gaius at gcc dot gnu.org
@ 2023-09-26 17:09 ` cvs-commit at gcc dot gnu.org
  2023-09-26 18:43 ` cvs-commit at gcc dot gnu.org
  2023-09-26 18:45 ` gaius at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-09-26 17:09 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111510

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:53daf67fd55e005e37cb3ab33ac0783a71761de9

commit r14-4282-g53daf67fd55e005e37cb3ab33ac0783a71761de9
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Tue Sep 26 18:08:37 2023 +0100

    PR modula2/111510 runtime ICE findChildAndParent has caused internal
runtime error

    This patch fixes the runtime bug above.  The full runtime message is:
    findChildAndParent has caused internal runtime error, RTentity is either
    corrupt or the module storage has not been initialized yet.  The bug is
    due to a non nul terminated string determining the module initialization
order.
    This results in modules being uninitialized and the above crash.  The bug
    manifests itself on 32 bit systems - but obviously is latent on all
    targets and the fix should be applied to both gcc-14 and gcc-13.

    gcc/m2/ChangeLog:

            PR modula2/111510
            * gm2-compiler/M2GenGCC.mod (IsExportedGcc): Minor spacing changes.
            (BuildTrashTreeFromInterface): Minor spacing changes.
            * gm2-compiler/M2Options.mod (GetRuntimeModuleOverride): Call
            string to generate a nul terminated C style string.
            * gm2-compiler/M2Quads.mod (BuildStringAdrParam): New procedure.
            (BuildM2InitFunction): Replace inline parameter generation with
            calls to BuildStringAdrParam.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug modula2/111510] Modula-2 runtime ICE on arm-linux-gnueabihf: iso/RTentity.mod:245:in findChildAndParent has caused internal runtime error, RTentity is either corrupt or the module storage has not been initialized yet
  2023-09-21  4:34 [Bug modula2/111510] New: Modula-2 runtime ICE on arm-linux-gnueabihf: iso/RTentity.mod:245:in findChildAndParent has caused internal runtime error, RTentity is either corrupt or the module storage has not been initialized yet doko at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2023-09-26 17:09 ` cvs-commit at gcc dot gnu.org
@ 2023-09-26 18:43 ` cvs-commit at gcc dot gnu.org
  2023-09-26 18:45 ` gaius at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-09-26 18:43 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111510

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Gaius Mulley
<gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:b92cddb94874df4b9451d9cea3efa88f0654981b

commit r13-7842-gb92cddb94874df4b9451d9cea3efa88f0654981b
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Tue Sep 26 19:39:59 2023 +0100

    PR modula2/111510 runtime ICE findChildAndParent has caused internal
runtime error

    This patch fixes the runtime bug above.  The full runtime message is:
    findChildAndParent has caused internal runtime error, RTentity is either
    corrupt or the module storage has not been initialized yet.  The bug is
    due to a non nul terminated string determining the module initialization
order.
    This results in modules being uninitialized and the above crash.  The bug
    manifests itself on 32 bit systems - but obviously is latent on all
    targets and the fix should be applied to both gcc-14 and gcc-13.

    gcc/m2/ChangeLog:

            PR modula2/111510
            * gm2-compiler/M2GenGCC.mod (IsExportedGcc): Minor spacing changes.
            (BuildTrashTreeFromInterface): Minor spacing changes.
            * gm2-compiler/M2Options.mod (GetRuntimeModuleOverride): Call
            string to generate a nul terminated C style string.
            * gm2-compiler/M2Quads.mod (BuildStringAdrParam): New procedure.
            (BuildM2InitFunction): Replace inline parameter generation with
            calls to BuildStringAdrParam.

    (cherry picked from commit 53daf67fd55e005e37cb3ab33ac0783a71761de9)

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug modula2/111510] Modula-2 runtime ICE on arm-linux-gnueabihf: iso/RTentity.mod:245:in findChildAndParent has caused internal runtime error, RTentity is either corrupt or the module storage has not been initialized yet
  2023-09-21  4:34 [Bug modula2/111510] New: Modula-2 runtime ICE on arm-linux-gnueabihf: iso/RTentity.mod:245:in findChildAndParent has caused internal runtime error, RTentity is either corrupt or the module storage has not been initialized yet doko at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2023-09-26 18:43 ` cvs-commit at gcc dot gnu.org
@ 2023-09-26 18:45 ` gaius at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: gaius at gcc dot gnu.org @ 2023-09-26 18:45 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111510

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #5 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Closing now that the patches have been applied.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-09-26 18:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-21  4:34 [Bug modula2/111510] New: Modula-2 runtime ICE on arm-linux-gnueabihf: iso/RTentity.mod:245:in findChildAndParent has caused internal runtime error, RTentity is either corrupt or the module storage has not been initialized yet doko at gcc dot gnu.org
2023-09-21 10:18 ` [Bug modula2/111510] " gaius at gcc dot gnu.org
2023-09-26 13:46 ` gaius at gcc dot gnu.org
2023-09-26 17:09 ` cvs-commit at gcc dot gnu.org
2023-09-26 18:43 ` cvs-commit at gcc dot gnu.org
2023-09-26 18:45 ` gaius at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).