public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/111557] New: [RISC-V] The macro __riscv_unaligned_fast should be __riscv_misaligned_fast
@ 2023-09-23 19:31 lasse.collin at tukaani dot org
2023-11-16 18:27 ` [Bug target/111557] " cvs-commit at gcc dot gnu.org
2023-11-16 18:49 ` vineetg at gcc dot gnu.org
0 siblings, 2 replies; 3+ messages in thread
From: lasse.collin at tukaani dot org @ 2023-09-23 19:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111557
Bug ID: 111557
Summary: [RISC-V] The macro __riscv_unaligned_fast should be
__riscv_misaligned_fast
Product: gcc
Version: 14.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: target
Assignee: unassigned at gcc dot gnu.org
Reporter: lasse.collin at tukaani dot org
Target Milestone: ---
The RISC-V C API Specification[1] has __riscv_misaligned_fast,
__riscv_misaligned_slow, and __riscv_misaligned_avoid. The commit 6e23440b [2]
used "unaligned" instead of "misaligned" though. The spelling
__riscv_unaligned_* was mentioned in [3] but in [4] it was changed to
__riscv_misaligned_*.
Clang doesn't have these macros yet but there is a recent pull request[5] that
uses the __riscv_misaligned_* spelling.
[1] https://github.com/riscv-non-isa/riscv-c-api-doc/blob/master/riscv-c-api.md
[2]
https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=6e23440b5df4011bbe1dbee74d47641125dd7d16
[3] https://github.com/riscv-non-isa/riscv-c-api-doc/issues/32
[4] https://github.com/riscv-non-isa/riscv-c-api-doc/pull/40
[5] https://github.com/llvm/llvm-project/pull/65756
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug target/111557] [RISC-V] The macro __riscv_unaligned_fast should be __riscv_misaligned_fast
2023-09-23 19:31 [Bug target/111557] New: [RISC-V] The macro __riscv_unaligned_fast should be __riscv_misaligned_fast lasse.collin at tukaani dot org
@ 2023-11-16 18:27 ` cvs-commit at gcc dot gnu.org
2023-11-16 18:49 ` vineetg at gcc dot gnu.org
1 sibling, 0 replies; 3+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-11-16 18:27 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111557
--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Edwin Lu <ewlu@gcc.gnu.org>:
https://gcc.gnu.org/g:a671095c208c7cf5eb934b6a31bd9fb6f6640a6b
commit r14-5540-ga671095c208c7cf5eb934b6a31bd9fb6f6640a6b
Author: Edwin Lu <ewlu@rivosinc.com>
Date: Wed Nov 15 13:22:11 2023 -0800
RISC-V: Change unaligned fast/slow/avoid macros to misaligned [PR111557]
Fix __riscv_unaligned_fast/slow/avoid macro name to
__riscv_misaligned_fast/slow/avoid to be consistent with the RISC-V API
Spec
PR target/111557
gcc/ChangeLog:
* config/riscv/riscv-c.cc (riscv_cpu_cpp_builtins): update macro
name
gcc/testsuite/ChangeLog:
* gcc.target/riscv/attribute-1.c: update macro name
* gcc.target/riscv/attribute-4.c: ditto
* gcc.target/riscv/attribute-5.c: ditto
* gcc.target/riscv/predef-align-1.c: ditto
* gcc.target/riscv/predef-align-2.c: ditto
* gcc.target/riscv/predef-align-3.c: ditto
* gcc.target/riscv/predef-align-4.c: ditto
* gcc.target/riscv/predef-align-5.c: ditto
* gcc.target/riscv/predef-align-6.c: ditto
Signed-off-by: Edwin Lu <ewlu@rivosinc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug target/111557] [RISC-V] The macro __riscv_unaligned_fast should be __riscv_misaligned_fast
2023-09-23 19:31 [Bug target/111557] New: [RISC-V] The macro __riscv_unaligned_fast should be __riscv_misaligned_fast lasse.collin at tukaani dot org
2023-11-16 18:27 ` [Bug target/111557] " cvs-commit at gcc dot gnu.org
@ 2023-11-16 18:49 ` vineetg at gcc dot gnu.org
1 sibling, 0 replies; 3+ messages in thread
From: vineetg at gcc dot gnu.org @ 2023-11-16 18:49 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111557
Vineet Gupta <vineetg at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
--- Comment #2 from Vineet Gupta <vineetg at gcc dot gnu.org> ---
Fixed in gcc-14.
Not keeping old names for "compatibility sake" since the original change (also
gcc-14) has technically not shipped.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-16 18:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-23 19:31 [Bug target/111557] New: [RISC-V] The macro __riscv_unaligned_fast should be __riscv_misaligned_fast lasse.collin at tukaani dot org
2023-11-16 18:27 ` [Bug target/111557] " cvs-commit at gcc dot gnu.org
2023-11-16 18:49 ` vineetg at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).