[Bug modula2/111627] New: modula2: Excess test fails with a case-preserving-case-insensitive source tree.

[Bug modula2/111627] New: modula2: Excess test fails with a case-preserving-case-insensitive source tree.

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111627

            Bug ID: 111627
           Summary: modula2: Excess test fails with a
                    case-preserving-case-insensitive source tree.
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: modula2
          Assignee: gaius at gcc dot gnu.org
          Reporter: iains at gcc dot gnu.org
  Target Milestone: ---

Created attachment 56008
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56008&action=edit
diff of excess fails between non and case sensitive source partition.

macOS defaults to case-preserving-case-insensitive.

It does allow case-sensitive file systems, *but most end-users will not be
using them*.

Now, on the systems that have default (case-preserving-case-insensitive)
**source** partitions, we see extra m2 fails (which do not show on the ones
with case-sensitive source partitions).

[Bug modula2/111627] modula2: Excess test fails with a case-preserving-case-insensitive source tree.

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111627

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-9-28
             Target|                            |*-*-darwin*
           Keywords|                            |rejects-valid
               Host|                            |*-*-darwin*
   Target Milestone|---                         |14.0

[Bug modula2/111627] modula2: Excess test fails with a case-preserving-case-insensitive source tree.

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111627

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
   Last reconfirmed|2023-09-28 00:00:00         |2023-11-14

--- Comment #1 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Thanks for the bug report - will fix!

[Bug modula2/111627] modula2: Excess test fails with a case-preserving-case-insensitive source tree.

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111627

--- Comment #2 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 57267
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57267&action=edit
Proposed fix

Here is a proposed patch, the problem was fixed by renaming conflicting
testnames.  There were some testsuite named modules which matched library names
(but used a different case).

[Bug modula2/111627] modula2: Excess test fails with a case-preserving-case-insensitive source tree.

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111627

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:4fd094835a8997cdcc3d18d7d297debe1527202d

commit r14-8663-g4fd094835a8997cdcc3d18d7d297debe1527202d
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Wed Jan 31 15:44:32 2024 +0000

    PR modula2/111627 Excess test fails with a case-preserving-case-insensitive
source tree

    This patch renames gm2 testsuite modules whose names conflict with library
    modules.  The conflict is not seen on case preserving case sensitive file
    systems.

    gcc/testsuite/ChangeLog:

            PR modula2/111627
            * gm2/pim/pass/stdio.mod: Moved to...
            * gm2/pim/pass/teststdio.mod: ...here.
            * gm2/pim/run/pass/builtins.mod: Moved to...
            * gm2/pim/run/pass/testbuiltins.mod: ...here.
            * gm2/pim/run/pass/math.mod: Moved to...
            * gm2/pim/run/pass/testmath.mod: ...here.
            * gm2/pim/run/pass/math2.mod: Moved to...
            * gm2/pim/run/pass/testmath2.mod: ...here.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

[Bug modula2/111627] modula2: Excess test fails with a case-preserving-case-insensitive source tree.

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111627

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Bootstrapped on a jfs case-preserving-case-insensitive gnu-linux system.  All
regressions pass.  Optimistically closing the PR.

[Bug modula2/111627] modula2: Excess test fails with a case-preserving-case-insensitive source tree.

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111627

--- Comment #5 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:75f49cf82e06971b066b4f440256004775603752

commit r14-8684-g75f49cf82e06971b066b4f440256004775603752
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Thu Feb 1 10:24:02 2024 +0000

    PR modula2/111627 defend against ICE

    Although PR 111627 can be fixed by renaming testsuite modules it
    highlighted that a possible ICE can occur if a malformed
    implementation module is actually a program module.  This small
    patch defends against this ICE and checks to see whether the module
    is a DefImp before testing IsDefinitionForC.

    gcc/m2/ChangeLog:

            PR modula2/111627
            PR modula2/112506
            * gm2-compiler/M2Comp.mod (Pass0CheckMod): Test IsDefImp before
            checking IsDefinitionForC.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

[Bug modula2/111627] modula2: Excess test fails with a case-preserving-case-insensitive source tree.

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111627

--- Comment #6 from Iain Sandoe <iains at gcc dot gnu.org> ---
FWIW. testing on i686-darwin9 and x86_64-darwin14 with
case-preserving-non-case-sens shows these fixed.