public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "amonakov at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/111655] [11/12/13/14 Regression] wrong code generated for __builtin_signbit and 0./0. on x86-64 -O2
Date: Mon, 02 Oct 2023 11:08:12 +0000	[thread overview]
Message-ID: <bug-111655-4-ORMASPHMZS@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-111655-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111655

Alexander Monakov <amonakov at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amonakov at gcc dot gnu.org
     Ever confirmed|0                           |1
            Summary|wrong code generated for    |[11/12/13/14 Regression]
                   |__builtin_signbit and 0./0. |wrong code generated for
                   |on x86-64 -O2               |__builtin_signbit and 0./0.
                   |                            |on x86-64 -O2
         Resolution|DUPLICATE                   |---
             Status|RESOLVED                    |NEW
   Last reconfirmed|                            |2023-10-02

--- Comment #9 from Alexander Monakov <amonakov at gcc dot gnu.org> ---
It's true that the sign of 0./0 is unpredictable, but we can fold it only when
the division is being eliminated by the folding. 

It's fine to fold

  t = 0./0;
  s = __builtin_signbit(t);

to

  s = 0

with t eliminated from IR, but it's not OK to fold

  t = 0./0
  s = __builtin_signbit(t);

to

  t = 0./0
  s = 0

because the resulting program runs as if 0./0 was evaluated twice, first to a
positive NaN (which was used for signbit), then to a negative NaN (which fed
the following computations). This is not allowed.

This bug was incorrectly classified as a dup. The fix is either to not fold
this, or fold only when we know that the division will be eliminated (e.g. the
only use was in the signbit). Reopening.

  parent reply	other threads:[~2023-10-02 11:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-01 17:22 [Bug tree-optimization/111655] New: wrong code generated for __builtin_signbit " eggert at cs dot ucla.edu
2023-10-01 17:29 ` [Bug target/111655] " pinskia at gcc dot gnu.org
2023-10-01 17:29 ` pinskia at gcc dot gnu.org
2023-10-01 17:40 ` [Bug target/111655] wrong code generated for __builtin_signbit and 0./0. " pinskia at gcc dot gnu.org
2023-10-01 17:42 ` pinskia at gcc dot gnu.org
2023-10-01 22:08 ` eggert at cs dot ucla.edu
2023-10-01 23:57 ` pinskia at gcc dot gnu.org
2023-10-01 23:59 ` pinskia at gcc dot gnu.org
2023-10-02  0:02 ` pinskia at gcc dot gnu.org
2023-10-02 11:08 ` amonakov at gcc dot gnu.org [this message]
2023-10-04  9:37 ` [Bug middle-end/111655] [11/12/13/14 Regression] " rguenth at gcc dot gnu.org
2023-10-04 11:41 ` amonakov at gcc dot gnu.org
2023-11-24  9:33 ` jakub at gcc dot gnu.org
2023-11-24  9:48 ` amonakov at gcc dot gnu.org
2023-11-24  9:54 ` rguenther at suse dot de
2024-03-22 13:38 ` law at gcc dot gnu.org
2024-03-22 17:09 ` jakub at gcc dot gnu.org
2024-04-19 11:38 ` bruno at clisp dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-111655-4-ORMASPHMZS@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).