public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "amonakov at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/111655] [11/12/13/14 Regression] wrong code generated for __builtin_signbit and 0./0. on x86-64 -O2 Date: Wed, 04 Oct 2023 11:41:20 +0000 [thread overview] Message-ID: <bug-111655-4-mmQS6CoJrL@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-111655-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111655 --- Comment #11 from Alexander Monakov <amonakov at gcc dot gnu.org> --- (In reply to Richard Biener from comment #10) > And this conservatively has to apply to all FP divisions where we might infer > "nonnegative" unless we can also infer !zerop? Yes, I think the logic in tree_binary_nonnegative_warnv_p is incorrect for floating-point division. Likewise for multiplication: it returns true for 'x * x', but when x is a NaN, 'x * x' is also a NaN (potentially with the same sign). > On the side of replacing all uses I'd error on simply not folding. Yes, as preceding transforms might have duplicated the division already. We can only do such folding very early, when we are sure no duplication might have taken place. > Note 6.5.5/6 says "In both operations, if the value of the second operand is > zero, the behavior is undefined." only remotely implying this doesn't > apply to non-integer types (remotely by including modulo behavior in this > sentence). > > Possibly in some other place the C standard makes FP division by zero subject > to other rules. I think the intention is that Annex F makes it follow IEEE rules (returns an Inf/NaN and sets FE_DIVBYZERO/FE_INVALID), but it doesn't seem to be clearly worded, afaict.
next prev parent reply other threads:[~2023-10-04 11:41 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-01 17:22 [Bug tree-optimization/111655] New: wrong code generated for __builtin_signbit " eggert at cs dot ucla.edu 2023-10-01 17:29 ` [Bug target/111655] " pinskia at gcc dot gnu.org 2023-10-01 17:29 ` pinskia at gcc dot gnu.org 2023-10-01 17:40 ` [Bug target/111655] wrong code generated for __builtin_signbit and 0./0. " pinskia at gcc dot gnu.org 2023-10-01 17:42 ` pinskia at gcc dot gnu.org 2023-10-01 22:08 ` eggert at cs dot ucla.edu 2023-10-01 23:57 ` pinskia at gcc dot gnu.org 2023-10-01 23:59 ` pinskia at gcc dot gnu.org 2023-10-02 0:02 ` pinskia at gcc dot gnu.org 2023-10-02 11:08 ` [Bug target/111655] [11/12/13/14 Regression] " amonakov at gcc dot gnu.org 2023-10-04 9:37 ` [Bug middle-end/111655] " rguenth at gcc dot gnu.org 2023-10-04 11:41 ` amonakov at gcc dot gnu.org [this message] 2023-11-24 9:33 ` jakub at gcc dot gnu.org 2023-11-24 9:48 ` amonakov at gcc dot gnu.org 2023-11-24 9:54 ` rguenther at suse dot de 2024-03-22 13:38 ` law at gcc dot gnu.org 2024-03-22 17:09 ` jakub at gcc dot gnu.org 2024-04-19 11:38 ` bruno at clisp dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-111655-4-mmQS6CoJrL@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).