public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rsandifo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/111677] [12/13 Regression] darktable build on aarch64 fails with unrecognizable insn due to -fstack-protector changes
Date: Mon, 29 Jan 2024 17:00:53 +0000 [thread overview]
Message-ID: <bug-111677-4-Zd8j02JTlm@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-111677-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111677
--- Comment #21 from Richard Sandiford <rsandifo at gcc dot gnu.org> ---
(In reply to Alex Coplan from comment #13)
> The problem seems to be this code in aarch64_process_components:
>
> while (regno != last_regno)
> {
> bool frame_related_p = aarch64_emit_cfi_for_reg_p (regno);
> machine_mode mode = aarch64_reg_save_mode (regno);
>
> rtx reg = gen_rtx_REG (mode, regno);
> poly_int64 offset = frame.reg_offset[regno];
> if (frame_pointer_needed)
> offset -= frame.bytes_below_hard_fp;
>
> rtx addr = plus_constant (Pmode, ptr_reg, offset);
> rtx mem = gen_frame_mem (mode, addr);
>
> which emits a TFmode mem with offset 512, which is out of range for TFmode
> (so we later ICE with an unrecognisable insn). Presumably this just needs
> tweaking to emit a new base anchor in the case of large offsets like this.
> It looks like the code in aarch64_save_callee_saves already does this.
We shouldn't emit new anchor registers here, since unlike in the prologue,
we don't have any guarantee that certain registers are free.
aarch64_get_separate_components is supposed to vet shrink-wrappable
offsets, but in this case the offset looks valid, since:
str q22, [sp, #512]
is a valid instruction. Perhaps the constraints are too narrow?
next prev parent reply other threads:[~2024-01-29 17:00 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 14:41 [Bug c/111677] New: arm64 build fails unrecognizable insn [REGRESSION] costamagnagianfranco at yahoo dot it
2023-10-03 22:22 ` [Bug target/111677] " pinskia at gcc dot gnu.org
2023-10-06 7:53 ` costamagnagianfranco at yahoo dot it
2023-10-09 10:37 ` costamagnagianfranco at yahoo dot it
2023-10-24 4:30 ` pinskia at gcc dot gnu.org
2023-10-24 4:33 ` [Bug target/111677] [12/13/14 Regression] darktable build on aarch64 fails with unrecognizable insn due to -fstack-protector changes pinskia at gcc dot gnu.org
2023-10-24 4:33 ` pinskia at gcc dot gnu.org
2023-10-24 11:19 ` costamagnagianfranco at yahoo dot it
2023-10-24 11:54 ` costamagnagianfranco at yahoo dot it
2023-10-24 12:48 ` costamagnagianfranco at yahoo dot it
2023-10-24 12:50 ` costamagnagianfranco at yahoo dot it
2023-10-24 12:55 ` costamagnagianfranco at yahoo dot it
2023-10-24 14:42 ` acoplan at gcc dot gnu.org
2023-10-24 21:58 ` pinskia at gcc dot gnu.org
2023-10-25 11:19 ` acoplan at gcc dot gnu.org
2023-11-22 11:42 ` costamagnagianfranco at yahoo dot it
2024-01-12 15:58 ` germano.massullo at gmail dot com
2024-01-12 16:34 ` jakub at gcc dot gnu.org
2024-01-13 6:52 ` pinskia at gcc dot gnu.org
2024-01-13 6:53 ` pinskia at gcc dot gnu.org
2024-01-19 14:01 ` costamagnagianfranco at yahoo dot it
2024-01-19 14:01 ` costamagnagianfranco at yahoo dot it
2024-01-25 15:54 ` acoplan at gcc dot gnu.org
2024-01-25 20:01 ` [Bug target/111677] [12/13 " pinskia at gcc dot gnu.org
2024-01-29 17:00 ` rsandifo at gcc dot gnu.org [this message]
2024-01-30 9:30 ` acoplan at gcc dot gnu.org
2024-01-30 12:05 ` [Bug target/111677] [12/13/14 " acoplan at gcc dot gnu.org
2024-01-30 15:34 ` acoplan at gcc dot gnu.org
2024-01-30 17:49 ` acoplan at gcc dot gnu.org
2024-01-31 14:01 ` cvs-commit at gcc dot gnu.org
2024-01-31 14:03 ` [Bug target/111677] [12/13 " acoplan at gcc dot gnu.org
2024-02-07 10:41 ` cvs-commit at gcc dot gnu.org
2024-02-07 10:44 ` [Bug target/111677] [12 " acoplan at gcc dot gnu.org
2024-02-12 17:14 ` acoplan at gcc dot gnu.org
2024-02-14 11:55 ` cvs-commit at gcc dot gnu.org
2024-02-14 11:57 ` [Bug target/111677] " acoplan at gcc dot gnu.org
2024-02-20 10:14 ` cvs-commit at gcc dot gnu.org
2024-02-20 10:15 ` acoplan at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-111677-4-Zd8j02JTlm@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).