public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/111677] darktable build on aarch64 fails with unrecognizable insn due to -fstack-protector changes
Date: Tue, 20 Feb 2024 10:14:43 +0000	[thread overview]
Message-ID: <bug-111677-4-bDeUz2SrM8@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-111677-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111677

--- Comment #33 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Alex Coplan
<acoplan@gcc.gnu.org>:

https://gcc.gnu.org/g:0b308e2f27b087049fde9fbc64e432de47868a90

commit r11-11247-g0b308e2f27b087049fde9fbc64e432de47868a90
Author: Alex Coplan <alex.coplan@arm.com>
Date:   Tue Jan 30 09:39:59 2024 +0000

    aarch64: Avoid out-of-range shrink-wrapped saves [PR111677]

    The PR shows us ICEing due to an unrecognizable TFmode save emitted by
    aarch64_process_components.  The problem is that for T{I,F,D}mode we
    conservatively require mems to be in range for x-register ldp/stp.  That
    is because (at least for TImode) it can be allocated to both GPRs and
    FPRs, and in the GPR case that is an x-reg ldp/stp, and the FPR case is
    a q-register load/store.

    As Richard pointed out in the PR, aarch64_get_separate_components
    already checks that the offsets are suitable for a single load, so we
    just need to choose a mode in aarch64_reg_save_mode that gives the full
    q-register range.  In this patch, we choose V16QImode as an alternative
    16-byte "bag-of-bits" mode that doesn't have the artificial range
    restrictions imposed on T{I,F,D}mode.

    Unlike for GCC 14 we need additional handling in the load/store pair
    code as various cases are not expecting to see V16QImode (particularly
    the writeback patterns, but also aarch64_gen_load_pair).

    gcc/ChangeLog:

            PR target/111677
            * config/aarch64/aarch64.c (aarch64_reg_save_mode): Use
            V16QImode for the full 16-byte FPR saves in the vector PCS case.
            (aarch64_gen_storewb_pair): Handle V16QImode.
            (aarch64_gen_loadwb_pair): Likewise.
            (aarch64_gen_load_pair): Likewise.
            * config/aarch64/aarch64.md (loadwb_pair<TX:mode>_<P:mode>):
            Rename to ...
            (loadwb_pair<TX_V16QI:mode>_<P:mode>): ... this, extending to
            V16QImode.
            (storewb_pair<TX:mode>_<P:mode>): Rename to ...
            (storewb_pair<TX_V16QI:mode>_<P:mode>): ... this, extending to
            V16QImode.
            * config/aarch64/iterators.md (TX_V16QI): New.

    gcc/testsuite/ChangeLog:

            PR target/111677
            * gcc.target/aarch64/torture/pr111677.c: New test.

    (cherry picked from commit fddce05d67f34174be0f306e1015d3868bbe7c31)

  parent reply	other threads:[~2024-02-20 10:14 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-03 14:41 [Bug c/111677] New: arm64 build fails unrecognizable insn [REGRESSION] costamagnagianfranco at yahoo dot it
2023-10-03 22:22 ` [Bug target/111677] " pinskia at gcc dot gnu.org
2023-10-06  7:53 ` costamagnagianfranco at yahoo dot it
2023-10-09 10:37 ` costamagnagianfranco at yahoo dot it
2023-10-24  4:30 ` pinskia at gcc dot gnu.org
2023-10-24  4:33 ` [Bug target/111677] [12/13/14 Regression] darktable build on aarch64 fails with unrecognizable insn due to -fstack-protector changes pinskia at gcc dot gnu.org
2023-10-24  4:33 ` pinskia at gcc dot gnu.org
2023-10-24 11:19 ` costamagnagianfranco at yahoo dot it
2023-10-24 11:54 ` costamagnagianfranco at yahoo dot it
2023-10-24 12:48 ` costamagnagianfranco at yahoo dot it
2023-10-24 12:50 ` costamagnagianfranco at yahoo dot it
2023-10-24 12:55 ` costamagnagianfranco at yahoo dot it
2023-10-24 14:42 ` acoplan at gcc dot gnu.org
2023-10-24 21:58 ` pinskia at gcc dot gnu.org
2023-10-25 11:19 ` acoplan at gcc dot gnu.org
2023-11-22 11:42 ` costamagnagianfranco at yahoo dot it
2024-01-12 15:58 ` germano.massullo at gmail dot com
2024-01-12 16:34 ` jakub at gcc dot gnu.org
2024-01-13  6:52 ` pinskia at gcc dot gnu.org
2024-01-13  6:53 ` pinskia at gcc dot gnu.org
2024-01-19 14:01 ` costamagnagianfranco at yahoo dot it
2024-01-19 14:01 ` costamagnagianfranco at yahoo dot it
2024-01-25 15:54 ` acoplan at gcc dot gnu.org
2024-01-25 20:01 ` [Bug target/111677] [12/13 " pinskia at gcc dot gnu.org
2024-01-29 17:00 ` rsandifo at gcc dot gnu.org
2024-01-30  9:30 ` acoplan at gcc dot gnu.org
2024-01-30 12:05 ` [Bug target/111677] [12/13/14 " acoplan at gcc dot gnu.org
2024-01-30 15:34 ` acoplan at gcc dot gnu.org
2024-01-30 17:49 ` acoplan at gcc dot gnu.org
2024-01-31 14:01 ` cvs-commit at gcc dot gnu.org
2024-01-31 14:03 ` [Bug target/111677] [12/13 " acoplan at gcc dot gnu.org
2024-02-07 10:41 ` cvs-commit at gcc dot gnu.org
2024-02-07 10:44 ` [Bug target/111677] [12 " acoplan at gcc dot gnu.org
2024-02-12 17:14 ` acoplan at gcc dot gnu.org
2024-02-14 11:55 ` cvs-commit at gcc dot gnu.org
2024-02-14 11:57 ` [Bug target/111677] " acoplan at gcc dot gnu.org
2024-02-20 10:14 ` cvs-commit at gcc dot gnu.org [this message]
2024-02-20 10:15 ` acoplan at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-111677-4-bDeUz2SrM8@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).