[Bug c++/111682] New: valgrind error in tsubst_template_decl

[Bug c++/111682] New: valgrind error in tsubst_template_decl

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111682

            Bug ID: 111682
           Summary: valgrind error in tsubst_template_decl
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

Recent gcc trunk, built with valgrind, when given this C++ source code
from the clang testsuite:

template<typename T> struct A {
  template<typename U> struct B;
  template<typename U> struct B<U*>;
};
template<typename T> template<typename U> struct A<T>::B<U*> {};
template struct A<int>;
A<int>::B<int*> b;


template<typename T> struct B {
  template<typename U> static const int var1;
  template<typename U> static const int var1<U*>;

  template<typename U> static const int var2;
};
template<typename T> template<typename U> const int B<T>::var1<U*> = 1;
template<typename T> template<typename U> const int B<T>::var2<U*> = 1;
template struct B<int>;
int b_test1[B<int>::var1<int*>];
int b_test2[B<int>::var2<int*>];


does this:

$ ~/gcc/results.20230927.valgrind/bin/gcc -c -w
./SemaTemplate/instantiate-partial-spec.cpp
==33844== Invalid read of size 2
==33844==    at 0x8CCA6B: tsubst_template_decl(tree_node*, tree_node*, int,
tree_node*, tree_node*) (pt.cc:14684)
==33844==    by 0x8B4469: tsubst_decl(tree_node*, tree_node*, int, bool)
(pt.cc:14933)
==33844==    by 0x8CE78B: most_specialized_partial_spec(tree_node*, int, bool)
(pt.cc:26255)

[Bug c++/111682] valgrind error in tsubst_template_decl

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111682

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-10-04
           Assignee|unassigned at gcc dot gnu.org      |ppalka at gcc dot gnu.org
   Target Milestone|---                         |14.0
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
           Keywords|                            |ice-on-valid-code
                 CC|                            |ppalka at gcc dot gnu.org

--- Comment #1 from Patrick Palka <ppalka at gcc dot gnu.org> ---
Likely started with r14-3160-gca2676654736e6, before which we rejected the
testcase.

With --enable-checking GCC trunk ICEs on the testcase for me:

<stdin>:16:56: internal compiler error: tree check: expected var_decl or
function_decl or field_decl or type_decl or concept_decl or template_decl, have
ggc_freed in tsubst_template_decl, at cp/pt.cc:14686

[Bug c++/111682] [14 regression] valgrind error in tsubst_template_decl

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111682

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
            Version|unknown                     |14.0

[Bug c++/111682] [14 regression] valgrind error in tsubst_template_decl

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111682

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:c95dc611a6203f0564722975acff4ad866b9c45e

commit r14-9035-gc95dc611a6203f0564722975acff4ad866b9c45e
Author: Patrick Palka <ppalka@redhat.com>
Date:   Fri Feb 16 12:44:27 2024 -0500

    c++: add fixed testcase [PR111682]

    Fixed by the PR113612 fix r14-8960-g19ac327de421fe.

            PR c++/111682

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp1y/var-templ86.C: New test.

[Bug c++/111682] [14 regression] valgrind error in tsubst_template_decl

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111682

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=113612
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Patrick Palka <ppalka at gcc dot gnu.org> ---
Incidentally fixed.