public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/111683] [11/12/13/14 Regression] Incorrect answer when using SSE2 intrinsics with -O3 since r7-3163-g973625a04b3d9351f2485e37f7d3382af2aed87e
Date: Fri, 22 Mar 2024 08:18:10 +0000	[thread overview]
Message-ID: <bug-111683-4-V8xS7Oxbyd@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-111683-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111683

--- Comment #20 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
That is true.  I've been also wondering whether e.g. for the pr71083.c case we
couldn't just look through all COMPONENT_REFs of the DR_REF (and maybe
ARRAY_REFs with constant indexes) and check type size of the aggregate it is in
against the size.  That could perhaps fix the predcom of pr71083.c, because it
is a 24-bit bitfield in 4 byte structure.

Will you take this over, or should I tweak my patch?

Note, statistics I've gathered with the above posted patch was that the patch
did something in
/home/jakub/src/gcc/gcc/testsuite/c-c++-common/torture/pr101636.c bar
/home/jakub/src/gcc/gcc/testsuite/gcc.c-torture/compile/pr32399.c f
/home/jakub/src/gcc/gcc/testsuite/gcc.dg/autopar/pr69109-2.c f
/home/jakub/src/gcc/gcc/testsuite/gcc.dg/graphite/pr71575-2.c fn1
/home/jakub/src/gcc/gcc/testsuite/gcc.dg/loop-versioning-6.c f1
/home/jakub/src/gcc/gcc/testsuite/gcc.dg/pr111683-1.c main
/home/jakub/src/gcc/gcc/testsuite/gcc.dg/pr111683-2.c main
but only changed the generated code in the last 2 (those are intentional).
The older patch with wi::multiple_of_p affected
/home/jakub/src/gcc/gcc/testsuite/c-c++-common/torture/pr101636.c bar
/home/jakub/src/gcc/gcc/testsuite/gcc.c-torture/compile/pr32399.c f
/home/jakub/src/gcc/gcc/testsuite/gcc.c-torture/execute/pr71083.c bar
/home/jakub/src/gcc/gcc/testsuite/gcc.dg/autopar/pr69109-2.c f
/home/jakub/src/gcc/gcc/testsuite/gcc.dg/graphite/pr71575-2.c fn1
/home/jakub/src/gcc/gcc/testsuite/gcc.dg/loop-versioning-6.c f1
/home/jakub/src/gcc/gcc/testsuite/gcc.dg/pr111683-1.c main
/home/jakub/src/gcc/gcc/testsuite/gcc.dg/pr111683-2.c main
/home/jakub/src/gcc/gcc/testsuite/gcc.dg/torture/pr112736.c fn1
/home/jakub/src/gcc/gcc/testsuite/gcc.dg/torture/pr68379.c fn1
/home/jakub/src/gcc/gcc/testsuite/gcc.dg/tree-ssa/pr87022.c main
/home/jakub/src/gcc/gcc/testsuite/gcc.dg/vect/pr101445.c foo
/home/jakub/src/gcc/gcc/testsuite/gcc.dg/vect/pr68502-2.c reset_nodes
/home/jakub/src/gcc/gcc/testsuite/gcc.dg/vect/pr81740-2.c main
/home/jakub/src/gcc/gcc/testsuite/gcc.dg/vect/vect-avg-16.c f
/home/jakub/src/gcc/gcc/testsuite/g++.dg/vect/pr95297.cc test
and changed code generation of the 2 expected tests and pr71083.c.  All this
statistics was solely from make check-gcc check-g++.

  parent reply	other threads:[~2024-03-22  8:18 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-03 18:27 [Bug c++/111683] New: Incorrect answer when using SSE2 intrinsics with -O3 deodharvinit99 at gmail dot com
2023-10-03 22:18 ` [Bug middle-end/111683] [11/12/13/14 Regression] " pinskia at gcc dot gnu.org
2023-10-04  9:55 ` rguenth at gcc dot gnu.org
2023-10-04 16:56 ` amonakov at gcc dot gnu.org
2023-12-12 10:27 ` jakub at gcc dot gnu.org
2024-03-07 21:06 ` law at gcc dot gnu.org
2024-03-10  5:55 ` [Bug middle-end/111683] [11/12/13/14 Regression] Incorrect answer when using SSE2 intrinsics with -O3 since r7-3163-g973625a04b3d9351f2485e37f7d3382af2aed87e kugan at gcc dot gnu.org
2024-03-10 11:15 ` sjames at gcc dot gnu.org
2024-03-12  1:58 ` pinskia at gcc dot gnu.org
2024-03-12  2:24 ` pinskia at gcc dot gnu.org
2024-03-12  2:31 ` pinskia at gcc dot gnu.org
2024-03-12  2:44 ` pinskia at gcc dot gnu.org
2024-03-12 13:23 ` jakub at gcc dot gnu.org
2024-03-19 17:28 ` jakub at gcc dot gnu.org
2024-03-19 18:17 ` pinskia at gcc dot gnu.org
2024-03-21 16:47 ` jakub at gcc dot gnu.org
2024-03-22  7:33 ` rguenth at gcc dot gnu.org
2024-03-22  7:38 ` rguenth at gcc dot gnu.org
2024-03-22  7:47 ` jakub at gcc dot gnu.org
2024-03-22  7:50 ` jakub at gcc dot gnu.org
2024-03-22  8:06 ` rguenth at gcc dot gnu.org
2024-03-22  8:18 ` jakub at gcc dot gnu.org [this message]
2024-03-22 10:37 ` jakub at gcc dot gnu.org
2024-03-22 10:46 ` jakub at gcc dot gnu.org
2024-03-22 11:35 ` rguenth at gcc dot gnu.org
2024-03-22 11:43 ` jakub at gcc dot gnu.org
2024-03-22 12:42 ` rguenther at suse dot de
2024-03-23 10:18 ` cvs-commit at gcc dot gnu.org
2024-03-23 10:21 ` [Bug middle-end/111683] [11/12/13 " jakub at gcc dot gnu.org
2024-03-30  3:55 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-111683-4-V8xS7Oxbyd@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).