public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/111683] [11/12/13 Regression] Incorrect answer when using SSE2 intrinsics with -O3 since r7-3163-g973625a04b3d9351f2485e37f7d3382af2aed87e Date: Sat, 30 Mar 2024 03:55:29 +0000 [thread overview] Message-ID: <bug-111683-4-zZS4cuJfqx@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-111683-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111683 --- Comment #28 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-13 branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:4320e8483bb88b49bf251451307324c06d33c0a4 commit r13-8521-g4320e8483bb88b49bf251451307324c06d33c0a4 Author: Jakub Jelinek <jakub@redhat.com> Date: Sat Mar 23 11:17:44 2024 +0100 predcom: Punt for steps which aren't multiples of access size [PR111683] On the following testcases, there is no overlap between data references within a single iteration, but the data references have size which is twice as large as the step, which means the data references overlap with the next iteration which predcom doesn't take into account. As discussed in the PR, even if the reference size is smaller than step, if step isn't a multiple of the reference size, there could be overlaps with some other iteration later on. The initial version of the patch regressed (test still passed, but predcom didn't optimize anymore) pr71083.c which has a packed char, short structure and was reading/writing the short 2 bytes in there with step 3. The following patch deals with that by retrying for COMPONENT_REFs also the aggregate sizes etc., so that it then compares 3 bytes against step 3. In make check-gcc/check-g++ this patch I believe affects code generation for only the 2 new testcases according to statistics I've gathered. 2024-03-23 Jakub Jelinek <jakub@redhat.com> PR middle-end/111683 * tree-predcom.cc (pcom_worker::suitable_component_p): If has_write and comp_step is RS_NONZERO, return false if any reference in the component doesn't have DR_STEP a multiple of access size. * gcc.dg/pr111683-1.c: New test. * gcc.dg/pr111683-2.c: New test. (cherry picked from commit 8fc5593df8e0d36cc5bd8ea21097a491a634a866)
prev parent reply other threads:[~2024-03-30 3:55 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-03 18:27 [Bug c++/111683] New: Incorrect answer when using SSE2 intrinsics with -O3 deodharvinit99 at gmail dot com 2023-10-03 22:18 ` [Bug middle-end/111683] [11/12/13/14 Regression] " pinskia at gcc dot gnu.org 2023-10-04 9:55 ` rguenth at gcc dot gnu.org 2023-10-04 16:56 ` amonakov at gcc dot gnu.org 2023-12-12 10:27 ` jakub at gcc dot gnu.org 2024-03-07 21:06 ` law at gcc dot gnu.org 2024-03-10 5:55 ` [Bug middle-end/111683] [11/12/13/14 Regression] Incorrect answer when using SSE2 intrinsics with -O3 since r7-3163-g973625a04b3d9351f2485e37f7d3382af2aed87e kugan at gcc dot gnu.org 2024-03-10 11:15 ` sjames at gcc dot gnu.org 2024-03-12 1:58 ` pinskia at gcc dot gnu.org 2024-03-12 2:24 ` pinskia at gcc dot gnu.org 2024-03-12 2:31 ` pinskia at gcc dot gnu.org 2024-03-12 2:44 ` pinskia at gcc dot gnu.org 2024-03-12 13:23 ` jakub at gcc dot gnu.org 2024-03-19 17:28 ` jakub at gcc dot gnu.org 2024-03-19 18:17 ` pinskia at gcc dot gnu.org 2024-03-21 16:47 ` jakub at gcc dot gnu.org 2024-03-22 7:33 ` rguenth at gcc dot gnu.org 2024-03-22 7:38 ` rguenth at gcc dot gnu.org 2024-03-22 7:47 ` jakub at gcc dot gnu.org 2024-03-22 7:50 ` jakub at gcc dot gnu.org 2024-03-22 8:06 ` rguenth at gcc dot gnu.org 2024-03-22 8:18 ` jakub at gcc dot gnu.org 2024-03-22 10:37 ` jakub at gcc dot gnu.org 2024-03-22 10:46 ` jakub at gcc dot gnu.org 2024-03-22 11:35 ` rguenth at gcc dot gnu.org 2024-03-22 11:43 ` jakub at gcc dot gnu.org 2024-03-22 12:42 ` rguenther at suse dot de 2024-03-23 10:18 ` cvs-commit at gcc dot gnu.org 2024-03-23 10:21 ` [Bug middle-end/111683] [11/12/13 " jakub at gcc dot gnu.org 2024-03-30 3:55 ` cvs-commit at gcc dot gnu.org [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-111683-4-zZS4cuJfqx@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).