[Bug c++/111785] New: [modules] ICE when compiling fmt lib as module

[Bug c++/111785] New: [modules] ICE when compiling fmt lib as module

[mends-sputter.0z at icloud dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111785

            Bug ID: 111785
           Summary: [modules] ICE when compiling fmt lib as module
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: mends-sputter.0z at icloud dot com
  Target Milestone: ---

Created attachment 56095
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56095&action=edit
preprocessed output generated by -freport-bug

GCC 14.0 from recent snapshot (20231008) on aarch64

Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/opt/gcc14/libexec/gcc/aarch64-unknown-linux-gnu/14.0.0/lto-wrapper
Target: aarch64-unknown-linux-gnu
Configured with: ../configure --prefix=/opt/gcc14 --enable-languages=c,c++
--disable-multilib
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 14.0.0 20231008 (experimental) (GCC)

When attempting to build fmt from https://github.com/fmtlib/fmt, with the
following command:
g++ -std=c++20 -fmodules-ts -I../include fmt.cc

The compiler ICEs with the following error:

fmt.cc:73:8: internal compiler error: in core_vals, at cp/module.cc:6262
   73 | export module fmt;
      |        ^
0x9a9b67 trees_out::core_vals(tree_node*)
        ../../gcc/cp/module.cc:6262
0x9add5f trees_out::tree_node_vals(tree_node*)
        ../../gcc/cp/module.cc:7218
0x9add5f trees_out::tree_value(tree_node*)
        ../../gcc/cp/module.cc:9083
0x9a7c73 trees_out::tree_node(tree_node*)
        ../../gcc/cp/module.cc:9281
0x9a9537 trees_out::core_vals(tree_node*)
        ../../gcc/cp/module.cc:6171
0x9a5fb3 trees_out::tree_node_vals(tree_node*)
        ../../gcc/cp/module.cc:7218
0x9a5fb3 trees_out::decl_value(tree_node*, depset*)
        ../../gcc/cp/module.cc:7797
0x9b0823 depset::hash::find_dependencies(module_state*)
        ../../gcc/cp/module.cc:13328
0x9b16c7 module_state::write_begin(elf_out*, cpp_reader*, module_state_config&,
unsigned int&)
        ../../gcc/cp/module.cc:17895
0x9b2a0f finish_module_processing(cpp_reader*)
        ../../gcc/cp/module.cc:20241
0x91df57 c_parse_final_cleanups()
        ../../gcc/cp/decl2.cc:5255
0xbe773f c_common_parse_file()
        ../../gcc/c-family/c-opts.cc:1296

attaching the file generated by -freport-bug - compressed with the gzip tool.

Note that this is similar and involves the same file as reported in this other
in a comment in a separate report:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108080#c7

however with gcc 14.0 snapshots, this fails with every level of optimization
flags, although in each case the crash dump is slightly different and fails on
a separate line.

[Bug c++/111785] [modules] ICE when compiling fmt lib as module

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111785

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=108080
                 CC|                            |ppalka at gcc dot gnu.org

--- Comment #1 from Patrick Palka <ppalka at gcc dot gnu.org> ---
The modules streaming code doesn't yet support "GCC optimize" pragmas.  It
should work if you compile the

[Bug c++/111785] [modules] ICE when compiling fmt lib as module

[mends-sputter.0z at icloud dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111785

--- Comment #2 from Luis Caro Campos <mends-sputter.0z at icloud dot com> ---
Thanks Patrick for looking into this. I think your message got cut off?

I've removed the calls to the GCC optimize pragmas, and still get an ICE:

src/fmt.cc:71:8: internal compiler error: in insert, at cp/module.cc:4920
   71 | export module fmt;
      |        ^
0x9a371f trees_out::insert(tree_node*, walk_kind)
        ../../gcc/cp/module.cc:4920
0x9a6e37 trees_out::decl_node(tree_nod


This time the error references a different line of the same module.cc file, in
case that is relevant.

[Bug c++/111785] [modules] ICE when compiling fmt lib as module

[mends-sputter.0z at icloud dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111785

--- Comment #3 from Luis Caro Campos <mends-sputter.0z at icloud dot com> ---
now that I've removed the GCC optimize pragmas - the file does compile with
both gcc 12 and 13 (Ubuntu-provided), but not with the gcc 14 snapshots. Makes
me wonder if there has been a regression somewhere. The snapshots for the
upcoming gcc14 are useful when it comes to modules, as the implementation for
p1689r5 (module dependency scanning) has recently been merged

[Bug c++/111785] [modules] ICE when compiling fmt lib as module

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111785

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=105322

--- Comment #4 from Patrick Palka <ppalka at gcc dot gnu.org> ---
Oops, I was only going to suggest removing the optimization pragmas either
manually or by compiling with -O etc.

I suspect the subsequent trees_out::insert ICE is a manifestation of PR105322..
it's not seen in release builds because it's caused by a failing assert that
get compiled away in release builds.

[Bug c++/111785] [modules] ICE when compiling fmt lib as module

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111785

--- Comment #5 from Patrick Palka <ppalka at gcc dot gnu.org> ---
(In reply to Luis Caro Campos from comment #2)
> Thanks Patrick for looking into this. I think your message got cut off?
> 
> I've removed the calls to the GCC optimize pragmas, and still get an ICE:
> 
> src/fmt.cc:71:8: internal compiler error: in insert, at cp/module.cc:4920
>    71 | export module fmt;
>       |        ^
> 0x9a371f trees_out::insert(tree_node*, walk_kind)
>         ../../gcc/cp/module.cc:4920
> 0x9a6e37 trees_out::decl_node(tree_nod
> 
> 
> This time the error references a different line of the same module.cc file,
> in case that is relevant.

Hopefully this ICE is gone after the PR105322 fix r14-4806?

[Bug c++/111785] [modules] ICE when compiling fmt lib as module

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111785

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
           See Also|https://gcc.gnu.org/bugzill |
                   |a/show_bug.cgi?id=108080    |
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #6 from Patrick Palka <ppalka at gcc dot gnu.org> ---
dup

*** This bug has been marked as a duplicate of bug 108080 ***