public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/111866] New: [14 regression] ICE when compiling
@ 2023-10-18 15:49 seurer at gcc dot gnu.org
2023-10-18 16:06 ` [Bug middle-end/111866] [14 regression] ICE when compiling gcc.target/powerpc/p9-vec-length-full-7.c tnfchris at gcc dot gnu.org
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: seurer at gcc dot gnu.org @ 2023-10-18 15:49 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111866
Bug ID: 111866
Summary: [14 regression] ICE when compiling
Product: gcc
Version: 14.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: middle-end
Assignee: unassigned at gcc dot gnu.org
Reporter: seurer at gcc dot gnu.org
Target Milestone: ---
g:d65e38e616e7ac8157ef04b55beb6670f2c0f142, r14-4708-gd65e38e616e7ac
FAIL: gcc.target/powerpc/p9-vec-length-full-7.c (internal compiler error: in
vect_set_loop_condition_partial_vectors, at tree-vect-loop-manip.cc:911)
FAIL: gcc.target/powerpc/p9-vec-length-full-7.c (test for excess errors)
FAIL: gcc.target/powerpc/p9-vec-length-full-run-7.c (internal compiler error:
in vect_set_loop_condition_partial_vectors, at tree-vect-loop-manip.cc:911)
FAIL: gcc.target/powerpc/p9-vec-length-full-run-7.c (test for excess errors)
spawn -ignore SIGHUP /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.target/powerpc/p9-vec-length-full-7.c
-fdiagnostics-plain-output -mdejagnu-cpu=power9 -O2 -ftree-vectorize
-fno-vect-cost-model -fno-unroll-loops -ffast-math -fdisable-tree-cunroll
--param=vect-partial-vector-usage=2 -ffat-lto-objects -fno-ident -S -o
p9-vec-length-full-7.s
cc1: note: disable pass tree-cunroll for functions in the range of [0,
4294967295]
during GIMPLE pass: vect
In file included from
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.target/powerpc/p9-vec-length-full-7.c:11:
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.target/powerpc/p9-vec-length-7.h:
In function 'test_npeel_int8_t':
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.target/powerpc/p9-vec-length-7.h:12:43:
internal compiler error: in vect_set_loop_condition_partial_vectors, at
tree-vect-loop-manip.cc:911
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.target/powerpc/p9-vec-length.h:4:3:
note: in expansion of macro 'test'
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.target/powerpc/p9-vec-length-7.h:20:1:
note: in expansion of macro 'TEST_ALL'
0x110c9c9b vect_set_loop_condition_partial_vectors
/home/seurer/gcc/git/gcc-test/gcc/tree-vect-loop-manip.cc:911
0x110c9c9b vect_set_loop_condition(loop*, edge_def*, _loop_vec_info*,
tree_node*, tree_node*, tree_node*, bool)
/home/seurer/gcc/git/gcc-test/gcc/tree-vect-loop-manip.cc:1366
0x110cc37b vect_do_peeling(_loop_vec_info*, tree_node*, tree_node*,
tree_node**, tree_node**, tree_node**, int, bool, bool, tree_node**)
/home/seurer/gcc/git/gcc-test/gcc/tree-vect-loop-manip.cc:3250
0x110ba213 vect_transform_loop(_loop_vec_info*, gimple*)
/home/seurer/gcc/git/gcc-test/gcc/tree-vect-loop.cc:11416
0x1110fa43 vect_transform_loops
/home/seurer/gcc/git/gcc-test/gcc/tree-vectorizer.cc:1006
0x1111042f try_vectorize_loop_1
/home/seurer/gcc/git/gcc-test/gcc/tree-vectorizer.cc:1152
0x1111042f try_vectorize_loop
/home/seurer/gcc/git/gcc-test/gcc/tree-vectorizer.cc:1182
0x111108d3 execute
/home/seurer/gcc/git/gcc-test/gcc/tree-vectorizer.cc:1298
commit d65e38e616e7ac8157ef04b55beb6670f2c0f142 (HEAD)
Author: Tamar Christina <tamar.christina@arm.com>
Date: Wed Oct 18 09:02:12 2023 +0100
middle-end: Refactor vectorizer loop conditionals and separate out IV to
new variables
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug middle-end/111866] [14 regression] ICE when compiling gcc.target/powerpc/p9-vec-length-full-7.c
2023-10-18 15:49 [Bug middle-end/111866] New: [14 regression] ICE when compiling seurer at gcc dot gnu.org
@ 2023-10-18 16:06 ` tnfchris at gcc dot gnu.org
2023-10-18 16:07 ` [Bug tree-optimization/111866] " tnfchris at gcc dot gnu.org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2023-10-18 16:06 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111866
--- Comment #1 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Thanks for reporting! I'll debug.
I suspect another case where the vectorized and scalar loop were sneakily
swapped.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/111866] [14 regression] ICE when compiling gcc.target/powerpc/p9-vec-length-full-7.c
2023-10-18 15:49 [Bug middle-end/111866] New: [14 regression] ICE when compiling seurer at gcc dot gnu.org
2023-10-18 16:06 ` [Bug middle-end/111866] [14 regression] ICE when compiling gcc.target/powerpc/p9-vec-length-full-7.c tnfchris at gcc dot gnu.org
@ 2023-10-18 16:07 ` tnfchris at gcc dot gnu.org
2023-10-18 18:57 ` pinskia at gcc dot gnu.org
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2023-10-18 16:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111866
Tamar Christina <tnfchris at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |tnfchris at gcc dot gnu.org
Priority|P3 |P1
Target Milestone|--- |14.0
Component|middle-end |tree-optimization
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/111866] [14 regression] ICE when compiling gcc.target/powerpc/p9-vec-length-full-7.c
2023-10-18 15:49 [Bug middle-end/111866] New: [14 regression] ICE when compiling seurer at gcc dot gnu.org
2023-10-18 16:06 ` [Bug middle-end/111866] [14 regression] ICE when compiling gcc.target/powerpc/p9-vec-length-full-7.c tnfchris at gcc dot gnu.org
2023-10-18 16:07 ` [Bug tree-optimization/111866] " tnfchris at gcc dot gnu.org
@ 2023-10-18 18:57 ` pinskia at gcc dot gnu.org
2023-10-19 11:07 ` tnfchris at gcc dot gnu.org
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-10-18 18:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111866
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2023-10-18
Keywords| |ice-on-valid-code
Ever confirmed|0 |1
Status|UNCONFIRMED |ASSIGNED
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/111866] [14 regression] ICE when compiling gcc.target/powerpc/p9-vec-length-full-7.c
2023-10-18 15:49 [Bug middle-end/111866] New: [14 regression] ICE when compiling seurer at gcc dot gnu.org
` (2 preceding siblings ...)
2023-10-18 18:57 ` pinskia at gcc dot gnu.org
@ 2023-10-19 11:07 ` tnfchris at gcc dot gnu.org
2023-10-20 10:58 ` tnfchris at gcc dot gnu.org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2023-10-19 11:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111866
--- Comment #3 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
ok, so the crash looks like it's due to rgroups_control being empty during
prologue peeling.
It looks like the loop isn't masked so LOOP_VINFO_LENS (loop_vinfo) is being
used in this case, but (!rgc->controls.is_empty ()) fails.
As far as I can tell these are only filled in by vect_get_loop_len.
It looks like after the refactoring vect_get_loop_len is not being called. It
was expected to be called from vectorizable_store.
Debugging why it doesn't get there.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/111866] [14 regression] ICE when compiling gcc.target/powerpc/p9-vec-length-full-7.c
2023-10-18 15:49 [Bug middle-end/111866] New: [14 regression] ICE when compiling seurer at gcc dot gnu.org
` (3 preceding siblings ...)
2023-10-19 11:07 ` tnfchris at gcc dot gnu.org
@ 2023-10-20 10:58 ` tnfchris at gcc dot gnu.org
2023-10-20 14:00 ` cvs-commit at gcc dot gnu.org
2023-10-20 14:02 ` tnfchris at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2023-10-20 10:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111866
--- Comment #4 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
patch submitted
https://gcc.gnu.org/pipermail/gcc-patches/2023-October/633713.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/111866] [14 regression] ICE when compiling gcc.target/powerpc/p9-vec-length-full-7.c
2023-10-18 15:49 [Bug middle-end/111866] New: [14 regression] ICE when compiling seurer at gcc dot gnu.org
` (4 preceding siblings ...)
2023-10-20 10:58 ` tnfchris at gcc dot gnu.org
@ 2023-10-20 14:00 ` cvs-commit at gcc dot gnu.org
2023-10-20 14:02 ` tnfchris at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-10-20 14:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111866
--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>:
https://gcc.gnu.org/g:eb15fad3190a8b33e3e451b964ff1ecf08bbb113
commit r14-4792-geb15fad3190a8b33e3e451b964ff1ecf08bbb113
Author: Tamar Christina <tamar.christina@arm.com>
Date: Fri Oct 20 14:58:39 2023 +0100
middle-end: don't pass loop_vinfo to vect_set_loop_condition during prolog
peeling
During the refactoring I had passed loop_vinfo on to
vect_set_loop_condition
during prolog peeling. This parameter is unused in most cases except for
in
vect_set_loop_condition_partial_vectors where it's behaviour depends on
whether
loop_vinfo is NULL or not. Apparently this code expect it to be NULL and
it
reads the structures from a different location.
This fixes the failing testcase which was not using the lens values
determined
earlier in vectorizable_store because it was looking it up in the given
loop_vinfo instead.
gcc/ChangeLog:
PR tree-optimization/111866
* tree-vect-loop-manip.cc (vect_do_peeling): Pass null as vinfo to
vect_set_loop_condition during prolog peeling.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/111866] [14 regression] ICE when compiling gcc.target/powerpc/p9-vec-length-full-7.c
2023-10-18 15:49 [Bug middle-end/111866] New: [14 regression] ICE when compiling seurer at gcc dot gnu.org
` (5 preceding siblings ...)
2023-10-20 14:00 ` cvs-commit at gcc dot gnu.org
@ 2023-10-20 14:02 ` tnfchris at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2023-10-20 14:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111866
Tamar Christina <tnfchris at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #6 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Fixed, sorry for the breakage!
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-10-20 14:02 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-18 15:49 [Bug middle-end/111866] New: [14 regression] ICE when compiling seurer at gcc dot gnu.org
2023-10-18 16:06 ` [Bug middle-end/111866] [14 regression] ICE when compiling gcc.target/powerpc/p9-vec-length-full-7.c tnfchris at gcc dot gnu.org
2023-10-18 16:07 ` [Bug tree-optimization/111866] " tnfchris at gcc dot gnu.org
2023-10-18 18:57 ` pinskia at gcc dot gnu.org
2023-10-19 11:07 ` tnfchris at gcc dot gnu.org
2023-10-20 10:58 ` tnfchris at gcc dot gnu.org
2023-10-20 14:00 ` cvs-commit at gcc dot gnu.org
2023-10-20 14:02 ` tnfchris at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).