[Bug analyzer/111881] New: analyzer: ICE in ensure_closed, at analyzer/constraint-manager.cc:130 with -Ofast

[Bug analyzer/111881] New: analyzer: ICE in ensure_closed, at analyzer/constraint-manager.cc:130 with -Ofast

[acoplan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111881

            Bug ID: 111881
           Summary: analyzer: ICE in ensure_closed, at
                    analyzer/constraint-manager.cc:130 with -Ofast
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: analyzer
          Assignee: dmalcolm at gcc dot gnu.org
          Reporter: acoplan at gcc dot gnu.org
  Target Milestone: ---

The following fails (here on aarch64, but also on x86_64):

$ cat t.c
int int0(float sf1) { return sf1 <= 0 || sf1 >= 7 ? 0 : sf1; }

$ ./xgcc -B . -c t.c -fanalyzer -Ofast
during IPA pass: analyzer
t.c: In function ‘int0’:
t.c:1:55: internal compiler error: in ensure_closed, at
analyzer/constraint-manager.cc:130
    1 | int int0(float sf1) { return sf1 <= 0 || sf1 >= 7 ? 0 : sf1; }
      |                              ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
0x26060c5 ana::bound::ensure_closed(ana::bound_kind)
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/constraint-manager.cc:130
0x25fdb21 ana::bound::ensure_closed(ana::bound_kind)
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/constraint-manager.cc:121
0x25fdb21 ana::range::add_bound(ana::bound, ana::bound_kind)
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/constraint-manager.cc:309
0x25ff278 ana::constraint_manager::eval_condition(ana::equiv_class_id,
tree_code, tree_node*) const
       
/home/alecop01/toolchain/src/gcc/gcc/analyzer/constraint-manager.cc:2605
0x25ff574 ana::constraint_manager::eval_condition(ana::svalue const*,
tree_code, ana::svalue const*) const
       
/home/alecop01/toolchain/src/gcc/gcc/analyzer/constraint-manager.cc:2744
0x25ff6c8 ana::constraint_manager::add_constraint(ana::svalue const*,
tree_code, ana::svalue const*)
       
/home/alecop01/toolchain/src/gcc/gcc/analyzer/constraint-manager.cc:1773
0x2659ef0 ana::region_model::add_constraint(ana::svalue const*, tree_code,
ana::svalue const*, ana::region_model_context*)
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/region-model.cc:4565
0x265a087 ana::region_model::add_constraints_from_binop(ana::svalue const*,
tree_code, ana::svalue const*, bool*, ana::region_model_context*)
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/region-model.cc:4482
0x2659ec4 ana::region_model::add_constraint(ana::svalue const*, tree_code,
ana::svalue const*, ana::region_model_context*)
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/region-model.cc:4561
0x265a0db ana::region_model::add_constraints_from_binop(ana::svalue const*,
tree_code, ana::svalue const*, bool*, ana::region_model_context*)
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/region-model.cc:4495
0x2659ec4 ana::region_model::add_constraint(ana::svalue const*, tree_code,
ana::svalue const*, ana::region_model_context*)
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/region-model.cc:4561
0x265b271 ana::region_model::add_constraint(tree_node*, tree_code, tree_node*,
ana::region_model_context*, std::unique_ptr<ana::rejected_constraint,
std::default_delete<ana::rejected_constraint> >*)
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/region-model.cc:4593
0x263dc74 ana::program_state::on_edge(ana::exploded_graph&,
ana::exploded_node*, ana::superedge const*, ana::uncertainty_t*)
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/program-state.cc:1148
0x262027e ana::exploded_graph::process_node(ana::exploded_node*)
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/engine.cc:4334
0x262132a ana::exploded_graph::process_worklist()
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/engine.cc:3486
0x26238a1 ana::impl_run_checkers(ana::logger*)
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/engine.cc:6154
0x2624756 ana::run_checkers()
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/engine.cc:6242
0x25e52e8 execute
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/analyzer-pass.cc:87
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug analyzer/111881] [14 Regression] analyzer: ICE in ensure_closed, at analyzer/constraint-manager.cc:130 with -Ofast

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111881

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2024-01-30
   Target Milestone|---                         |14.0
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
            Summary|analyzer: ICE in            |[14 Regression] analyzer:
                   |ensure_closed, at           |ICE in ensure_closed, at
                   |analyzer/constraint-manager |analyzer/constraint-manager
                   |.cc:130 with -Ofast         |.cc:130 with -Ofast

--- Comment #1 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Confirmed:
* affects trunk: https://godbolt.org/z/vzj4c6TE1
* doesn't seem to affect 13.2: https://godbolt.org/z/zGr3r8Poe

[Bug analyzer/111881] [14 Regression] analyzer: ICE in ensure_closed, at analyzer/constraint-manager.cc:130 with -Ofast

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111881

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:43ad6ce60108acc822efcd394b75e270c1996cb5

commit r14-9195-g43ad6ce60108acc822efcd394b75e270c1996cb5
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Tue Feb 27 08:36:58 2024 -0500

    analyzer: fix ICE on floating-point bounds [PR111881]

    gcc/analyzer/ChangeLog:
            PR analyzer/111881
            * constraint-manager.cc (bound::ensure_closed): Assert that
            m_constant has integral type.
            (range::add_bound): Bail out on floating point constants.

    gcc/testsuite/ChangeLog:
            PR analyzer/111881
            * c-c++-common/analyzer/conditionals-pr111881.c: New test.

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>

[Bug analyzer/111881] [14 Regression] analyzer: ICE in ensure_closed, at analyzer/constraint-manager.cc:130 with -Ofast

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111881

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Should be fixed by above patch.