[Bug target/111907] New: ICE: in curr_insn_transform, at lra-constraints.cc:4294 unable to generate reloads for: {*andnottf3} with -mavx512f -mno-evex512 -mbionic

[Bug target/111907] New: ICE: in curr_insn_transform, at lra-constraints.cc:4294 unable to generate reloads for: {*andnottf3} with -mavx512f -mno-evex512 -mbionic

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111907

            Bug ID: 111907
           Summary: ICE: in curr_insn_transform, at
                    lra-constraints.cc:4294 unable to generate reloads
                    for: {*andnottf3} with -mavx512f -mno-evex512 -mbionic
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu

Created attachment 56165
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56165&action=edit
reduced testcase

Compiler output:
$ x86_64-pc-linux-gnu-gcc -mavx512f -mno-evex512 -mbionic testcase.c 
testcase.c: In function 'foo':
testcase.c:5:1: error: unable to generate reloads for:
    5 | }
      | ^
(insn 14 13 15 2 (set (reg:TF 104)
        (and:TF (not:TF (reg:TF 103))
            (reg:TF 99 [ _2 ]))) "testcase.c":4:10 3138 {*andnottf3}
     (expr_list:REG_DEAD (reg:TF 99 [ _2 ])
        (nil)))
during RTL pass: reload
testcase.c:5:1: internal compiler error: in curr_insn_transform, at
lra-constraints.cc:4294
0x7eee43 _fatal_insn(char const*, rtx_def const*, char const*, int, char
const*)
        /repo/gcc-trunk/gcc/rtl-error.cc:108
0x7a8d79 curr_insn_transform
        /repo/gcc-trunk/gcc/lra-constraints.cc:4294
0x12cea56 lra_constraints(bool)
        /repo/gcc-trunk/gcc/lra-constraints.cc:5497
0x12b7ae4 lra(_IO_FILE*)
        /repo/gcc-trunk/gcc/lra.cc:2419
0x1266d99 do_reload
        /repo/gcc-trunk/gcc/ira.cc:5973
0x1266d99 execute
        /repo/gcc-trunk/gcc/ira.cc:6161
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r14-4813-20231021102502-g57cbb1d3344-checking-yes-rtl-df-extra-nobootstrap-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/14.0.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--disable-bootstrap --with-cloog --with-ppl --with-isl
--build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
--target=x86_64-pc-linux-gnu --with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r14-4813-20231021102502-g57cbb1d3344-checking-yes-rtl-df-extra-nobootstrap-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 14.0.0 20231021 (experimental) (GCC)

[Bug target/111907] ICE: in curr_insn_transform, at lra-constraints.cc:4294 unable to generate reloads for: {*andnottf3} with -mavx512f -mno-evex512

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111907

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ICE: in                     |ICE: in
                   |curr_insn_transform, at     |curr_insn_transform, at
                   |lra-constraints.cc:4294     |lra-constraints.cc:4294
                   |unable to generate reloads  |unable to generate reloads
                   |for: {*andnottf3} with      |for: {*andnottf3} with
                   |-mavx512f -mno-evex512      |-mavx512f -mno-evex512
                   |-mbionic                    |

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Simplified testcase:
```
_Float128
foo (_Float128 d, _Float128 e)
{
  return __builtin_copysignf128 (d, e);
}
```

Just use `-mavx512f -mno-evex512` . No reason for the `-mbionic` here (which
changes `long double` into the IEEE128 bit long double rather than the 90bit
long double.

[Bug target/111907] ICE: in curr_insn_transform, at lra-constraints.cc:4294 unable to generate reloads for: {*andnottf3} with -mavx512f -mno-evex512

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111907

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2023-11-04

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
.

[Bug target/111907] ICE: in curr_insn_transform, at lra-constraints.cc:4294 unable to generate reloads for: {*andnottf3} with -mavx512f -mno-evex512

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111907

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |haochen.jiang at intel dot com

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Something is not being disabled correctly with -mno-evex512 or something is not
being enabled correctly.

TF mode is valid for SSE ...

[Bug target/111907] ICE: in curr_insn_transform, at lra-constraints.cc:4294 unable to generate reloads for: {*andnottf3} with -mavx512f -mno-evex512

[haochen.jiang at intel dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111907

--- Comment #4 from Haochen Jiang <haochen.jiang at intel dot com> ---
I guess it is caused by "*andnot<mode>3", not confirmed yet.
The isa for the last constraint changed to avx512f_512, which will make the
pattern disabled under -mavx512f -mno-evex512.
Let me find a solution on that.

[Bug target/111907] ICE: in curr_insn_transform, at lra-constraints.cc:4294 unable to generate reloads for: {*andnottf3} with -mavx512f -mno-evex512

[haochen.jiang at intel dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111907

--- Comment #5 from Haochen Jiang <haochen.jiang at intel dot com> ---
BTW, it should be disabled since it will use zmm previously.

foo(_Float128, _Float128):
        push    rbp
        mov     rbp, rsp
        vmovdqa XMMWORD PTR [rbp-16], xmm0
        vmovdqa XMMWORD PTR [rbp-32], xmm1
        vmovdqa xmm1, XMMWORD PTR [rbp-16]
        vmovdqa xmm2, XMMWORD PTR [rbp-32]
        vmovdqa xmm0, XMMWORD PTR .LC0[rip]
        vpandnq zmm1, zmm0, zmm1
        vpand   xmm0, xmm0, xmm2
        vpor    xmm0, xmm1, xmm0
        pop     rbp
        ret

A straightforward solution might be trying to use its xmm version here.

[Bug target/111907] ICE: in curr_insn_transform, at lra-constraints.cc:4294 unable to generate reloads for: {*andnottf3} with -mavx512f -mno-evex512

[haochen.jiang at intel dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111907

--- Comment #6 from Haochen Jiang <haochen.jiang at intel dot com> ---
Proposed patch:

https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635410.html

[Bug target/111907] ICE: in curr_insn_transform, at lra-constraints.cc:4294 unable to generate reloads for: {*andnottf3} with -mavx512f -mno-evex512

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111907

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Haochen Jiang <jianghc@gcc.gnu.org>:

https://gcc.gnu.org/g:078087d1605060da4f993af83b1bfa351b278d38

commit r14-5238-g078087d1605060da4f993af83b1bfa351b278d38
Author: Haochen Jiang <haochen.jiang@intel.com>
Date:   Mon Nov 6 14:34:01 2023 +0800

    i386: Fix isa attribute for TI/TF andnot mode

    gcc/ChangeLog:

            PR target/111907
            * config/i386/i386.md (avx_noavx512vl): New definition for isa
            attribute.
            * config/i386/sse.md (*andnot<mode>3): Change isa attribute from
            avx_noavx512f to avx_noavx512vl.

    gcc/testsuite/ChangeLog:

            PR target/111907
            * gcc.target/i386/pr111907.c: New test.

[Bug target/111907] ICE: in curr_insn_transform, at lra-constraints.cc:4294 unable to generate reloads for: {*andnottf3} with -mavx512f -mno-evex512

[haochen.jiang at intel dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111907

--- Comment #8 from Haochen Jiang <haochen.jiang at intel dot com> ---
Should be fixed on trunk now.

[Bug target/111907] ICE: in curr_insn_transform, at lra-constraints.cc:4294 unable to generate reloads for: {*andnottf3} with -mavx512f -mno-evex512

[liuhongt at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111907

liuhongt at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liuhongt at gcc dot gnu.org
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from liuhongt at gcc dot gnu.org ---
.