public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "juzhe.zhong at rivai dot ai" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/111931] New: RISC-V: Trivial optimization of VSETVL PASS
Date: Mon, 23 Oct 2023 09:26:47 +0000	[thread overview]
Message-ID: <bug-111931-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111931

            Bug ID: 111931
           Summary: RISC-V: Trivial optimization of VSETVL PASS
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: juzhe.zhong at rivai dot ai
  Target Milestone: ---

#include "riscv_vector.h"

void foo9 (int8_t *base, int8_t* out, size_t vl, size_t m)
{
    vint8mf8_t v0;
    size_t avl = __riscv_vsetvl_e8mf8 (vl);

    for (size_t i = 0; i < m; i++)
    {
        v0 = __riscv_vle8_v_i8mf8 (base + i, avl);
        __riscv_vse8_v_i8mf8 (out + i, v0, avl);
    }
}

ASM:

        vsetvli a2,a2,e8,mf8,ta,ma
        beq     a3,zero,.L8
        add     a3,a0,a3
.L3:
        vle8.v  v1,0(a0)
        addi    a0,a0,1
        vse8.v  v1,0(a1)
        addi    a1,a1,1
        bne     a0,a3,.L3
.L8:
        ret

The vsetvl should be optimized into "vsetvl zero, a2" instead of "vsetvl a2,a2"

The reason we failed to optimize it is because we set the entry block as
unknown block when computing reaching_def. So preds_has_same_avl_p is false.

As long as there are predecessors block before the user vsetvl, we can optimize
it.

This is an trivial issue. I will fix it if I find the time.

             reply	other threads:[~2023-10-23  9:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-23  9:26 juzhe.zhong at rivai dot ai [this message]
2023-11-02 22:47 ` [Bug target/111931] " juzhe.zhong at rivai dot ai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-111931-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).