[Bug c/111935] New: gcc ICE with risc-v vector intrinsics

[Bug c/111935] New: gcc ICE with risc-v vector intrinsics

[julienpommier at free dot fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111935

            Bug ID: 111935
           Summary: gcc ICE with risc-v vector intrinsics
           Product: gcc
           Version: 13.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: julienpommier at free dot fr
  Target Milestone: ---

The following code (test.c) crashes the riscv gcc 13.2.0 compiler of ubuntu
23.10:

#include <riscv_vector.h>

inline vuint32m4_t __attribute__((__always_inline__)) transpose_indexes() {
  static const uint32_t idx_[16] = {0, 4, 8, 12,
                      1, 5, 9, 13,
                      2, 6, 10, 14,
                      3, 7, 11, 15};
  return __riscv_vle32_v_u32m4(idx_, 16);
}

void pffft_real_preprocess_4x4(const float *in) {
  vfloat32m1_t r0=__riscv_vle32_v_f32m1(in,4);
  vfloat32m4_t tmp = __riscv_vundefined_f32m4();
  tmp = __riscv_vset_v_f32m1_f32m4(tmp, 0, r0);
  tmp = __riscv_vset_v_f32m1_f32m4(tmp, 1, r0);
  tmp = __riscv_vset_v_f32m1_f32m4(tmp, 2, r0);
  tmp = __riscv_vset_v_f32m1_f32m4(tmp, 3, r0);
  tmp = __riscv_vrgather_vv_f32m4(tmp, transpose_indexes(), 16);
  r0 = __riscv_vget_v_f32m4_f32m1(tmp, 0);
}



when compiled with:

riscv64-linux-gnu-gcc-13 -O1 -march=rv64gcv -c testcase.c

the output is:

during RTL pass: expand
test.c: In function ‘pffft_real_preprocess_4x4’:
test.c:19:8: internal compiler error: Segmentation fault
   19 |   r0 = __riscv_vget_v_f32m4_f32m1(tmp, 0);
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
0xffffae3a7583 __libc_start_call_main
        ../sysdeps/nptl/libc_start_call_main.h:58
0xffffae3a7657 __libc_start_main_impl
        ../csu/libc-start.c:360
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <file:///usr/share/doc/gcc-13/README.Bugs> for instructions.

[Bug target/111935] gcc ICE with risc-v vector intrinsics

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111935

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-10-23
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed, still happens on the trunk.

[Bug target/111935] gcc ICE with risc-v vector intrinsics

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111935

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Li Xu <xuli@gcc.gnu.org>:

https://gcc.gnu.org/g:b44d4ff7b43ff6a34d5c074c7ade03c4a38974fa

commit r14-4879-gb44d4ff7b43ff6a34d5c074c7ade03c4a38974fa
Author: xuli <xuli1@eswincomputing.com>
Date:   Tue Oct 24 07:39:02 2023 +0000

    RISC-V: Fix ICE of RVV vget/vset intrinsic[PR111935]

    Calling vget/vset intrinsic without receiving a return value will cause
    a crash. Because in this case e.target is null.
    This patch should be backported to releases/gcc-13.

            PR target/111935

    gcc/ChangeLog:

            * config/riscv/riscv-vector-builtins-bases.cc: fix bug.

    gcc/testsuite/ChangeLog:

            * gcc.target/riscv/rvv/base/pr111935.c: New test.

[Bug target/111935] gcc ICE with risc-v vector intrinsics

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111935

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Li Xu <xuli@gcc.gnu.org>:

https://gcc.gnu.org/g:b22b845834f8bdc4e18d95b4f36ba702c01ed5f8

commit r13-7996-gb22b845834f8bdc4e18d95b4f36ba702c01ed5f8
Author: xuli <xuli1@eswincomputing.com>
Date:   Tue Oct 24 07:39:02 2023 +0000

    RISC-V: Fix ICE of RVV vget/vset intrinsic[PR111935]

    Calling vget/vset intrinsic without receiving a return value will cause
    a crash. Because in this case e.target is null.
    This patch should be backported to releases/gcc-13.

            PR target/111935

    gcc/ChangeLog:

            * config/riscv/riscv-vector-builtins-bases.cc: fix bug.

    gcc/testsuite/ChangeLog:

            * gcc.target/riscv/rvv/base/pr111935.c: New test.

    (cherry picked from commit b44d4ff7b43ff6a34d5c074c7ade03c4a38974fa)

[Bug target/111935] gcc ICE with risc-v vector intrinsics

[aoliva at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111935

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aoliva at gcc dot gnu.org

--- Comment #4 from Alexandre Oliva <aoliva at gcc dot gnu.org> ---
Does the test pass in gcc-13 for anyone?  ISTM that it doesn't.  I bisected it
and got to commit 973eb0deb467c79cc21f265a710a81054cfd3e8c AKA r14-3535, for
bug 110943, as the first in which the test generates the expected number of
matches of the vs... pattern.

[Bug target/111935] gcc ICE with risc-v vector intrinsics

[kito at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111935

Kito Cheng <kito at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |kito at gcc dot gnu.org

--- Comment #5 from Kito Cheng <kito at gcc dot gnu.org> ---
Checked this has fixed on trunk and GCC 13 branch