public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug modula2/111955] New: isnan support in Builtins.def is missing
@ 2023-10-24 15:27 gaius at gcc dot gnu.org
2023-10-25 4:35 ` [Bug modula2/111955] " gaius at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: gaius at gcc dot gnu.org @ 2023-10-24 15:27 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111955
Bug ID: 111955
Summary: isnan support in Builtins.def is missing
Product: gcc
Version: 14.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: modula2
Assignee: gaius at gcc dot gnu.org
Reporter: gaius at gcc dot gnu.org
Target Milestone: ---
Access to BUILT_IN_ISNAN via isnan, isnanf, isnanl is missing in
gcc/m2/gm2-libs/Builtins.def.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug modula2/111955] isnan support in Builtins.def is missing
2023-10-24 15:27 [Bug modula2/111955] New: isnan support in Builtins.def is missing gaius at gcc dot gnu.org
@ 2023-10-25 4:35 ` gaius at gcc dot gnu.org
2023-10-25 4:39 ` gaius at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: gaius at gcc dot gnu.org @ 2023-10-25 4:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111955
Gaius Mulley <gaius at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2023-10-25
Ever confirmed|0 |1
Status|UNCONFIRMED |ASSIGNED
--- Comment #1 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Confirmed.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug modula2/111955] isnan support in Builtins.def is missing
2023-10-24 15:27 [Bug modula2/111955] New: isnan support in Builtins.def is missing gaius at gcc dot gnu.org
2023-10-25 4:35 ` [Bug modula2/111955] " gaius at gcc dot gnu.org
@ 2023-10-25 4:39 ` gaius at gcc dot gnu.org
2023-10-25 4:46 ` gaius at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: gaius at gcc dot gnu.org @ 2023-10-25 4:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111955
--- Comment #2 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 56199
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56199&action=edit
Proposed fix
Here is the proposed patch with a tiny regression test module. It will be
applied once / if the current running bootstrap succeeds on a few platforms.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug modula2/111955] isnan support in Builtins.def is missing
2023-10-24 15:27 [Bug modula2/111955] New: isnan support in Builtins.def is missing gaius at gcc dot gnu.org
2023-10-25 4:35 ` [Bug modula2/111955] " gaius at gcc dot gnu.org
2023-10-25 4:39 ` gaius at gcc dot gnu.org
@ 2023-10-25 4:46 ` gaius at gcc dot gnu.org
2023-10-25 10:04 ` cvs-commit at gcc dot gnu.org
2023-10-25 10:06 ` gaius at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: gaius at gcc dot gnu.org @ 2023-10-25 4:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111955
Gaius Mulley <gaius at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56199|0 |1
is obsolete| |
--- Comment #3 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 56200
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56200&action=edit
Proposed fix v2
Corrected patch (removed a m2 ism from c++ code).
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug modula2/111955] isnan support in Builtins.def is missing
2023-10-24 15:27 [Bug modula2/111955] New: isnan support in Builtins.def is missing gaius at gcc dot gnu.org
` (2 preceding siblings ...)
2023-10-25 4:46 ` gaius at gcc dot gnu.org
@ 2023-10-25 10:04 ` cvs-commit at gcc dot gnu.org
2023-10-25 10:06 ` gaius at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-10-25 10:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111955
--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:
https://gcc.gnu.org/g:8bb655d0c56502798d664ab0c1685bbab4aaa454
commit r14-4921-g8bb655d0c56502798d664ab0c1685bbab4aaa454
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date: Wed Oct 25 11:04:12 2023 +0100
PR modula2/111955 introduce isnan support to Builtins.def
This patch introduces isnan, isnanf and isnanl to Builtins.def.
It requires fallback functions isnan, isnanf, isnanl to be implemented in
libgm2/libm2pim/wrapc.cc and gm2-libs-ch/wrapc.c.
Access to the GCC builtin isnan tree is provided by adding
an isnan definition and support functions to gm2-gcc/m2builtins.cc.
gcc/m2/ChangeLog:
PR modula2/111955
* gm2-gcc/m2builtins.cc (gm2_isnan_node): New tree.
(DoBuiltinIsnan): New function.
(m2builtins_BuiltInIsnan): New function.
(m2builtins_init): Initialize gm2_isnan_node.
(list_of_builtins): Add define for __builtin_isnan.
* gm2-libs-ch/wrapc.c (wrapc_isnan): New function.
(wrapc_isnanf): New function.
(wrapc_isnanl): New function.
* gm2-libs/Builtins.def (isnanf): New procedure function.
(isnan): New procedure function.
(isnanl): New procedure function.
* gm2-libs/Builtins.mod:
* gm2-libs/wrapc.def (isnan): New function.
(isnanf): New function.
(isnanl): New function.
libgm2/ChangeLog:
PR modula2/111955
* libm2pim/wrapc.cc (isnan): Export new function.
(isnanf): Export new function.
(isnanl): Export new function.
gcc/testsuite/ChangeLog:
PR modula2/111955
* gm2/pimlib/run/pass/testnan.mod: New test.
Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug modula2/111955] isnan support in Builtins.def is missing
2023-10-24 15:27 [Bug modula2/111955] New: isnan support in Builtins.def is missing gaius at gcc dot gnu.org
` (3 preceding siblings ...)
2023-10-25 10:04 ` cvs-commit at gcc dot gnu.org
@ 2023-10-25 10:06 ` gaius at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: gaius at gcc dot gnu.org @ 2023-10-25 10:06 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111955
Gaius Mulley <gaius at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Closing now that the patch has been applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-10-25 10:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-24 15:27 [Bug modula2/111955] New: isnan support in Builtins.def is missing gaius at gcc dot gnu.org
2023-10-25 4:35 ` [Bug modula2/111955] " gaius at gcc dot gnu.org
2023-10-25 4:39 ` gaius at gcc dot gnu.org
2023-10-25 4:46 ` gaius at gcc dot gnu.org
2023-10-25 10:04 ` cvs-commit at gcc dot gnu.org
2023-10-25 10:06 ` gaius at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).