[Bug d/112270] New: ICE: in verify_gimple_in_seq on powerpc-darwin9

[Bug d/112270] New: ICE: in verify_gimple_in_seq on powerpc-darwin9

[ibuclaw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112270

            Bug ID: 112270
           Summary: ICE: in verify_gimple_in_seq on powerpc-darwin9
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: d
          Assignee: ibuclaw at gdcproject dot org
          Reporter: ibuclaw at gcc dot gnu.org
  Target Milestone: ---

Mismatching D and C boolean types causes ICE on powerpc-darwin.

---../../gcc/d/dmd/cppmangle.d: In function ‘isNamespaceEqual’:
../../gcc/d/dmd/cppmangle.d:2354:14: error: non-trivial conversion in
‘integer_cst’
 2354 | private bool isNamespaceEqual (CPPNamespaceDeclaration a,
CPPNamespaceDeclaration b) @safe
      |              ^
bool
<unsigned-boolean:1>
iftmp.120 = 1;
../../gcc/d/dmd/cppmangle.d:2354:14: internal compiler error: ‘verify_gimple’
failed
0x118c5a5 verify_gimple_in_seq(gimple*, bool)
        ../../gcc/tree-cfg.cc:5297
0xe4192b gimplify_body(tree_node*, bool)
        ../../gcc/gimplify.cc:18046
0xe41a9f gimplify_function_tree(tree_node*)
        ../../gcc/gimplify.cc:18162
0xc571f7 cgraph_node::analyze()
        ../../gcc/cgraphunit.cc:684
0xc598d7 analyze_functions
        ../../gcc/cgraphunit.cc:1247
0xc5a621 symbol_table::finalize_compilation_unit()
        ../../gcc/cgraphunit.cc:2554
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.
../../gcc/d/dmd/cppmangle.d failed
---


Minimal reproducer:
---
class CPPNamespaceDeclaration { }
bool isNamespaceEqual (CPPNamespaceDeclaration a)
{
    return a ? true : isNamespaceEqual(a);
}

[Bug d/112270] ICE: in verify_gimple_in_seq on powerpc-darwin9

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112270

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:10f1489dcb3bd9adccc88898bc12f53398fa3583

commit r14-4989-g10f1489dcb3bd9adccc88898bc12f53398fa3583
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Sun Oct 29 00:27:49 2023 +0200

    d: Fix ICE: in verify_gimple_in_seq on powerpc-darwin9 [PR112270]

    This ICE was seen during stage2 on powerpc-darwin9 only.  There were
    still some uses of GCC's boolean_type_node in the D front-end, which
    caused a type mismatch to trigger as D bool size is fixed to 1 byte on
    all targets.

    So two new nodes have been introduced - d_bool_false_node and
    d_bool_true_node - which have replaced all remaining uses of
    boolean_false_node and boolean_true_node respectively.

            PR d/112270

    gcc/d/ChangeLog:

            * d-builtins.cc (d_build_d_type_nodes): Initialize
d_bool_false_node,
            d_bool_true_node.
            * d-codegen.cc (build_array_struct_comparison): Use
d_bool_false_node
            instead of boolean_false_node.
            * d-convert.cc (d_truthvalue_conversion): Use d_bool_false_node and
            d_bool_true_node instead of boolean_false_node and
boolean_true_node.
            * d-tree.h (enum d_tree_index): Add DTI_BOOL_FALSE and
DTI_BOOL_TRUE.
            (d_bool_false_node): New macro.
            (d_bool_true_node): New macro.
            * modules.cc (build_dso_cdtor_fn): Use d_bool_false_node and
            d_bool_true_node instead of boolean_false_node and
boolean_true_node.
            (register_moduleinfo): Use d_bool_type instead of
boolean_type_node.

    gcc/testsuite/ChangeLog:

            * gdc.dg/pr112270.d: New test.

[Bug d/112270] ICE: in verify_gimple_in_seq on powerpc-darwin9

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112270

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Iain Buclaw
<ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:ab5c18d76497d52ade3c04c412060bc2d718d7ab

commit r13-7990-gab5c18d76497d52ade3c04c412060bc2d718d7ab
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Sun Oct 29 00:27:49 2023 +0200

    d: Fix ICE: in verify_gimple_in_seq on powerpc-darwin9 [PR112270]

    This ICE was seen during stage2 on powerpc-darwin9 only.  There were
    still some uses of GCC's boolean_type_node in the D front-end, which
    caused a type mismatch to trigger as D bool size is fixed to 1 byte on
    all targets.

    So two new nodes have been introduced - d_bool_false_node and
    d_bool_true_node - which have replaced all remaining uses of
    boolean_false_node and boolean_true_node respectively.

            PR d/112270

    gcc/d/ChangeLog:

            * d-builtins.cc (d_build_d_type_nodes): Initialize
d_bool_false_node,
            d_bool_true_node.
            * d-codegen.cc (build_array_struct_comparison): Use
d_bool_false_node
            instead of boolean_false_node.
            * d-convert.cc (d_truthvalue_conversion): Use d_bool_false_node and
            d_bool_true_node instead of boolean_false_node and
boolean_true_node.
            * d-tree.h (enum d_tree_index): Add DTI_BOOL_FALSE and
DTI_BOOL_TRUE.
            (d_bool_false_node): New macro.
            (d_bool_true_node): New macro.
            * modules.cc (build_dso_cdtor_fn): Use d_bool_false_node and
            d_bool_true_node instead of boolean_false_node and
boolean_true_node.
            (register_moduleinfo): Use d_bool_type instead of
boolean_type_node.

    gcc/testsuite/ChangeLog:

            * gdc.dg/pr112270.d: New test.

    (cherry picked from commit 10f1489dcb3bd9adccc88898bc12f53398fa3583)

[Bug d/112270] ICE: in verify_gimple_in_seq on powerpc-darwin9

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112270

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Iain Buclaw
<ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:8362293229626e608afeca8008ad23ea07cda1e7

commit r12-9949-g8362293229626e608afeca8008ad23ea07cda1e7
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Sun Oct 29 00:27:49 2023 +0200

    d: Fix ICE: in verify_gimple_in_seq on powerpc-darwin9 [PR112270]

    This ICE was seen during stage2 on powerpc-darwin9 only.  There were
    still some uses of GCC's boolean_type_node in the D front-end, which
    caused a type mismatch to trigger as D bool size is fixed to 1 byte on
    all targets.

    So two new nodes have been introduced - d_bool_false_node and
    d_bool_true_node - which have replaced all remaining uses of
    boolean_false_node and boolean_true_node respectively.

            PR d/112270

    gcc/d/ChangeLog:

            * d-builtins.cc (d_build_d_type_nodes): Initialize
d_bool_false_node,
            d_bool_true_node.
            * d-codegen.cc (build_array_struct_comparison): Use
d_bool_false_node
            instead of boolean_false_node.
            * d-convert.cc (d_truthvalue_conversion): Use d_bool_false_node and
            d_bool_true_node instead of boolean_false_node and
boolean_true_node.
            * d-tree.h (enum d_tree_index): Add DTI_BOOL_FALSE and
DTI_BOOL_TRUE.
            (d_bool_false_node): New macro.
            (d_bool_true_node): New macro.
            * modules.cc (build_dso_cdtor_fn): Use d_bool_false_node and
            d_bool_true_node instead of boolean_false_node and
boolean_true_node.
            (register_moduleinfo): Use d_bool_type instead of
boolean_type_node.

    gcc/testsuite/ChangeLog:

            * gdc.dg/pr112270.d: New test.

    (cherry picked from commit 10f1489dcb3bd9adccc88898bc12f53398fa3583)

[Bug d/112270] ICE: in verify_gimple_in_seq on powerpc-darwin9

[ibuclaw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112270

ibuclaw at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from ibuclaw at gcc dot gnu.org ---
Fix committed, and backported to GCC 13 and GCC 12 release branches.