[Bug target/112299] New: Cross compiling to loongarch64-linux-gnuf64 fails because "HAVE_AS_TLS was not declared" after r14-4925-g1b30ef7cea773e

[Bug target/112299] New: Cross compiling to loongarch64-linux-gnuf64 fails because "HAVE_AS_TLS was not declared" after r14-4925-g1b30ef7cea773e

[jamborm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112299

            Bug ID: 112299
           Summary: Cross compiling to loongarch64-linux-gnuf64 fails
                    because "HAVE_AS_TLS was not declared" after
                    r14-4925-g1b30ef7cea773e
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jamborm at gcc dot gnu.org
                CC: chenxiaolong at loongson dot cn
  Target Milestone: ---
              Host: x86_64-linux-gnu
            Target: loongarch64-linux-gnuf64

Starting with r14-4925-g1b30ef7cea773e, when I try to test that cross
compilation to target loongarch64-linux-gnuf64 still works by configuring gcc
with:

$ ../src/configure --target=loongarch64-linux-gnuf64 --disable-bootstrap
--enable-languages=c,c++ --disable-multilib  --enable-obsolete

and then building just the compiler with:

$ make -j64 all-host CXXFLAGS="-O0 -g" CFLAGS="-O0 -g"

The compilation fails with:

../../src/gcc/config/loongarch/loongarch.md:3655:2: error: ‘HAVE_AS_TLS’ was
not declared in this scope
 3655 |   "HAVE_AS_TLS"
      |  ^~~~~~~~~~~
config.status: executing libtool commands
../../src/gcc/config/loongarch/loongarch.md:3655:2: error: ‘HAVE_AS_TLS’ was
not declared in this scope
 3655 |   "HAVE_AS_TLS"
      |  ^~~~~~~~~~~
../../src/gcc/config/loongarch/loongarch.md:3655:2: error: ‘HAVE_AS_TLS’ was
not declared in this scope
 3655 |   "HAVE_AS_TLS"
      |  ^~~~~~~~~~~
../../src/gcc/config/loongarch/loongarch.md:3655:2: error: ‘HAVE_AS_TLS’ was
not declared in this scope
 3655 |   "HAVE_AS_TLS"
      |  ^~~~~~~~~~~
make[1]: *** [Makefile:2958: build/gencondmd.o] Error 1
make[1]: *** Waiting for unfinished jobs....
rm gfdl.pod gcc.pod gcov-dump.pod gcov-tool.pod fsf-funding.pod gpl.pod cpp.pod
gcov.pod lto-dump.pod
make[1]: Leaving directory '/home/mjambor/gcc/mine/obj/gcc'

According to our buildbot, building a cross for loongarch64-linux-gnuf32 and
loongarch64-linux-gnusf also fails, likely because of the same issue.

[Bug target/112299] Cross compiling to loongarch64-linux-gnuf64 fails because "HAVE_AS_TLS was not declared" after r14-4925-g1b30ef7cea773e

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112299

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
https://gcc.gnu.org/pipermail/gcc-patches/2023-October/634687.html

[Bug target/112299] [14 Regression] Cross compiling to loongarch64-linux-gnuf64 fails because "HAVE_AS_TLS was not declared" after r14-4925-g1b30ef7cea773e

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112299

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Keywords|                            |build, patch
   Last reconfirmed|                            |2023-10-30
            Summary|Cross compiling to          |[14 Regression] Cross
                   |loongarch64-linux-gnuf64    |compiling to
                   |fails because "HAVE_AS_TLS  |loongarch64-linux-gnuf64
                   |was not declared" after     |fails because "HAVE_AS_TLS
                   |r14-4925-g1b30ef7cea773e    |was not declared" after
                   |                            |r14-4925-g1b30ef7cea773e
   Target Milestone|---                         |14.0
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2023-October
                   |                            |/634687.html
             Status|UNCONFIRMED                 |NEW

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
.

Looks like the patch was approved but not yet committed.

[Bug target/112299] [14 Regression] Cross compiling to loongarch64-linux-gnuf64 fails because "HAVE_AS_TLS was not declared" after r14-4925-g1b30ef7cea773e

[xry111 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112299

Xi Ruoyao <xry111 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |xry111 at gcc dot gnu.org

--- Comment #3 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
I'll push the patch after rebasing and adding this PR number into the
changelog.

[Bug target/112299] [14 Regression] Cross compiling to loongarch64-linux-gnuf64 fails because "HAVE_AS_TLS was not declared" after r14-4925-g1b30ef7cea773e

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112299

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Xi Ruoyao <xry111@gcc.gnu.org>:

https://gcc.gnu.org/g:6bf2cebe2bf49919c78814cb447d3aa6e3550d89

commit r14-5030-g6bf2cebe2bf49919c78814cb447d3aa6e3550d89
Author: Xi Ruoyao <xry111@xry111.site>
Date:   Mon Oct 30 19:39:27 2023 +0800

    LoongArch: Define HAVE_AS_TLS to 0 if it's undefined [PR112299]

    Now loongarch.md uses HAVE_AS_TLS, we need this to fix the failure
    building a cross compiler if the cross assembler is not installed yet.

    gcc/ChangeLog:

            PR target/112299
            * config/loongarch/loongarch-opts.h (HAVE_AS_TLS): Define to 0
            if not defined yet.

[Bug target/112299] [14 Regression] Cross compiling to loongarch64-linux-gnuf64 fails because "HAVE_AS_TLS was not declared" after r14-4925-g1b30ef7cea773e

[xry111 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112299

Xi Ruoyao <xry111 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
Fixed for 14.

[Bug target/112299] [14 Regression] Cross compiling to loongarch64-linux-gnuf64 fails because "HAVE_AS_TLS was not declared" after r14-4925-g1b30ef7cea773e

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112299

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by LuluCheng
<chenglulu@gcc.gnu.org>:

https://gcc.gnu.org/g:09de4b6b22bd66dacdade65ce633f29f302363b5

commit r12-10172-g09de4b6b22bd66dacdade65ce633f29f302363b5
Author: Xi Ruoyao <xry111@xry111.site>
Date:   Mon Oct 30 19:39:27 2023 +0800

    LoongArch: Define HAVE_AS_TLS to 0 if it's undefined [PR112299]

    Now loongarch.md uses HAVE_AS_TLS, we need this to fix the failure
    building a cross compiler if the cross assembler is not installed yet.

    gcc/ChangeLog:

            PR target/112299
            * config/loongarch/loongarch-opts.h (HAVE_AS_TLS): Define to 0
            if not defined yet.

    (cherry picked from commit 6bf2cebe2bf49919c78814cb447d3aa6e3550d89)

[Bug target/112299] [14 Regression] Cross compiling to loongarch64-linux-gnuf64 fails because "HAVE_AS_TLS was not declared" after r14-4925-g1b30ef7cea773e

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112299

--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by LuluCheng
<chenglulu@gcc.gnu.org>:

https://gcc.gnu.org/g:b1cad801dac215b2f594166e69759f33bd791308

commit r13-8352-gb1cad801dac215b2f594166e69759f33bd791308
Author: Xi Ruoyao <xry111@xry111.site>
Date:   Mon Oct 30 19:39:27 2023 +0800

    LoongArch: Define HAVE_AS_TLS to 0 if it's undefined [PR112299]

    Now loongarch.md uses HAVE_AS_TLS, we need this to fix the failure
    building a cross compiler if the cross assembler is not installed yet.

    gcc/ChangeLog:

            PR target/112299
            * config/loongarch/loongarch-opts.h (HAVE_AS_TLS): Define to 0
            if not defined yet.

    (cherry picked from commit 6bf2cebe2bf49919c78814cb447d3aa6e3550d89)