public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/112300] [14 Regression] Cross compiling to mipsisa64r2-sde-elf fails because "HEAP_TRAMPOLINES_INIT was not declared in this scope" since r14-4821-g28d8c680aaea46 Date: Mon, 27 Nov 2023 08:23:25 +0000 [thread overview] Message-ID: <bug-112300-4-5GsViCoadB@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-112300-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112300 --- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:221166ad15eb37b047c77118f2eb1c8442eaa27b commit r14-5868-g221166ad15eb37b047c77118f2eb1c8442eaa27b Author: Jakub Jelinek <jakub@redhat.com> Date: Mon Nov 27 09:22:20 2023 +0100 mips: Fix up mips*-sde-elf* build [PR112300] As reported in the PR, mipsisa64r2-sde-elf doesn't build because HEAP_TRAMPOLINES_INIT macro isn't defined anywhere. It is normally defined by # Figure out if we need to enable heap trampolines by default case ${target} in *-*-darwin2*) # Currently, we do this for macOS 11 and above. tm_defines="$tm_defines HEAP_TRAMPOLINES_INIT=1" ;; *) tm_defines="$tm_defines HEAP_TRAMPOLINES_INIT=0" ;; esac in config.gcc, but mips*-sde-elf* is the only target which overwrites tm_defines shell variable rather than just appending to it (or in one case prepending), all other targets append something to it, including other mips* triplets. I believe (just from looking at config.gcc) that the difference is that LIBC_GLIBC=1 LIBC_UCLIBC=2 LIBC_BIONIC=3 LIBC_MUSL=4 HEAP_TRAMPOLINES_INIT=0 isn't defined without the patch and is with the patch. I think defining those first 4 shouldn't cause any harm and defining the last one is required for it to actually build at all. 2023-11-27 Jakub Jelinek <jakub@redhat.com> PR target/112300 * config.gcc (mips*-sde-elf*): Append to tm_defines rather than overwriting them.
next prev parent reply other threads:[~2023-11-27 8:23 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-30 15:41 [Bug target/112300] New: " jamborm at gcc dot gnu.org 2023-10-31 8:44 ` [Bug target/112300] [14 Regression] " rguenth at gcc dot gnu.org 2023-11-24 15:47 ` jakub at gcc dot gnu.org 2023-11-27 8:23 ` cvs-commit at gcc dot gnu.org [this message] 2023-11-27 8:25 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-112300-4-5GsViCoadB@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).