public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/112304] cinc is not being used for (small) constant
Date: Thu, 25 Apr 2024 00:14:18 +0000	[thread overview]
Message-ID: <bug-112304-4-4fakPY2i33@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-112304-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112304

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note my patch does not change the fact that we don't pull the mov outside of
the loop for:
```
void f(int *a, int l)
{
  for(int i = 0; i < l; i++)
        a[i]=(a[i]!=0)+42;
}
```
But that is for a different issue to fix. The issue there is we have a cset/add
during the (RTL) LIM and we don't pull the constant out from the add. And then
we go and do the combine and found it is an cinc and then 42 becomes part of
the cinc. This is pre-existing issue and most likely could be reproduce with
other testcases too.

  parent reply	other threads:[~2024-04-25  0:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-31  4:48 [Bug target/112304] New: " pinskia at gcc dot gnu.org
2023-10-31  4:48 ` [Bug target/112304] " pinskia at gcc dot gnu.org
2023-10-31  4:51 ` pinskia at gcc dot gnu.org
2023-10-31  4:54 ` pinskia at gcc dot gnu.org
2024-04-25  0:14 ` pinskia at gcc dot gnu.org [this message]
2024-04-25  0:18 ` pinskia at gcc dot gnu.org
2024-04-26 17:38 ` pinskia at gcc dot gnu.org
2024-05-15  5:26 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-112304-4-4fakPY2i33@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).