public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/112304] New: cinc is not being used for (small) constant
Date: Tue, 31 Oct 2023 04:48:23 +0000	[thread overview]
Message-ID: <bug-112304-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112304

            Bug ID: 112304
           Summary: cinc is not being used for (small) constant
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: missed-optimization
          Severity: enhancement
          Priority: P3
         Component: target
          Assignee: pinskia at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---
            Target: aarch64-linux-gnu

Take:
```
int f(int a)
{
        return (a!=0)+42;
}
int f1(int a, int b)
{
        return (a!=0)+b;
}
```
Currently we get:
```
f:
        cmp     w0, 0
        cset    w0, ne
        add     w0, w0, 42
        ret
f1:
        cmp     w0, 0
        cinc    w0, w1, ne
        ret
```

But f should really be:
```
        mov     w1, #42
        cmp     w0, #0
        cinc    w0, w1, ne
        ret
```

Because for many newer aarch64 cores the `mov` in this case is "free" and does
not take up an issue slot or even the for a dual issue, the mov and cmp could
be issued together.  Even though it is the same # of instruction, the second
case is going to be faster due to latencies.

             reply	other threads:[~2023-10-31  4:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-31  4:48 pinskia at gcc dot gnu.org [this message]
2023-10-31  4:48 ` [Bug target/112304] " pinskia at gcc dot gnu.org
2023-10-31  4:51 ` pinskia at gcc dot gnu.org
2023-10-31  4:54 ` pinskia at gcc dot gnu.org
2024-04-25  0:14 ` pinskia at gcc dot gnu.org
2024-04-25  0:18 ` pinskia at gcc dot gnu.org
2024-04-26 17:38 ` pinskia at gcc dot gnu.org
2024-05-15  5:26 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-112304-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).