[Bug target/112308] New: [14 Regression] GCN: 'error: literal operands are not supported' for 'v_add_co_u32'

[Bug target/112308] New: [14 Regression] GCN: 'error: literal operands are not supported' for 'v_add_co_u32'

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112308

            Bug ID: 112308
           Summary: [14 Regression] GCN: 'error: literal operands are not
                    supported' for 'v_add_co_u32'
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: rejects-valid, testsuite-fail
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: tschwinge at gcc dot gnu.org
                CC: ams at gcc dot gnu.org, jules at gcc dot gnu.org
  Target Milestone: ---
            Target: GCN

(Assuming my tacking is to be believed) something in Git commit
r14-4720-gaf4bb221153359f5948da917d5ef2df738bb1e61..r14-4986-g4d3d2cdb574488223d023b590c3a34ddd93f4dae
regresses (or, likely, exposes?) the following:

    PASS: gcc.c-torture/compile/pr48596.c   -O0  (test for excess errors)
    PASS: gcc.c-torture/compile/pr48596.c   -O1  (test for excess errors)
    PASS: gcc.c-torture/compile/pr48596.c   -O2  (test for excess errors)
    [-PASS:-]{+FAIL:+} gcc.c-torture/compile/pr48596.c   -O3
-fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions 
(test for excess errors)
    [-PASS:-]{+FAIL:+} gcc.c-torture/compile/pr48596.c   -O3 -g  (test for
excess errors)
    PASS: gcc.c-torture/compile/pr48596.c   -Os  (test for excess errors)

    /tmp/ccZPdmCF.s:123:33: error: literal operands are not supported
            v_add_co_u32    v4, s[22:23], v7, 80
                                              ^

That's the only instance of 'error: literal operands are not supported' I can
find in all test logs.

That's for '-march=gfx90a', and that's LLVM 13.0.1, in case that's relevant. 
(I'm happy to just have this FAIL if the issue is due to old/buggy LLVM.)

[Bug target/112308] [14 Regression] GCN: 'error: literal operands are not supported' for 'v_add_co_u32'

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112308

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0

[Bug target/112308] [14 Regression] GCN: 'error: literal operands are not supported' for 'v_add_co_u32'

[ams at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112308

Andrew Stubbs <ams at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2023-11-09
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |ams at gcc dot gnu.org

[Bug target/112308] [14 Regression] GCN: 'error: literal operands are not supported' for 'v_add_co_u32'

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112308

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Stubbs <ams@gcc.gnu.org>:

https://gcc.gnu.org/g:e24b0fed9234716c146aaf6f8c1b39170e43a6f3

commit r14-5318-ge24b0fed9234716c146aaf6f8c1b39170e43a6f3
Author: Andrew Stubbs <ams@codesourcery.com>
Date:   Fri Nov 10 11:13:55 2023 +0000

    amdgcn: Fix v_add constraints (pr112308)

    The instruction doesn't allow "B" constants for the vop3b encoding (used
when
    the cc register isn't VCC), so fix the pattern and all the insns that might
get
    split to it post-reload.

    Also switch to the new constraint format for ease of adding new
alternatives.

    gcc/ChangeLog:

            PR target/112308
            * config/gcn/gcn-valu.md (add<mode>3<exec_clobber>): Fix B
constraint
            and switch to the new format.
            (add<mode>3_dup<exec_clobber>): Likewise.
            (add<mode>3_vcc<exec_vcc>): Likewise.
            (add<mode>3_vcc_dup<exec_vcc>): Likewise.
            (add<mode>3_vcc_zext_dup): Likewise.
            (add<mode>3_vcc_zext_dup_exec): Likewise.
            (add<mode>3_vcc_zext_dup2): Likewise.
            (add<mode>3_vcc_zext_dup2_exec): Likewise.

[Bug target/112308] [14 Regression] GCN: 'error: literal operands are not supported' for 'v_add_co_u32'

[ams at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112308

Andrew Stubbs <ams at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #2 from Andrew Stubbs <ams at gcc dot gnu.org> ---
This should be fixed now.