public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/112314] Missing index assertions in basic_string_view
Date: Thu, 02 Nov 2023 17:40:52 +0000 [thread overview]
Message-ID: <bug-112314-4-0u67sk7LJs@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-112314-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112314
--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Jose Dapena Paz from comment #5)
> - The length is less than the possible pointer difference (checked with
> numeric_limits).
That seems too lenient to me, because for wchar_t, char16_t and char32_t the
maximum length that can actually exist in the program will be less than
PTRDIFF_MAX.
Our std::vector::max_size() uses this:
// std::distance(begin(), end()) cannot be greater than PTRDIFF_MAX,
// and realistically we can't store more than PTRDIFF_MAX/sizeof(T)
// (even if std::allocator_traits::max_size says we can).
const size_t __diffmax
= __gnu_cxx::__numeric_traits<ptrdiff_t>::__max / sizeof(_Tp);
next prev parent reply other threads:[~2023-11-02 17:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 12:05 [Bug libstdc++/112314] New: " jdapena at igalia dot com
2023-10-31 15:28 ` [Bug libstdc++/112314] " redi at gcc dot gnu.org
2023-11-02 8:47 ` jdapena at igalia dot com
2023-11-02 14:54 ` cvs-commit at gcc dot gnu.org
2023-11-02 16:06 ` redi at gcc dot gnu.org
2023-11-02 16:19 ` jdapena at igalia dot com
2023-11-02 17:37 ` redi at gcc dot gnu.org
2023-11-02 17:40 ` redi at gcc dot gnu.org [this message]
2023-11-08 13:18 ` cvs-commit at gcc dot gnu.org
2023-12-06 16:35 ` cvs-commit at gcc dot gnu.org
2023-12-06 21:01 ` cvs-commit at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-112314-4-0u67sk7LJs@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).