public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/112314] Missing index assertions in basic_string_view
Date: Thu, 02 Nov 2023 16:06:23 +0000 [thread overview]
Message-ID: <bug-112314-4-sYNzQVVvzh@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-112314-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112314
--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Jose Dapena Paz from comment #2)
> In any case, the failing test is actually passing -1, my understanding is
> that that one should always assert no matter what we are passing as const
> char*.
Yes but I'm not going to add a check for -1 just to make some unit test pass.
In real code (size_t)-2 or (size_t)(-some other value) is at least as likely.
__glibcxx_assert(not in chromium tests) doesn't seem useful.
next prev parent reply other threads:[~2023-11-02 16:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 12:05 [Bug libstdc++/112314] New: " jdapena at igalia dot com
2023-10-31 15:28 ` [Bug libstdc++/112314] " redi at gcc dot gnu.org
2023-11-02 8:47 ` jdapena at igalia dot com
2023-11-02 14:54 ` cvs-commit at gcc dot gnu.org
2023-11-02 16:06 ` redi at gcc dot gnu.org [this message]
2023-11-02 16:19 ` jdapena at igalia dot com
2023-11-02 17:37 ` redi at gcc dot gnu.org
2023-11-02 17:40 ` redi at gcc dot gnu.org
2023-11-08 13:18 ` cvs-commit at gcc dot gnu.org
2023-12-06 16:35 ` cvs-commit at gcc dot gnu.org
2023-12-06 21:01 ` cvs-commit at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-112314-4-sYNzQVVvzh@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).