[Bug c/112320] New: crash from insert_debug_temp_for_var_def

[Bug c/112320] New: crash from insert_debug_temp_for_var_def

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

            Bug ID: 112320
           Summary: crash from insert_debug_temp_for_var_def
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

This C code:

unsigned void0_effective_addr2;
void0_i, void0_m, void0_p2;
void0() {
  void0_m = 800 - (void0_effective_addr2 & 5);
  int b1;
  void0_i = 0;
  for (; void0_i < void0_m; void0_i++)
    b1++;
  void0_p2 = b1++;
}

when compiled by recent gcc trunk, does this:

$ ~/gcc/results/bin/gcc -c -w -g -O1 bug972.c
during GIMPLE pass: dse
bug972.c: In function ‘void0’:
bug972.c:3:1: internal compiler error: Segmentation fault
    3 | void0() {
      | ^~~~~
0xebbce9 crash_signal(int)
        ../../trunk.year/gcc/toplev.cc:315
0xaa2308 gsi_for_stmt(gimple*)
        ../../trunk.year/gcc/gimple-iterator.cc:0
0x11364ea insert_debug_temp_for_var_def(gimple_stmt_iterator*, tree_node*)
        ../../trunk.year/gcc/tree-ssa.cc:471

The bug first seems to occur sometime between g:8c40b72036c967fb
and g:9119b008b4195e06, which is 35 commits.

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0
            Summary|crash from                  |[14 Regression] crash from
                   |insert_debug_temp_for_var_d |insert_debug_temp_for_var_d
                   |ef                          |ef

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

David Binderman <dcb314 at hotmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenther at suse dot de

--- Comment #1 from David Binderman <dcb314 at hotmail dot com> ---
I have a reduction running. Current range is g:711d703d07c8e924
to g:e3da1d7bb288c8c8.

Reviewing those 4 revisions, I suspect Richard's commit
g:e3da1d7bb288c8c864f0284bc4bc5877b466a2f7

Adding Richard for their opinion.

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

--- Comment #2 from David Binderman <dcb314 at hotmail dot com> ---
As expected:

$ git bisect good 1cf5dc05c678232b
e3da1d7bb288c8c864f0284bc4bc5877b466a2f7 is the first bad commit
commit e3da1d7bb288c8c864f0284bc4bc5877b466a2f7
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Oct 31 10:13:13 2023 +0100

    tree-optimization/112305 - SCEV cprop and conditional undefined overflow

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slyfox at gcc dot gnu.org

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 112321 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |build
                 CC|                            |hp at gcc dot gnu.org
             Target|                            |cris-elf

--- Comment #4 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
What target?

Anyway, cris-elf too, where build of newlib fails.  (Same revision pin-pointed,
and the apparently-minimal posted test-case exposes the bug there too.  It
could theoretically be a different bug from the same commit, but I think
horses.)

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

[law at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

Jeffrey A. Law <law at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |law at gcc dot gnu.org
   Last reconfirmed|                            |2023-11-01
     Ever confirmed|0                           |1

--- Comment #5 from Jeffrey A. Law <law at gcc dot gnu.org> ---
I've bisected a failure on fr30-elf to the same commit.  The failure mode is
different, but given it's the same commit, I'm attaching the testcase to this
BZ.

0xba6a67 phi_nodes_ptr(basic_block_def*)
        /home/jlaw/test/gcc/gcc/gimple.h:4700
0xba6a67 gsi_start_phis(basic_block_def*)
        /home/jlaw/test/gcc/gcc/gimple-iterator.cc:935
0xba6a67 gsi_for_stmt(gimple*)
        /home/jlaw/test/gcc/gcc/gimple-iterator.cc:620
0xf477c1 replace_uses_by(tree_node*, tree_node*)
        /home/jlaw/test/gcc/gcc/tree-cfg.cc:2055
0x111b731 clean_up_loop_closed_phi(function*)
        /home/jlaw/test/gcc/gcc/tree-ssa-propagate.cc:1296
0xd23348 loop_optimizer_finalize(function*, bool)
        /home/jlaw/test/gcc/gcc/loop-init.cc:146
0x10e1448 tree_ssa_loop_done
        /home/jlaw/test/gcc/gcc/tree-ssa-loop.cc:478
0x10e1498 execute
        /home/jlaw/test/gcc/gcc/tree-ssa-loop.cc:507

Compile with -Os -g

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

[law at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

--- Comment #6 from Jeffrey A. Law <law at gcc dot gnu.org> ---
Created attachment 56480
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56480&action=edit
Testcase for fr30-elf -Os -g

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

--- Comment #7 from David Binderman <dcb314 at hotmail dot com> ---
(In reply to Hans-Peter Nilsson from comment #4)
> What target?

Sorry, I should have mentioned x86_64. 

In my opinion, bugs in the middle end tend to occur on all targets.

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zhendong.su at inf dot ethz.ch

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 112333 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gerald at pfeifer dot com

--- Comment #9 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 112343 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
             Status|NEW                         |ASSIGNED
            Version|unknown                     |14.0
           Priority|P3                          |P1

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
Mine.

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

--- Comment #11 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 112345 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

--- Comment #12 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 112328 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:c05f748218a0d556972212d6aecfce0eb4c8a31c

commit r14-5075-gc05f748218a0d556972212d6aecfce0eb4c8a31c
Author: Richard Biener <rguenther@suse.de>
Date:   Thu Nov 2 10:39:03 2023 +0100

    tree-optimization/112320 - bougs debug IL after SCCP

    The following addresses wrong debug IL created by SCCP rewriting stmts
    to defined overflow.  I addressed another inefficiency there but
    needed to adjust the API of rewrite_to_defined_overflow for this
    which is now taking a stmt iterator for in-place operation and a
    stmt for sequence producing because gsi_for_stmt doesn't work for
    stmts not in the IL.

            PR tree-optimization/112320
            * gimple-fold.h (rewrite_to_defined_overflow): New overload
            for in-place operation.
            * gimple-fold.cc (rewrite_to_defined_overflow): Add stmt
            iterator argument to worker, define separate API for
            in-place and not in-place operation.
            * tree-if-conv.cc (predicate_statements): Simplify.
            * tree-scalar-evolution.cc (final_value_replacement_loop):
            Likewise.
            * tree-ssa-ifcombine.cc (pass_tree_ifcombine::execute): Adjust.
            * tree-ssa-reassoc.cc (update_range_test): Likewise.

            * gcc.dg/pr112320.c: New testcase.

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #14 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.