[Bug tree-optimization/112369] New: [14 regression] ICE when building webkit-gtk with -march=raptorlake

[Bug tree-optimization/112369] New: [14 regression] ICE when building webkit-gtk with -march=raptorlake

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112369

            Bug ID: 112369
           Summary: [14 regression] ICE when building webkit-gtk with
                    -march=raptorlake
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sjames at gcc dot gnu.org
                CC: kocelfc at tutanota dot com
  Target Milestone: ---

Created attachment 56501
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56501&action=edit
ColorGtk.cpp.ii.xz

Originally reported downstream by Kostadin Shishmanov at
https://bugs.gentoo.org/916734.

Hit this with building webkit-gtk with -march=raptorlake.

```
# g++ -c -std=c++20 -march=raptorlake -O2 ColorGtk.cpp.ii
during GIMPLE pass: forwprop
/var/tmp/portage/net-libs/webkit-gtk-2.42.1-r410/work/webkitgtk-2.42.1/Source/WebCore/platform/graphics/gtk/ColorGtk.cpp:
In constructor ‘WebCore::Color::Color(const GdkRGBA&)’:
/var/tmp/portage/net-libs/webkit-gtk-2.42.1-r410/work/webkitgtk-2.42.1/Source/WebCore/platform/graphics/gtk/ColorGtk.cpp:28:1:
internal compiler error: tree check: expected none of vector_type, have
vector_type in strip_float_extensions, at tree.cc:12141
   28 | Color::Color(const GdkRGBA& color)
      | ^~~~~
0x56341e952ffd tree_not_check_failed(tree_node const*, char const*, int, char
const*, ...)
       
/usr/src/debug/sys-devel/gcc-14.0.0_pre20231029/gcc-14-20231029/gcc/tree.cc:8986
0x56341d8bcd08 tree_not_check(tree_node*, char const*, int, char const*,
tree_code)
       
/usr/src/debug/sys-devel/gcc-14.0.0_pre20231029/gcc-14-20231029/gcc/tree.h:3607
0x56341d8bcd08 strip_float_extensions(tree_node*)
       
/usr/src/debug/sys-devel/gcc-14.0.0_pre20231029/gcc-14-20231029/gcc/tree.cc:12141
0x56341f1da729 fold_binary_loc(unsigned int, tree_code, tree_node*, tree_node*,
tree_node*)
       
/usr/src/debug/sys-devel/gcc-14.0.0_pre20231029/gcc-14-20231029/gcc/fold-const.cc:12852
0x56341f5d9005 combine_cond_expr_cond
       
/usr/src/debug/sys-devel/gcc-14.0.0_pre20231029/gcc-14-20231029/gcc/tree-ssa-forwprop.cc:388
0x56341f55be0b forward_propagate_into_comparison_1
       
/usr/src/debug/sys-devel/gcc-14.0.0_pre20231029/gcc-14-20231029/gcc/tree-ssa-forwprop.cc:447
0x56341f4a6d11 forward_propagate_into_comparison
       
/usr/src/debug/sys-devel/gcc-14.0.0_pre20231029/gcc-14-20231029/gcc/tree-ssa-forwprop.cc:494
0x56341f4a6d11 execute
       
/usr/src/debug/sys-devel/gcc-14.0.0_pre20231029/gcc-14-20231029/gcc/tree-ssa-forwprop.cc:3978
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://bugs.gentoo.org/> for instructions.
```

```
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-pc-linux-gnu/14/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with:
/var/tmp/portage/sys-devel/gcc-14.0.0_pre20231029/work/gcc-14-20231029/configure
--host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/usr
--bindir=/usr/x86_64-pc-linux-gnu/gcc-bin/14
--includedir=/usr/lib/gcc/x86_64-pc-linux-gnu/14/include
--datadir=/usr/share/gcc-data/x86_64-pc-linux-gnu/14
--mandir=/usr/share/gcc-data/x86_64-pc-linux-gnu/14/man
--infodir=/usr/share/gcc-data/x86_64-pc-linux-gnu/14/info
--with-gxx-include-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/14/include/g++-v14
--disable-silent-rules --disable-dependency-tracking
--with-python-dir=/share/gcc-data/x86_64-pc-linux-gnu/14/python
--enable-languages=c,c++,fortran,rust --enable-obsolete --enable-secureplt
--disable-werror --with-system-zlib --enable-nls --without-included-gettext
--disable-libunwind-exceptions --enable-checking=yes,extra,rtl
--with-bugurl=https://bugs.gentoo.org/ --with-pkgversion='Gentoo Hardened
14.0.0_pre20231029 p7' --with-gcc-major-version-only --enable-libstdcxx-time
--enable-lto --disable-libstdcxx-pch --enable-shared --enable-threads=posix
--enable-__cxa_atexit --enable-clocale=gnu --enable-multilib
--with-multilib-list=m32,m64 --disable-fixed-point --enable-targets=all
--enable-libgomp --disable-libssp --disable-libada --enable-cet
--disable-systemtap --enable-valgrind-annotations --disable-vtable-verify
--disable-libvtv --with-zstd --with-isl --disable-isl-version-check
--enable-default-pie --enable-host-pie --enable-host-bind-now
--enable-default-ssp --with-build-config='bootstrap-O3 bootstrap-lto
bootstrap-cet'
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 14.0.0 20231029 (experimental) (Gentoo Hardened 14.0.0_pre20231029
p7)
```

[Bug tree-optimization/112369] [14 regression] ICE when building webkit-gtk with -march=raptorlake

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112369

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0
           Keywords|                            |needs-reduction

[Bug tree-optimization/112369] [14 regression] ICE when building webkit-gtk with -march=raptorlake

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112369

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Reducing ...

[Bug tree-optimization/112369] [14 regression] ICE when building webkit-gtk with -march=raptorlake

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112369

--- Comment #2 from Sam James <sjames at gcc dot gnu.org> ---
Created attachment 56504
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56504&action=edit
Hti5.cpp.ii

Kostadin started a reduction earlier and got this. It needs some cleaning up.

[Bug tree-optimization/112369] [14 regression] ICE when building webkit-gtk with -march=raptorlake

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112369

--- Comment #3 from Sam James <sjames at gcc dot gnu.org> ---
(In reply to Sam James from comment #2)
> Created attachment 56504 [details]
> Hti5.cpp.ii
> 
> Kostadin started a reduction earlier and got this. It needs some cleaning up.

btw, his was reduced from the same original problem but using a unity build
file

[Bug tree-optimization/112369] [14 regression] ICE when building webkit-gtk with -march=raptorlake

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112369

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Sam James from comment #3)
> (In reply to Sam James from comment #2)
> > Created attachment 56504 [details]
> > Hti5.cpp.ii
> > 
> > Kostadin started a reduction earlier and got this. It needs some cleaning up.
> 
> btw, his was reduced from the same original problem but using a unity build
> file

My reduction so far looks very similar.

[Bug tree-optimization/112369] [14 regression] ICE when building webkit-gtk with -march=raptorlake

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112369

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Keywords|needs-reduction             |ice-on-valid-code
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2023-11-03

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Reduced C (and C++) code:
```
struct GdkRGBA2 {
  double a[4];
};
struct GdkRGBA3 {
  float a[4];
};
struct GdkRGBA3 f(struct GdkRGBA2 *color) {
  struct GdkRGBA3 t1;
  for(int i = 0; i < 4; i++)
    t1.a[i] = color->a[i];
  struct GdkRGBA3 t2;
  for(int i = 0; i < 4; i++)
  {
    float tmp = t1.a[i];
    if (__builtin_isnan(tmp))
    t2.a[i] = tmp;
  }
  return t2;
}

```

It is related to unord folding with convert on a vector type.

[Bug tree-optimization/112369] [14 regression] ICE when building webkit-gtk with -march=raptorlake

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112369

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-checking
                 CC|                            |rguenth at gcc dot gnu.org

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Oh yes this is introduced by Richi's extra checking for TYPE_PRECISION .

From tree.cc:

  if (TYPE_PRECISION (subt) > TYPE_PRECISION (expt))
    return exp;

Maybe type_element_precision here ...

[Bug tree-optimization/112369] [14 regression] ICE when building webkit-gtk with -mavx

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112369

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[14 regression] ICE when    |[14 regression] ICE when
                   |building webkit-gtk with    |building webkit-gtk with
                   |-march=raptorlake           |-mavx

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
`-O2 -mavx` is enough to reproduce the failure too.

[Bug tree-optimization/112369] [14 regression] ICE when building webkit-gtk with -mavx

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112369

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
I will have a look.

[Bug tree-optimization/112369] [14 regression] ICE when building webkit-gtk with -mavx

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112369

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:d803438e0c4016aff720fad418377c5b13567063

commit r14-5145-gd803438e0c4016aff720fad418377c5b13567063
Author: Richard Biener <rguenther@suse.de>
Date:   Mon Nov 6 08:58:18 2023 +0100

    tree-optimization/112369 - strip_float_extensions and vectors

    The following fixes an error in strip_float_extensions when facing
    vector conversions.

            PR tree-optimization/112369
            * tree.cc (strip_float_extensions): Use element_precision.

            * gcc.dg/pr112369.c: New testcase.

[Bug tree-optimization/112369] [14 regression] ICE when building webkit-gtk with -mavx

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112369

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.