public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug testsuite/112376] New: [14 Regression] gcc.dg/tree-ssa/ssa-dom-thread-7.c was not adjusted for aarch64 case
@ 2023-11-04  6:24 pinskia at gcc dot gnu.org
  2023-11-04  6:24 ` [Bug testsuite/112376] " pinskia at gcc dot gnu.org
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-11-04  6:24 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112376

            Bug ID: 112376
           Summary: [14 Regression] gcc.dg/tree-ssa/ssa-dom-thread-7.c was
                    not adjusted for aarch64 case
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: testsuite-fail
          Severity: normal
          Priority: P3
         Component: testsuite
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---
            Target: aarch64

So after r13-1998-g409978d58dafa689c5b3f85013, the !aarch64 case was updated
but the aarch64 was not. I suspect the testcase just needs to be updated.

The testcase has:
```
/* aarch64 has the highest CASE_VALUES_THRESHOLD in GCC.  It's high enough
   to change decisions in switch expansion which in turn can expose new
   jump threading opportunities.  Skip the later tests on aarch64.  */
/* { dg-final { scan-tree-dump-not "Jumps threaded"  "dom3" { target { !
aarch64*-*-* } } } } */
/* { dg-final { scan-tree-dump "Jumps threaded: 9"  "thread2" { target { !
aarch64*-*-* } } } } */
/* { dg-final { scan-tree-dump "Jumps threaded: 18"  "thread2" { target {
aarch64*-*-* } } } } */
```

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug testsuite/112376] [14 Regression] gcc.dg/tree-ssa/ssa-dom-thread-7.c was not adjusted for aarch64 case
  2023-11-04  6:24 [Bug testsuite/112376] New: [14 Regression] gcc.dg/tree-ssa/ssa-dom-thread-7.c was not adjusted for aarch64 case pinskia at gcc dot gnu.org
@ 2023-11-04  6:24 ` pinskia at gcc dot gnu.org
  2024-02-15  7:55 ` [Bug tree-optimization/112376] [14 Regression] gcc.dg/tree-ssa/ssa-dom-thread-7.c missed threading in " tnfchris at gcc dot gnu.org
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-11-04  6:24 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112376

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug tree-optimization/112376] [14 Regression] gcc.dg/tree-ssa/ssa-dom-thread-7.c missed threading in aarch64 case
  2023-11-04  6:24 [Bug testsuite/112376] New: [14 Regression] gcc.dg/tree-ssa/ssa-dom-thread-7.c was not adjusted for aarch64 case pinskia at gcc dot gnu.org
  2023-11-04  6:24 ` [Bug testsuite/112376] " pinskia at gcc dot gnu.org
@ 2024-02-15  7:55 ` tnfchris at gcc dot gnu.org
  2024-03-07 21:03 ` law at gcc dot gnu.org
  2024-05-07  7:42 ` [Bug tree-optimization/112376] [14/15 " rguenth at gcc dot gnu.org
  3 siblings, 0 replies; 5+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2024-02-15  7:55 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112376

Tamar Christina <tnfchris at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2024-02-15
            Summary|[14 Regression]             |[14 Regression]
                   |gcc.dg/tree-ssa/ssa-dom-thr |gcc.dg/tree-ssa/ssa-dom-thr
                   |ead-7.c was not adjusted    |ead-7.c missed threading in
                   |for aarch64 case            |aarch64 case
     Ever confirmed|0                           |1
           Keywords|                            |missed-optimization
          Component|testsuite                   |tree-optimization
             Status|UNCONFIRMED                 |NEW
                 CC|                            |amacleod at redhat dot com,
                   |                            |tnfchris at gcc dot gnu.org

--- Comment #1 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
This is a jumpthreading regression caused by:

commit g:0cfc9c953d0221ec3971a25e6509ebe1041f142e
Author: Andrew MacLeod <amacleod@redhat.com>
Date:   Thu Aug 17 12:34:59 2023 -0400

    Phi analyzer - Initialize with range instead of a tree.

    Rangers PHI analyzer currently only allows a single initializer to a group.
    This patch changes that to use an inialization range, which is
    cumulative of all integer constants, plus a single symbolic value.
    There is no other change to group functionality.

    This patch also changes the way PHI groups are printed so they show up in
the
    listing as they are encountered, rather than as a list at the end.  It
    was more difficult to see what was going on previously.

We seem to miss one thread that we did previously in the testcase.  The new
code does look worse.

Jumpthreading is outside my wheelhouse for now, so any Ideas Andrew?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug tree-optimization/112376] [14 Regression] gcc.dg/tree-ssa/ssa-dom-thread-7.c missed threading in aarch64 case
  2023-11-04  6:24 [Bug testsuite/112376] New: [14 Regression] gcc.dg/tree-ssa/ssa-dom-thread-7.c was not adjusted for aarch64 case pinskia at gcc dot gnu.org
  2023-11-04  6:24 ` [Bug testsuite/112376] " pinskia at gcc dot gnu.org
  2024-02-15  7:55 ` [Bug tree-optimization/112376] [14 Regression] gcc.dg/tree-ssa/ssa-dom-thread-7.c missed threading in " tnfchris at gcc dot gnu.org
@ 2024-03-07 21:03 ` law at gcc dot gnu.org
  2024-05-07  7:42 ` [Bug tree-optimization/112376] [14/15 " rguenth at gcc dot gnu.org
  3 siblings, 0 replies; 5+ messages in thread
From: law at gcc dot gnu.org @ 2024-03-07 21:03 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112376

Jeffrey A. Law <law at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
                 CC|                            |law at gcc dot gnu.org

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug tree-optimization/112376] [14/15 Regression] gcc.dg/tree-ssa/ssa-dom-thread-7.c missed threading in aarch64 case
  2023-11-04  6:24 [Bug testsuite/112376] New: [14 Regression] gcc.dg/tree-ssa/ssa-dom-thread-7.c was not adjusted for aarch64 case pinskia at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2024-03-07 21:03 ` law at gcc dot gnu.org
@ 2024-05-07  7:42 ` rguenth at gcc dot gnu.org
  3 siblings, 0 replies; 5+ messages in thread
From: rguenth at gcc dot gnu.org @ 2024-05-07  7:42 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112376

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|14.0                        |14.2

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 14.1 is being released, retargeting bugs to GCC 14.2.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-05-07  7:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-04  6:24 [Bug testsuite/112376] New: [14 Regression] gcc.dg/tree-ssa/ssa-dom-thread-7.c was not adjusted for aarch64 case pinskia at gcc dot gnu.org
2023-11-04  6:24 ` [Bug testsuite/112376] " pinskia at gcc dot gnu.org
2024-02-15  7:55 ` [Bug tree-optimization/112376] [14 Regression] gcc.dg/tree-ssa/ssa-dom-thread-7.c missed threading in " tnfchris at gcc dot gnu.org
2024-03-07 21:03 ` law at gcc dot gnu.org
2024-05-07  7:42 ` [Bug tree-optimization/112376] [14/15 " rguenth at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).