[Bug bootstrap/112379] New: [14 Regression] bootstrap failure on --enable-checking=release: gcc/gcc-urlifier.cc:100:1: error: get_url_suffix_for_quoted_text() defined but not used [-Werror=unused-function]

[Bug bootstrap/112379] New: [14 Regression] bootstrap failure on --enable-checking=release: gcc/gcc-urlifier.cc:100:1: error: get_url_suffix_for_quoted_text() defined but not used [-Werror=unused-function]

[slyfox at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112379

            Bug ID: 112379
           Summary: [14 Regression] bootstrap failure on
                    --enable-checking=release: gcc/gcc-urlifier.cc:100:1:
                    error: get_url_suffix_for_quoted_text() defined but
                    not used [-Werror=unused-function]
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: slyfox at gcc dot gnu.org
  Target Milestone: ---

Noticed build failure on today's `gcc-master` checkout at
r14-5124-gada871cfadd3f4.

Reproducer:

$ ../gcc/configure --disable-multilib --enable-languages=c,c++
--enable-checking=release
$ make STAGE1_CFLAGS='-O1 -g0'

/tmp/gb/./prev-gcc/xg++ -B/tmp/gb/./prev-gcc/
-B/usr/local/x86_64-pc-linux-gnu/bin/ -nostdinc++
-B/tmp/gb/prev-x86_64-pc-linux-gnu/libstdc++-v3/src/.libs
-B/tmp/gb/prev-x86_64-pc-linux-gnu/libstdc++-v3/libsupc++/.libs 
-I/tmp/gb/prev-x86_64-pc-linux-gnu/libstdc++-v3/include/x86_64-pc-linux-gnu 
-I/tmp/gb/prev-x86_64-pc-linux-gnu/libstdc++-v3/include 
-I/home/slyfox/dev/git/gcc/libstdc++-v3/libsupc++
-L/tmp/gb/prev-x86_64-pc-linux-gnu/libstdc++-v3/src/.libs
-L/tmp/gb/prev-x86_64-pc-linux-gnu/libstdc++-v3/libsupc++/.libs  -fno-PIE -c  
-g -O2 -fno-checking -gtoggle -DIN_GCC    -fno-exceptions -fno-rtti
-fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wmissing-format-attribute -Wconditionally-supported
-Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros
-Wno-overlength-strings -Werror   -DHAVE_CONFIG_H -fno-PIE -I. -I.
-I/home/slyfox/dev/git/gcc/gcc -I/home/slyfox/dev/git/gcc/gcc/.
-I/home/slyfox/dev/git/gcc/gcc/../include 
-I/home/slyfox/dev/git/gcc/gcc/../libcpp/include
-I/home/slyfox/dev/git/gcc/gcc/../libcody 
-I/home/slyfox/dev/git/gcc/gcc/../libdecnumber
-I/home/slyfox/dev/git/gcc/gcc/../libdecnumber/bid -I../libdecnumber
-I/home/slyfox/dev/git/gcc/gcc/../libbacktrace   -o gcc-urlifier.o -MT
gcc-urlifier.o -MMD -MP -MF ./.deps/gcc-urlifier.TPo
/home/slyfox/dev/git/gcc/gcc/gcc-urlifier.cc
/home/slyfox/dev/git/gcc/gcc/gcc-urlifier.cc:100:1: error: 'const char*
{anonymous}::gcc_urlifier::get_url_suffix_for_quoted_text(const char*) const'
defined but not used [-Werror=unused-function]
  100 | gcc_urlifier::get_url_suffix_for_quoted_text (const char *p) const
      | ^~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[3]: *** [Makefile:1195: gcc-urlifier.o] Error 1
make[3]: Leaving directory '/tmp/gb/gcc'
make[2]: *** [Makefile:5054: all-stage2-gcc] Error 2
make[2]: Leaving directory '/tmp/gb'
make[1]: *** [Makefile:26048: stage2-bubble] Error 2
make[1]: Leaving directory '/tmp/gb'
make: *** [Makefile:1094: all] Error 2

I suspect it's the effect of r14-5118-gc5db4d8ba5f3de "diagnostics: add
automatic URL-ification within messages".

$ prev-gcc/xg++ -Bprev-gcc -v
Reading specs from prev-gcc/specs
COLLECT_GCC=prev-gcc/xg++
COLLECT_LTO_WRAPPER=prev-gcc/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /home/slyfox/dev/git/gcc/configure --disable-multilib
--enable-languages=c,c++ --enable-checking=release
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 14.0.0 20231104 (experimental) (GCC)

[Bug bootstrap/112379] [14 Regression] bootstrap failure on --enable-checking=release: gcc/gcc-urlifier.cc:100:1: error: get_url_suffix_for_quoted_text() defined but not used [-Werror=unused-function]

[slyfox at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112379

--- Comment #1 from Sergei Trofimovich <slyfox at gcc dot gnu.org> ---
Proposed trivial fix by marking helper as `ATTRIBUTE_UNUSED`:
https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635194.html

[Bug bootstrap/112379] [14 Regression] bootstrap failure on --enable-checking=release: gcc/gcc-urlifier.cc:100:1: error: get_url_suffix_for_quoted_text() defined but not used [-Werror=unused-function]

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112379

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Sergei Trofimovich <slyfox@gcc.gnu.org>:

https://gcc.gnu.org/g:9eef85a0276a0a118b76ce2da00861b75e9a3012

commit r14-5125-g9eef85a0276a0a118b76ce2da00861b75e9a3012
Author: Sergei Trofimovich <siarheit@google.com>
Date:   Sat Nov 4 16:18:02 2023 +0000

    diagnostics: fix gcc-urlifier.cc bootstrap failure [PR112379]

    Without the change `./configure --enable-checking=release` bootstrap
    fails as:

        gcc/gcc-urlifier.cc:100:1: error: 'get_url_suffix_for_quoted_text()'
            defined but not used [-Werror=unused-function]

    This happens because the helper is used only in `ASSERT` macros which
    don't always get expanded to executable code.

    The fix marks helper function with `ATTRIBUTE_UNUSED`.

    gcc/
            PR bootstrap/112379
            * gcc-urlifier.cc (get_url_suffix_for_quoted_text): Mark as
            ATTRIBUTE_UNUSED.

[Bug bootstrap/112379] [14 Regression] bootstrap failure on --enable-checking=release: gcc/gcc-urlifier.cc:100:1: error: get_url_suffix_for_quoted_text() defined but not used [-Werror=unused-function]

[slyfox at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112379

Sergei Trofimovich <slyfox at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #3 from Sergei Trofimovich <slyfox at gcc dot gnu.org> ---
Should be fixed now.