public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libbacktrace/112396] New: "make check" should not error out, even when some checks failed
@ 2023-11-05 20:32 fxcoudert at gcc dot gnu.org
  2023-11-05 20:37 ` [Bug libbacktrace/112396] " pinskia at gcc dot gnu.org
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: fxcoudert at gcc dot gnu.org @ 2023-11-05 20:32 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112396

            Bug ID: 112396
           Summary: "make check" should not error out, even when some
                    checks failed
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libbacktrace
          Assignee: unassigned at gcc dot gnu.org
          Reporter: fxcoudert at gcc dot gnu.org
                CC: ian at gcc dot gnu.org
  Target Milestone: ---

The behaviour in GCC is pretty consistent: parts of the testsuite do not error
out in make, even when individual tests fail.

The one exception is libbacktrace, which does error out when one or more test
failed:

make[4]: *** [test-suite.log] Error 1
make[3]: *** [check-TESTS] Error 2
make[2]: *** [check-am] Error 2
make[2]: Target `check' not remade because of errors.
make[1]: *** [check-target-libbacktrace] Error 2

This means that if, like me, you forgot to run "make check" with -k, you get
stopped in the middle of testing. To be nice to users, and for consistency, it
would be nice if this behaviour was changed.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libbacktrace/112396] "make check" should not error out, even when some checks failed
  2023-11-05 20:32 [Bug libbacktrace/112396] New: "make check" should not error out, even when some checks failed fxcoudert at gcc dot gnu.org
@ 2023-11-05 20:37 ` pinskia at gcc dot gnu.org
  2023-11-06  1:17 ` egallager at gcc dot gnu.org
  2023-11-06  1:49 ` ian at airs dot com
  2 siblings, 0 replies; 4+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-11-05 20:37 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112396

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
https://gcc.gnu.org/install/test.html

Even mentions -k option for a long time.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libbacktrace/112396] "make check" should not error out, even when some checks failed
  2023-11-05 20:32 [Bug libbacktrace/112396] New: "make check" should not error out, even when some checks failed fxcoudert at gcc dot gnu.org
  2023-11-05 20:37 ` [Bug libbacktrace/112396] " pinskia at gcc dot gnu.org
@ 2023-11-06  1:17 ` egallager at gcc dot gnu.org
  2023-11-06  1:49 ` ian at airs dot com
  2 siblings, 0 replies; 4+ messages in thread
From: egallager at gcc dot gnu.org @ 2023-11-06  1:17 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112396

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |egallager at gcc dot gnu.org

--- Comment #2 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #1)
> https://gcc.gnu.org/install/test.html
> 
> Even mentions -k option for a long time.

Still, it's kind of inconvenient having to do it that way, though. I think this
is an aspect of the testsuite worth changing.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libbacktrace/112396] "make check" should not error out, even when some checks failed
  2023-11-05 20:32 [Bug libbacktrace/112396] New: "make check" should not error out, even when some checks failed fxcoudert at gcc dot gnu.org
  2023-11-05 20:37 ` [Bug libbacktrace/112396] " pinskia at gcc dot gnu.org
  2023-11-06  1:17 ` egallager at gcc dot gnu.org
@ 2023-11-06  1:49 ` ian at airs dot com
  2 siblings, 0 replies; 4+ messages in thread
From: ian at airs dot com @ 2023-11-06  1:49 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112396

Ian Lance Taylor <ian at airs dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ian at airs dot com

--- Comment #3 from Ian Lance Taylor <ian at airs dot com> ---
libbacktrace is just using automake and its testsuite support.  Anybody know if
there is a way to tell automake not to exit 1 on test failure?

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-11-06  1:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-05 20:32 [Bug libbacktrace/112396] New: "make check" should not error out, even when some checks failed fxcoudert at gcc dot gnu.org
2023-11-05 20:37 ` [Bug libbacktrace/112396] " pinskia at gcc dot gnu.org
2023-11-06  1:17 ` egallager at gcc dot gnu.org
2023-11-06  1:49 ` ian at airs dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).