[Bug tree-optimization/112404] New: [14 Regression] 521.wrf_r fails to build with internal compiler error: in get_vectype_for_scalar_type, at tree-vect-stmts.cc:13311

[Bug tree-optimization/112404] New: [14 Regression] 521.wrf_r fails to build with internal compiler error: in get_vectype_for_scalar_type, at tree-vect-stmts.cc:13311

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112404

            Bug ID: 112404
           Summary: [14 Regression] 521.wrf_r fails to build with internal
                    compiler error: in get_vectype_for_scalar_type, at
                    tree-vect-stmts.cc:13311
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rguenth at gcc dot gnu.org
  Target Milestone: ---

On x86_64-linux with -Ofast -march=znver4:

/space/rguenther/install/trunk-r14-5145-vecupdate/usr/local/bin/gfortran -c -o
module_fdda_psufddagd.fppized.o -I. -I./netcdf/include -I./inc -Ofast
-march=znver4 -std=legacy -fconvert=big-endian -fno-openmp -g0
module_fdda_psufddagd.fppized.f90 
during GIMPLE pass: slp
module_fdda_psufddagd.fppized.f90:553:21:
  553 |    SUBROUTINE sfddagd(itimestep,dx,dt,xtime,  &
      |                     ^
internal compiler error: in get_vectype_for_scalar_type, at
tree-vect-stmts.cc:13311
0x2037204 get_vectype_for_scalar_type(vec_info*, tree_node*, unsigned int)
        /space/rguenther/src/gcc11queue/gcc/tree-vect-stmts.cc:13311
0x2045fb8 get_mask_type_for_scalar_type(vec_info*, tree_node*, unsigned int)
        /space/rguenther/src/gcc11queue/gcc/tree-vect-stmts.cc:13381
0x2046222 vect_check_scalar_mask
        /space/rguenther/src/gcc11queue/gcc/tree-vect-stmts.cc:2459
0x2046802 vectorizable_load
        /space/rguenther/src/gcc11queue/gcc/tree-vect-stmts.cc:9853
0x205b112 vect_analyze_stmt(vec_info*, _stmt_vec_info*, bool*, _slp_tree*,
_slp_instance*, vec<stmt_info_for_cost, va_heap, vl_ptr>*)
        /space/rguenther/src/gcc11queue/gcc/tree-vect-stmts.cc:12954
0x1298b85 vect_slp_analyze_node_operations_1
        /space/rguenther/src/gcc11queue/gcc/tree-vect-slp.cc:6141

going to reduce.

[Bug tree-optimization/112404] [14 Regression] 521.wrf_r fails to build with internal compiler error: in get_vectype_for_scalar_type, at tree-vect-stmts.cc:13311

[tnfchris at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112404

Tamar Christina <tnfchris at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-11-6
                 CC|                            |tnfchris at gcc dot gnu.org

--- Comment #1 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Same failure on AArch64 with SVE.

[Bug tree-optimization/112404] [14 Regression] 521.wrf_r fails to build with internal compiler error: in get_vectype_for_scalar_type, at tree-vect-stmts.cc:13311

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112404

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Target Milestone|---                         |14.0
             Status|UNCONFIRMED                 |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Mine.

   SUBROUTINE sfddagd( regime, znt                           ,ite ,jte )
   REAL,     DIMENSION( ime, IN)       ::                       regime, znt
   REAL, DIMENSION( ite, jte)                 :: wndcor_u 
   LOGICAL wrf_dm_on_monitor
   IF( int4 == 1 ) THEN
     DO j=jts,jtf
     DO i=itsu,itf
       reg =   regime(i-1,  j) 
       IF( reg > 10.0 ) THEN
         znt0 =     znt(i-1,  j) +    znt(i,  j) 
         IF( znt0 <= 0.2) THEN
           wndcor_u(i,j) = 0.2
         ENDIF
       ENDIF
     ENDDO
     ENDDO
     IF ( wrf_dm_on_monitor()) THEN
       ENDIF
   ENDIF
   END

[Bug tree-optimization/112404] [14 Regression] 521.wrf_r fails to build with internal compiler error: in get_vectype_for_scalar_type, at tree-vect-stmts.cc:13311

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112404

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Two issues, a simple omission where the ICE occurs and then failure to compute
alignment info for SLP of .MASK_LOAD because SLP_INSTANCE_LOADS doesn't
contain them.  Oops.

[Bug tree-optimization/112404] [14 Regression] 521.wrf_r fails to build with internal compiler error: in get_vectype_for_scalar_type, at tree-vect-stmts.cc:13311

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112404

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:3cc9ad41db87fb85b13a56bff1f930c258542a70

commit r14-5154-g3cc9ad41db87fb85b13a56bff1f930c258542a70
Author: Richard Biener <rguenther@suse.de>
Date:   Mon Nov 6 12:43:11 2023 +0100

    tree-optimization/112404 - two issues with SLP of .MASK_LOAD

    The following fixes an oversight in vect_check_scalar_mask when
    the mask is external or constant.  When doing BB vectorization
    we need to provide a group_size, best via an overload accepting
    the SLP node as argument.

    When fixed we then run into the issue that we have not analyzed
    alignment of the .MASK_LOADs because they were not identified
    as loads by vect_gather_slp_loads.  Fixed by reworking the
    detection.

            PR tree-optimization/112404
            * tree-vectorizer.h (get_mask_type_for_scalar_type): Declare
            overload with SLP node argument.
            * tree-vect-stmts.cc (get_mask_type_for_scalar_type): Implement it.
            (vect_check_scalar_mask): Use it.
            * tree-vect-slp.cc (vect_gather_slp_loads): Properly identify
            loads also for nodes with children, like .MASK_LOAD.
            * tree-vect-loop.cc (vect_analyze_loop_2): Look at the
            representative for load nodes and check whether it is a grouped
            access before looking for load-lanes support.

            * gfortran.dg/pr112404.f90: New testcase.

[Bug tree-optimization/112404] [14 Regression] 521.wrf_r fails to build with internal compiler error: in get_vectype_for_scalar_type, at tree-vect-stmts.cc:13311

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112404

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.

[Bug tree-optimization/112404] [14 Regression] 521.wrf_r fails to build with internal compiler error: in get_vectype_for_scalar_type, at tree-vect-stmts.cc:13311

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112404

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |crazylht at gmail dot com

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 111859 has been marked as a duplicate of this bug. ***