[Bug libstdc++/112453] New: <ranges>: __take_of_repeat_view/__drop_of_repeat_view should forwards __r._M_value

[Bug libstdc++/112453] New: <ranges>: __take_of_repeat_view/__drop_of_repeat_view should forwards __r._M_value

[hewillk at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112453

            Bug ID: 112453
           Summary: <ranges>: __take_of_repeat_view/__drop_of_repeat_view
                    should forwards __r._M_value
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hewillk at gmail dot com
  Target Milestone: ---

The current wording clearly indicates *E.value_ instead of *r.value_.

https://godbolt.org/z/GcnbesbEE

#include <ranges>
#include <memory>

int main() {
  auto t = std::views::repeat(std::make_unique<int>(5), 4) |
std::views::take(2);
  auto d = std::views::repeat(std::make_unique<int>(5), 4) |
std::views::drop(2);
}

[Bug libstdc++/112453] <ranges>: __take_of_repeat_view/__drop_of_repeat_view should forwards __r._M_value

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112453

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.3
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2023-11-09
           Keywords|                            |rejects-valid
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |ppalka at gcc dot gnu.org

--- Comment #1 from Patrick Palka <ppalka at gcc dot gnu.org> ---
Confirmed, thanks for catching and reporting this.

[Bug libstdc++/112453] <ranges>: __take_of_repeat_view/__drop_of_repeat_view should forwards __r._M_value

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112453

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:d63282fa5b587f1b994210212f236b998a332995

commit r14-5297-gd63282fa5b587f1b994210212f236b998a332995
Author: Patrick Palka <ppalka@redhat.com>
Date:   Thu Nov 9 15:15:08 2023 -0500

    libstdc++: Fix forwarding in __take/drop_of_repeat_view [PR112453]

    We need to respect the value category of the repeat_view passed to these
    two functions when accessing the view's _M_value member.  This revealed
    that the space-efficient partial specialization of __box lacks && overloads
    of operator* to match those of the primary template (inherited from
    std::optional).

            PR libstdc++/112453

    libstdc++-v3/ChangeLog:

            * include/std/ranges (__detail::__box<_Tp>::operator*): Define
            && overloads as well.
            (__detail::__take_of_repeat_view): Forward __r when accessing
            its _M_value member.
            (__detail::__drop_of_repeat_view): Likewise.
            * testsuite/std/ranges/repeat/1.cc (test07): New test.

    Reviewed-by: Jonathan Wakely <jwakely@redhat.com>

[Bug libstdc++/112453] <ranges>: __take_of_repeat_view/__drop_of_repeat_view should forwards __r._M_value

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112453

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|13.3                        |13.4

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 13.3 is being released, retargeting bugs to GCC 13.4.