[Bug tree-optimization/112536] New: [14 regression] ICE when buliding xorg-server on arm64 (internal compiler error: in vect_slp_analyze_node_operations, at tree-vect-slp.cc:6378)

[Bug tree-optimization/112536] New: [14 regression] ICE when buliding xorg-server on arm64 (internal compiler error: in vect_slp_analyze_node_operations, at tree-vect-slp.cc:6378)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112536

            Bug ID: 112536
           Summary: [14 regression] ICE when buliding xorg-server on arm64
                    (internal compiler error: in
                    vect_slp_analyze_node_operations, at
                    tree-vect-slp.cc:6378)
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sjames at gcc dot gnu.org
  Target Milestone: ---

```
FAILED: hw/xfree86/common/libxorg_common.a.p/xf86Helper.c.o
aarch64-unknown-linux-gnu-gcc -Ihw/xfree86/common/libxorg_common.a.p
-Ihw/xfree86/common -I../xorg-server-21.1.9/hw/xfree86/common -IXext
-I../xorg-server-21.1.9/Xext -IXi -I../xorg-server-21.1.9/Xi -Icomposite
-I../xorg-server-21.1.9/composite -Idamageext -I../xorg-server-21.1.9/damageext
-Iexa -I../xorg-server-21.1.9/exa -Ifb -I../xorg-server-21.1.9/fb -Iglamor
-I../xorg-server-21.1.9/glamor -Imi -I../xorg-server-21.1.9/mi -Imiext/damage
-I../xorg-server-21.1.9/miext/damage -Imiext/shadow
-I../xorg-server-21.1.9/miext/shadow -Imiext/sync
-I../xorg-server-21.1.9/miext/sync -Idbe -I../xorg-server-21.1.9/dbe -Idri3
-I../xorg-server-21.1.9/dri3 -Iinclude -I../xorg-server-21.1.9/include
-Ipresent -I../xorg-server-21.1.9/present -Irandr -I../xorg-server-21.1.9/randr
-Irender -I../xorg-server-21.1.9/render -Ixfixes -I../xorg-server-21.1.9/xfixes
-Ihw/xfree86/ddc -I../xorg-server-21.1.9/hw/xfree86/ddc -Ihw/xfree86/dri2
-I../xorg-server-21.1.9/hw/xfree86/dri2 -Ihw/xfree86/i2c
-I../xorg-server-21.1.9/hw/xfree86/i2c -Ihw/xfree86/int1
0 -I../xorg-server-21.1.9/hw/xfree86/int10 -Ihw/xfree86/loader
-I../xorg-server-21.1.9/hw/xfree86/loader -Ihw/xfree86/modes
-I../xorg-server-21.1.9/hw/xfree86/modes -Ihw/xfree86/os-support
-I../xorg-server-21
.1.9/hw/xfree86/os-support -I../xorg-server-21.1.9/hw/xfree86/os-support/bus
-Ihw/xfree86/parser -I../xorg-server-21.1.9/hw/xfree86/parser
-Ihw/xfree86/ramdac -I../xorg-server-21.1.9/hw/xfree86/ramdac -Ihw/xf
ree86/vgahw -I../xorg-server-21.1.9/hw/xfree86/vgahw -I.
-I../xorg-server-21.1.9 -I/usr/include/X11/dri -I/usr/include/pixman-1
-I/usr/include/freetype2 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include
-
I/usr/include/libdrm -fdiagnostics-color=always -DNDEBUG -D_FILE_OFFSET_BITS=64
-Wall -Winvalid-pch -std=gnu99 -DHAVE_DIX_CONFIG_H -fno-strict-aliasing
-fvisibility=hidden -Wall -Wpointer-arith -Wmissing-decl
arations -Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs
-Wbad-function-cast -Wold-style-definition -Wunused -Wuninitialized -Wshadow
-Wmissing-noreturn -Wmissing-format-attribute -Wredun
dant-decls -Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main
-Werror=missing-braces -Werror=sequence-point -Werror=return-type
-Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werro
r=address -Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -O3 -pipe
-mcpu=native -fdiagnostics-color=always -ggdb3 -fPIC -isystem /usr/include/bsd
-DLIBBSD_OVERLAY -D_DEFAULT_SOURCE -D_BSD_SOURCE -DHA
S_FCHOWN -DHAS_STICKY_DIR_BIT -DHAVE_XORG_CONFIG_H -DXORG_NO_SDKSYMS
'-DFALLBACK_INPUT_DRIVER="libinput"' -MD -MQ
hw/xfree86/common/libxorg_common.a.p/xf86Helper.c.o -MF
hw/xfree86/common/libxorg_common.a.p/x
f86Helper.c.o.d -o hw/xfree86/common/libxorg_common.a.p/xf86Helper.c.o -c
../xorg-server-21.1.9/hw/xfree86/common/xf86Helper.c
during GIMPLE pass: slp
../xorg-server-21.1.9/hw/xfree86/common/xf86Helper.c: In function
‘xf86SetWeight’:
../xorg-server-21.1.9/hw/xfree86/common/xf86Helper.c:642:1: internal compiler
error: in vect_slp_analyze_node_operations, at tree-vect-slp.cc:6378
  642 | xf86SetWeight(ScrnInfoPtr scrp, rgb weight, rgb mask)
      | ^~~~~~~~~~~~~
0xaaaae0cc2897 vect_slp_analyze_node_operations
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-vect-slp.cc:6378
0xaaaae0cc209f vect_slp_analyze_node_operations
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-vect-slp.cc:6320
0xaaaae07c8b73 vect_slp_analyze_operations(vec_info*)
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-vect-slp.cc:6592
0xaaaae0592dbf vect_slp_analyze_bb_1
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-vect-slp.cc:7596
0xaaaae0592dbf vect_slp_region
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-vect-slp.cc:7643
0xaaaae058f48b vect_slp_bbs
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-vect-slp.cc:7851
0xaaaae058e6e3 vect_slp_function(function*)
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-vect-slp.cc:7973
0xaaaae058e0ef execute
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-vectorizer.cc:1531
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://bugs.gentoo.org/> for instructions.
```

```
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/aarch64-unknown-linux-gnu/14/lto-wrapper
Target: aarch64-unknown-linux-gnu
Configured with:
/var/tmp/portage/sys-devel/gcc-14.0.0.9999/work/gcc-14.0.0.9999/configure
--host=aarch64-unknown-linux-gnu --build=aarch64-unknown-linux-gnu
--prefix=/usr --bindir=/usr/aarch64-unknown-linux-gnu/gcc-bin/14
--includedir=/usr/lib/gcc/aarch64-unknown-linux-gnu/14/include
--datadir=/usr/share/gcc-data/aarch64-unknown-linux-gnu/14
--mandir=/usr/share/gcc-data/aarch64-unknown-linux-gnu/14/man
--infodir=/usr/share/gcc-data/aarch64-unknown-linux-gnu/14/info
--with-gxx-include-dir=/usr/lib/gcc/aarch64-unknown-linux-gnu/14/include/g++-v14
--disable-silent-rules --disable-dependency-tracking
--with-python-dir=/share/gcc-data/aarch64-unknown-linux-gnu/14/python
--enable-languages=c,c++,fortran --enable-obsolete --enable-secureplt
--disable-werror --with-system-zlib --enable-nls --without-included-gettext
--disable-libunwind-exceptions --enable-checking=yes,extra,rtl
--with-bugurl=https://bugs.gentoo.org/ --with-pkgversion='Gentoo Hardened
14.0.0 p, commit 35bb529f420ff5863fdae51049e6935ab927ff3d'
--with-gcc-major-version-only --enable-libstdcxx-time --enable-lto
--disable-libstdcxx-pch --enable-shared --enable-threads=posix
--enable-__cxa_atexit --enable-clocale=gnu --disable-multilib
--disable-fixed-point --enable-libgomp --disable-libssp --disable-libada
--disable-cet --disable-systemtap --disable-valgrind-annotations
--disable-vtable-verify --disable-libvtv --with-zstd --without-isl
--enable-default-pie --enable-host-pie --enable-host-bind-now
--enable-default-ssp --with-build-config='bootstrap-O3 bootstrap-lto'
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 14.0.0 20231114 (experimental)
b42a09b258c3ed8d1368e0ef0948034dcf0f8ac9 (Gentoo Hardened 14.0.0 p, commit
35bb529f420ff5863fdae51049e6935ab927ff3d)
```

'gcc -c xf86Helper.c.i -O2' is enough for me to reproduce.

[Bug tree-optimization/112536] [14 regression] ICE when buliding xorg-server on arm64 (internal compiler error: in vect_slp_analyze_node_operations, at tree-vect-slp.cc:6378)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112536

--- Comment #1 from Sam James <sjames at gcc dot gnu.org> ---
Created attachment 56588
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56588&action=edit
xf86Helper.c.i

[Bug tree-optimization/112536] [14 regression] ICE when buliding xorg-server on arm64 (internal compiler error: in vect_slp_analyze_node_operations, at tree-vect-slp.cc:6378)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112536

--- Comment #2 from Sam James <sjames at gcc dot gnu.org> ---
I'm going to kick off cvise for this. I've also had probably a dupe with zstd
but I may reduce that too given both projects are C so it should be quick.

[Bug tree-optimization/112536] [14 regression] ICE when buliding xorg-server on arm64 (internal compiler error: in vect_slp_analyze_node_operations, at tree-vect-slp.cc:6378)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112536

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0

[Bug tree-optimization/112536] [14 regression] ICE when buliding xorg-server on arm64 (internal compiler error: in vect_slp_analyze_node_operations, at tree-vect-slp.cc:6378)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112536

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Worked at r14-5115-g6e9ee44d96e5bda8808dd9d8ccf58d2525383f6b .

[Bug tree-optimization/112536] [14 regression] ICE when buliding xorg-server on arm64 (internal compiler error: in vect_slp_analyze_node_operations, at tree-vect-slp.cc:6378)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112536

--- Comment #4 from Sam James <sjames at gcc dot gnu.org> ---
Reduced:
```
typedef struct {
  int green, blue;
} rgb;

struct {
  rgb offset;
} xf86SetWeight_scrp;

rgb xf86SetWeight_mask;

int ffs(int color);

void xf86SetWeight() {
  xf86SetWeight_scrp.offset.green = ffs(xf86SetWeight_mask.green) - 1;
  xf86SetWeight_scrp.offset.blue = ffs(xf86SetWeight_mask.blue) - 1;
}
```

[Bug tree-optimization/112536] [14 regression] ICE when buliding xorg-server on arm64 (internal compiler error: in vect_slp_analyze_node_operations, at tree-vect-slp.cc:6378)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112536

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-11-15
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed, a little more reduced:
```
typedef struct {
 unsigned g, b;
} rgb;
void f(rgb *offset , rgb mask) {
  offset->g = __builtin_ffs(mask.g) - 1;
  offset->b = __builtin_ffs(mask.b) - 1;
}
```

[Bug tree-optimization/112536] [14 regression] ICE when buliding xorg-server on arm64 (internal compiler error: in vect_slp_analyze_node_operations, at tree-vect-slp.cc:6378)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112536

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |pinskia at gcc dot gnu.org

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
manually bisected to r14-5435-g7383cb56e11707 .

[Bug tree-optimization/112536] [14 regression] ICE when buliding xorg-server on arm64 (internal compiler error: in vect_slp_analyze_node_operations, at tree-vect-slp.cc:6378)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112536

--- Comment #7 from Sam James <sjames at gcc dot gnu.org> ---
Here's the zstd testcase with clz instead too:
```
unsigned a, b, minTableLog_srcSize;

unsigned FSE_minTableLog_srcSize(unsigned maxSymbolValue) {
  minTableLog_srcSize = __builtin_clz(a);
  b = -minTableLog_srcSize;
  int minBitsSrc = b + 1;

  minTableLog_srcSize = __builtin_clz(maxSymbolValue);
  a = -minTableLog_srcSize;
  int minBitsSymbols = a + 2;

  int minBits = minBitsSrc < minBitsSymbols ? minBitsSrc : minBitsSymbols;
  return minBits;
}
```

[Bug tree-optimization/112536] [14 regression] ICE when building xorg-server on arm64 (internal compiler error: in vect_slp_analyze_node_operations, at tree-vect-slp.cc:6378) since r14-5435-g7383cb56e11707

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112536

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
unsigned a[4];

void
foo (void)
{
  int i = a[0];
  int j = a[1];
  int k = a[2];
  int l = a[3];
  int e = i ? __builtin_clz (i) : __SIZEOF_INT__ * __CHAR_BIT__;
  int f = j ? __builtin_clz (j) : __SIZEOF_INT__ * __CHAR_BIT__;
  int g = k ? __builtin_clz (k) : __SIZEOF_INT__ * __CHAR_BIT__;
  int h = l ? __builtin_clz (l) : __SIZEOF_INT__ * __CHAR_BIT__;
  a[0] = e;
  a[1] = f;
  a[2] = g;
  a[3] = h;
}

ICEs on x86_64-linux as well with -mlzcnt -mavx512cd -mavx512vl

[Bug tree-optimization/112536] [14 regression] ICE when building xorg-server on arm64 (internal compiler error: in vect_slp_analyze_node_operations, at tree-vect-slp.cc:6378) since r14-5435-g7383cb56e11707

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112536

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 56591
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56591&action=edit
gcc14-pr112536.patch

Untested fix.

[Bug tree-optimization/112536] [14 regression] ICE when building xorg-server on arm64 (internal compiler error: in vect_slp_analyze_node_operations, at tree-vect-slp.cc:6378) since r14-5435-g7383cb56e11707

[manuel.lauss at googlemail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112536

--- Comment #10 from Manuel Lauss <manuel.lauss at googlemail dot com> ---
(In reply to Jakub Jelinek from comment #9)
> Created attachment 56591 [details]
> gcc14-pr112536.patch
> 
> Untested fix.


It does fix the ICE I saw with mesa (avx512)

Thanks!

[Bug tree-optimization/112536] [14 regression] ICE when building xorg-server on arm64 (internal compiler error: in vect_slp_analyze_node_operations, at tree-vect-slp.cc:6378) since r14-5435-g7383cb56e11707

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112536

--- Comment #11 from Sam James <sjames at gcc dot gnu.org> ---
Reduced from llvm:
```
void swap() {
  unsigned Defs, Kills;
  while (Kills && Defs) {
    int __trans_tmp_3 = __builtin_ctz(Kills);
    unsigned KReg = __builtin_ctz(Defs), DReg = __trans_tmp_3;
    swap();
    Kills &= ~(1 << KReg);
    Defs &= ~(1 << DReg);
  }
}
```

[Bug tree-optimization/112536] [14 regression] ICE when building xorg-server on arm64 (internal compiler error: in vect_slp_analyze_node_operations, at tree-vect-slp.cc:6378) since r14-5435-g7383cb56e11707

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112536

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:9f35d8cd767155e9c24f5ef0944168711d38bc6b

commit r14-5518-g9f35d8cd767155e9c24f5ef0944168711d38bc6b
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Nov 16 08:32:24 2023 +0100

    slp: Fix handling of IFN_CLZ/CTZ [PR112536]

    We ICE on the following testcase now that IFN_C[LT]Z calls can have one or
    two arguments (where 2 mean it is well defined at zero).
    The following patch makes us create child node only for the first argument
    and compatible_calls_p ensures the other argument is the same, which
    at least according to the testcase seems sufficient because of vect
    patterns.

    2023-11-16  Jakub Jelinek  <jakub@redhat.com>

            PR tree-optimization/112536
            * tree-vect-slp.cc (arg0_map): New variable.
            (vect_get_operand_map): For IFN_CLZ or IFN_CTZ, return arg0_map.

            * gcc.dg/pr112536.c: New test.

[Bug tree-optimization/112536] [14 regression] ICE when building xorg-server on arm64 (internal compiler error: in vect_slp_analyze_node_operations, at tree-vect-slp.cc:6378) since r14-5435-g7383cb56e11707

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112536

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Should be fixed now.