[Bug libstdc++/112564] New: std::format(std::thread::id) is incorrectly left-aligned

[Bug libstdc++/112564] New: std::format(std::thread::id) is incorrectly left-aligned

[blubban at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112564

            Bug ID: 112564
           Summary: std::format(std::thread::id) is incorrectly
                    left-aligned
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: blubban at gmail dot com
  Target Milestone: ---

https://godbolt.org/z/zra9GddY3

N4964 [thread.thread.id]/12 "If the align option is omitted it defaults to >."
Both MSVC and libc++ right-align thread::id here as mandated by that paragraph,
but libstdc++ is left-aligning.

I am not sure how duration should be aligned by default but either libstdc++ or
libc++ are buggy here.


Found by https://github.com/StephanTLavavej

[Bug libstdc++/112564] std::format(std::thread::id) is incorrectly left-aligned

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112564

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-11-16
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org
   Target Milestone|---                         |13.3
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED

[Bug libstdc++/112564] std::format(std::thread::id) is incorrectly left-aligned

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112564

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Alfred Agrell from comment #0)
> but libstdc++ is left-aligning.

Yes, that's a bug.

> I am not sure how duration should be aligned by default but either libstdc++
> or libc++ are buggy here.

chrono::duration is not an arithmetic type, so I think it should default to
left-aligned.

[Bug libstdc++/112564] std::format(std::thread::id) is incorrectly left-aligned

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112564

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|13.3                        |14.0

[Bug libstdc++/112564] std::format(std::thread::id) is incorrectly left-aligned

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112564

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:23725aa53bd264941c4fb228227736be4da59761

commit r14-5536-g23725aa53bd264941c4fb228227736be4da59761
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu Nov 16 16:11:18 2023 +0000

    libstdc++: Fix aligned formatting of stacktrace_entry and thread::id
[PR112564]

    The formatter for std::thread::id should default to right-align, and the
    formatter for std::stacktrace_entry should not just ignore the
    fill-and-align and width from the format-spec!

    libstdc++-v3/ChangeLog:

            PR libstdc++/112564
            * include/std/stacktrace (formatter::format): Format according
            to format-spec.
            * include/std/thread (formatter::format): Use _Align_right as
            default.
            * testsuite/19_diagnostics/stacktrace/output.cc: Check
            fill-and-align handling. Change compile test to run.
            * testsuite/30_threads/thread/id/output.cc: Check fill-and-align
            handling.

[Bug libstdc++/112564] std::format(std::thread::id) is incorrectly left-aligned

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112564

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed, thanks for the report.