[Bug c++/112580] New: [14 Regression]: g++.dg/modules/xtreme-header-4_b.C et al; ICE tree check: expected class 'type', have 'declaration'

[Bug c++/112580] New: [14 Regression]: g++.dg/modules/xtreme-header-4_b.C et al; ICE tree check: expected class 'type', have 'declaration'

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112580

            Bug ID: 112580
           Summary: [14 Regression]:  g++.dg/modules/xtreme-header-4_b.C
                    et al; ICE tree check: expected class 'type', have
                    'declaration'
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: ice-checking
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hp at gcc dot gnu.org
                CC: redi at gcc dot gnu.org
  Target Milestone: ---

r14-5524-gc7f6537db94f7c exposed this test-suite regression for multiple
targets:

Running /x/gcc/gcc/testsuite/g++.dg/modules/modules.exp ...
[...]
FAIL: g++.dg/modules/xtreme-header-4_b.C -std=c++2b (internal compiler error:
tree check: expected class 'type', have 'declaration' (template_decl) in
get_originating_module_decl, at cp/module.cc:18649)
FAIL: g++.dg/modules/xtreme-header-4_b.C -std=c++2b (test for excess errors)
FAIL: g++.dg/modules/xtreme-header-5_b.C -std=c++2b (internal compiler error:
tree check: expected class 'type', have 'declaration' (template_decl) in
get_originating_module_decl, at cp/module.cc:18649)
FAIL: g++.dg/modules/xtreme-header-5_b.C -std=c++2b (test for excess errors)
FAIL: g++.dg/modules/xtreme-header_b.C -std=c++2b (internal compiler error:
tree check: expected class 'type', have 'declaration' (template_decl) in
get_originating_module_decl, at cp/module.cc:18649)
FAIL: g++.dg/modules/xtreme-header_b.C -std=c++2b (test for excess errors)

It happens for cris-elf, as well as other platforms:

powerpc64-unknown-linux-gnu
https://gcc.gnu.org/pipermail/gcc-testresults/2023-November/800960.html

i686-pc-linux-gnu
https://gcc.gnu.org/pipermail/gcc-testresults/2023-November/800997.html

"arm"
https://gcc.gnu.org/pipermail/gcc-regression/2023-November/078545.html
(where you have to click links to find out --target, though probably not
important)

Module tests may be nastier to reproduce than the usual ICE needing more than a
preprocessed .ii, but I believe one or more of the above targets should be
accessible.

[Bug c++/112580] [14 Regression]: g++.dg/modules/xtreme-header-4_b.C et al; ICE tree check: expected class 'type', have 'declaration'

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112580

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testsuite-fail
   Target Milestone|---                         |14.0

[Bug c++/112580] [14 Regression]: g++.dg/modules/xtreme-header-4_b.C et al; ICE tree check: expected class 'type', have 'declaration'

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112580

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |fxcoudert at gcc dot gnu.org
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-11-22

--- Comment #1 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Confirmed, and also seen on a non-linux target, x86_64-apple-darwin21:
https://gcc.gnu.org/pipermail/gcc-testresults/2023-November/801216.html

[Bug c++/112580] [14 Regression]: g++.dg/modules/xtreme-header-4_b.C et al; ICE tree check: expected class 'type', have 'declaration'

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112580

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Nathaniel Shead <nshead@gcc.gnu.org>:

https://gcc.gnu.org/g:ab3daffcbf35566d468c3028e48068a481048baf

commit r14-6394-gab3daffcbf35566d468c3028e48068a481048baf
Author: Nathaniel Shead <nathanieloshead@gmail.com>
Date:   Thu Nov 23 23:15:19 2023 +1100

    c++: Clear uninstantiated template friend when instantiating [PR104234]

    Otherwise attempting to get the originating module declaration ICEs
    because the DECL_CHAIN of an instantiated friend template is no longer
    its context.

            PR c++/104234
            PR c++/112580

    gcc/cp/ChangeLog:

            * pt.cc (tsubst_template_decl): Clear
            DECL_UNINSTANTIATED_TEMPLATE_FRIEND_P.

    gcc/testsuite/ChangeLog:

            * g++.dg/modules/pr104234.C: New test.

    Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>

[Bug c++/112580] [14 Regression]: g++.dg/modules/xtreme-header-4_b.C et al; ICE tree check: expected class 'type', have 'declaration'

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112580

--- Comment #3 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
All mentioned except g++.dg/modules/xtreme-header_b.C -std=c++2b (test for
excess errors) seem to be fixed.  Thanks!

[Bug c++/112580] [14 Regression]: g++.dg/modules/xtreme-header-4_b.C et al; ICE tree check: expected class 'type', have 'declaration'

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112580

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.

[Bug c++/112580] [14 Regression]: g++.dg/modules/xtreme-header-4_b.C et al; ICE tree check: expected class 'type', have 'declaration'

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112580

--- Comment #5 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Not entirely, xtreme-header_b.C is still failing, as indicated above. See
recently:
https://gcc.gnu.org/pipermail/gcc-testresults/2024-January/805380.html

FAIL: g++.dg/modules/xtreme-header-2_b.C -std=c++2b (test for excess errors)
FAIL: g++.dg/modules/xtreme-header_b.C -std=c++2b (test for excess errors)

Also, there are more failures with -m32 on the same x86_64-linux:

FAIL: g++.dg/modules/xtreme-header-2_b.C -std=c++2b (test for excess errors)
FAIL: g++.dg/modules/xtreme-header-2_c.C -std=c++2b (test for excess errors)
FAIL: g++.dg/modules/xtreme-header-4_c.C -std=c++2b (test for excess errors)
FAIL: g++.dg/modules/xtreme-header-5_c.C -std=c++2a (test for excess errors)
FAIL: g++.dg/modules/xtreme-header-5_c.C -std=c++2b (test for excess errors)
FAIL: g++.dg/modules/xtreme-header-6_c.C -std=c++2b (test for excess errors)
FAIL: g++.dg/modules/xtreme-header_b.C -std=c++2b (test for excess errors)

[Bug c++/112580] [14 Regression]: g++.dg/modules/xtreme-header-4_b.C et al; ICE tree check: expected class 'type', have 'declaration'

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112580

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #6 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
(In reply to Francois-Xavier Coudert from comment #5)
> Not entirely, xtreme-header_b.C is still failing, as indicated above. See
> recently:
> https://gcc.gnu.org/pipermail/gcc-testresults/2024-January/805380.html
> 
> FAIL: g++.dg/modules/xtreme-header-2_b.C -std=c++2b (test for excess errors)
> FAIL: g++.dg/modules/xtreme-header_b.C -std=c++2b (test for excess errors)

Confirmed for cris-elf @r14-7254-g4f141b051ef4, reopening.

[Bug c++/112580] [14 Regression]: g++.dg/modules/xtreme-header-4_b.C et al; ICE tree check: expected class 'type', have 'declaration'

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112580

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=112737
                 CC|                            |ppalka at gcc dot gnu.org

--- Comment #7 from Patrick Palka <ppalka at gcc dot gnu.org> ---
The xtreme-header-{4,5,6} fails need -mx32 (rather than -m32) on x86_64-linux. 
The error is:

.../x86_64-pc-linux-gnu/libstdc++-v3/include/format:3662:28: error: invalid use
of non-static data member
‘std::basic_format_args<std::basic_format_context<std::__format::_Sink_iter<wchar_t>,
wchar_t> >::__as_base ::<anonymous>’
 3662 |             __arg._M_val = _M_values[__i];
      |                            ^~~~~~~~~

The xtreme-header{,2} fails are also tracked by PR112737, and the error on
x86_64-linux is:

/src/gcc/testsuite/g++.dg/modules/xtreme-header-2_a.H: error: conflicting
global module declaration 'template<template<class ...> class _Cont, class _Rg,
class ... _Args> using std::ranges::__detail::_DeduceExpr1 = decltype
(_Cont<...auto...>(declval<_Rg>(), (declval<_Args>)()...))'
...

[Bug c++/112580] [14 Regression]: g++.dg/modules/xtreme-header-4_b.C et al; ICE tree check: expected class 'type', have 'declaration'

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112580

--- Comment #8 from Patrick Palka <ppalka at gcc dot gnu.org> ---
Reduced testcase for the xtreme-header-{4,5,6} error:

$ cat 112580_a.H
template <typename _Tp>
struct _Formatting_scanner {
  long long _M_unpacked_size;
  struct {
    int _M_values;
  };
  virtual int _M_format_arg() { return _M_values; }
};

_Formatting_scanner<int> s;

$ cat 112580_b.C
import "112580_a.H";

$ g++ -fmodules-ts 112580_a.H 112580_b.C
In module 112580_a.H, imported at 112580_b.C:1:
112580_a.H: In instantiation of ‘int _Formatting_scanner<_Tp>::_M_format_arg()
[with _Tp = int]’:
112580_a.H:7:15:   required from here
    7 |   virtual int _M_format_arg() { return _M_values; }
      |               ^~~~~~~~~~~~~
112580_a.H:7:40: error: invalid use of non-static data member
‘_Formatting_scanner<int>::__as_base ::<anonymous>’
    7 |   virtual int _M_format_arg() { return _M_values; }
      |                                        ^~~~~~~~~

[Bug c++/112580] [14 Regression]: g++.dg/modules/xtreme-header-4_b.C et al; ICE tree check: expected class 'type', have 'declaration'

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112580

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |ppalka at gcc dot gnu.org
             Status|REOPENED                    |ASSIGNED

[Bug c++/112580] [14 Regression]: g++.dg/modules/xtreme-header-4_b.C et al; ICE tree check: expected class 'type', have 'declaration'

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112580

--- Comment #9 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
(In reply to Hans-Peter Nilsson from comment #6)
> (In reply to Francois-Xavier Coudert from comment #5)
> > Not entirely, xtreme-header_b.C is still failing, as indicated above. See
> > recently:
> > https://gcc.gnu.org/pipermail/gcc-testresults/2024-January/805380.html
> > 
> > FAIL: g++.dg/modules/xtreme-header-2_b.C -std=c++2b (test for excess errors)
> > FAIL: g++.dg/modules/xtreme-header_b.C -std=c++2b (test for excess errors)
> 
> Confirmed for cris-elf @r14-7254-g4f141b051ef4, reopening.

But those two are gone.  While the "FAIL: g++.dg/modules/xtreme-header-2_b.C
-std=c++2b (test for excess errors)" was logged as PR112737, the "FAIL:
g++.dg/modules/xtreme-header_b.C -std=c++2b (test for excess errors)" was
covered in this ticket.  Both were fixed by r14-8705-g3ba5be16a2be (but which
tagged just PR112737).

[Bug c++/112580] [14 Regression]: g++.dg/modules/xtreme-header-4_b.C et al; ICE tree check: expected class 'type', have 'declaration'

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112580

--- Comment #10 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:f931bd7725f5cea948dd55ac370b5b9fd9a00198

commit r14-8900-gf931bd7725f5cea948dd55ac370b5b9fd9a00198
Author: Patrick Palka <ppalka@redhat.com>
Date:   Fri Feb 9 12:40:28 2024 -0500

    c++/modules: anon union member of as-base class [PR112580]

    Here when streaming in the fields of the as-base version of
    _Formatting_scanner<int> we end up overwriting ANON_AGGR_TYPE_FIELD
    of the anonymous union type, since it turns out this type is shared
    between the original FIELD_DECL and the as-base FIELD_DECL copy (copied
    during layout_class_type).  ANON_AGGR_TYPE_FIELD first gets properly set
    to the original FIELD_DECL when streaming in the canonical definition of
    _Formatting_scanner<int>, and then gets overwritten to the as-base
    FIELD_DECL when streaming in the the as-base definition.  This leads to
    lookup_anon_field later giving the wrong answer when resolving the
    _M_values use at instantiation time.

    This patch makes us avoid overwriting ANON_AGGR_TYPE_FIELD when streaming
    in an as-base class definition; it should already be properly set at that
    point.

            PR c++/112580

    gcc/cp/ChangeLog:

            * module.cc (trees_in::read_class_def): When streaming in
            an anonymous union field of an as-base class, don't overwrite
            ANON_AGGR_TYPE_FIELD.

    gcc/testsuite/ChangeLog:

            * g++.dg/modules/anon-3_a.H: New test.
            * g++.dg/modules/anon-3_b.C: New test.

    Reviewed-by: Jason Merrill <jason@redhat.com>

[Bug c++/112580] [14 Regression]: g++.dg/modules/xtreme-header-4_b.C et al; ICE tree check: expected class 'type', have 'declaration'

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112580

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Patrick Palka <ppalka at gcc dot gnu.org> ---
The "invalid use of non-static data member" errors when compiling the
xtreme-header tests should be fixed, which should be the last of the
xtreme-header 14 regressions.

[Bug c++/112580] [14 Regression]: g++.dg/modules/xtreme-header-4_b.C et al; ICE tree check: expected class 'type', have 'declaration'

[aoliva at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112580

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danglin at gcc dot gnu.org

--- Comment #12 from Alexandre Oliva <aoliva at gcc dot gnu.org> ---
*** Bug 108602 has been marked as a duplicate of this bug. ***