[Bug other/112684] New: ICE: in main, at toplev.cc:2327 with -ftarget-help -fdiagnostics-generate-patch

[Bug other/112684] New: ICE: in main, at toplev.cc:2327 with -ftarget-help -fdiagnostics-generate-patch

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112684

            Bug ID: 112684
           Summary: ICE: in main, at toplev.cc:2327 with -ftarget-help
                    -fdiagnostics-generate-patch
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu

Compiler output:
$ echo '' > testcase.c
$ x86_64-pc-linux-gnu-gcc -ftarget-help -fdiagnostics-generate-patch testcase.c
The following options are target specific:
...
cc1: internal compiler error: in main, at toplev.cc:2327
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r14-5791-20231123115417-g24592abd68e-checking-yes-rtl-df-extra-nobootstrap-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/14.0.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--disable-bootstrap --with-cloog --with-ppl --with-isl
--build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
--target=x86_64-pc-linux-gnu --with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r14-5791-20231123115417-g24592abd68e-checking-yes-rtl-df-extra-nobootstrap-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 14.0.0 20231123 (experimental) (GCC)

[Bug middle-end/112684] ICE: in main, at toplev.cc:2327 with -ftarget-help -fdiagnostics-generate-patch

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112684

--- Comment #1 from Zdenek Sojka <zsojka at seznam dot cz> ---
This happens also with --help=c:

$ x86_64-pc-linux-gnu-gcc --help=c -fdiagnostics-generate-patch testcase.c 
The following options are supported by the language C:
  --all-warnings              Same as -Wall.
...
  -undef                      Do not predefine system-specific and GCC-specific
macros.
  -v                          Enable verbose output.
  -w                          Suppress warnings.

cc1: internal compiler error: in main, at toplev.cc:2329
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug middle-end/112684] ICE: in main, at toplev.cc:2327 with -ftarget-help -fdiagnostics-generate-patch

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112684

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2024-01-16
           Assignee|unassigned at gcc dot gnu.org      |dmalcolm at gcc dot gnu.org

--- Comment #2 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Thanks for filing this bug.

Happens when
   if (!exit_after_options)
is skipped, since the edit_context is created in process_options.

Working on a fix.

[Bug middle-end/112684] ICE: in main, at toplev.cc:2327 with -ftarget-help -fdiagnostics-generate-patch

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112684

--- Comment #3 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Reproducers for trunk and supported releases:
  Trunk:    https://godbolt.org/z/fz8o3c7h6
  GCC 13.2: https://godbolt.org/z/bnd55zn7K
  GCC 12.3: https://godbolt.org/z/qdf54h6nf
  GCC 11.4: https://godbolt.org/z/fv8a4rvKs

[Bug middle-end/112684] ICE: in main, at toplev.cc:2327 with -ftarget-help -fdiagnostics-generate-patch

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112684

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:e254d1224df306a07f3b0b572af2582f509b7d67

commit r14-8255-ge254d1224df306a07f3b0b572af2582f509b7d67
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Thu Jan 18 12:11:57 2024 -0500

    Fix ICE in -fdiagnostics-generate-patch [PR112684]

    gcc/ChangeLog:
            PR middle-end/112684
            * toplev.cc (toplev::main): Don't ICE in
            -fdiagnostics-generate-patch when exiting after options,
            since no edit context will have been created.

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>

[Bug middle-end/112684] ICE: in main, at toplev.cc:2327 with -ftarget-help -fdiagnostics-generate-patch

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112684

--- Comment #5 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by David Malcolm
<dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:2a6f99aef7c8522471967b171180d9ba4136da90

commit r13-8760-g2a6f99aef7c8522471967b171180d9ba4136da90
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Thu May 9 13:09:32 2024 -0400

    Fix ICE in -fdiagnostics-generate-patch [PR112684]

    Backported from r14-8255-ge254d1224df306.

    gcc/ChangeLog:
            PR middle-end/112684
            * toplev.cc (toplev::main): Don't ICE in
            -fdiagnostics-generate-patch when exiting after options,
            since no edit context will have been created.

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>