[Bug testsuite/112728] New: gcc.dg/scantest-lto.c FAILs

[Bug testsuite/112728] New: gcc.dg/scantest-lto.c FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112728

            Bug ID: 112728
           Summary: gcc.dg/scantest-lto.c FAILs
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
                CC: amylaar at gcc dot gnu.org
  Target Milestone: ---
            Target: sparc-sun-solaris2.11, powerpc-ibm-aix7.2.5.0,
                    x86_64-apple-darwin, hppa64-hp-hpux11.11

The gcc.dg/scantest-lto.c FAILs on quite a number of targets:

* On Solaris/SPARC with the native as, it's because section names are double-
  quoted, which isn't yet handled by the scanasm.exp LTO detection.  I do have
  a patch for that.

However, there are several more on gcc-testresults:

* On Darwin, the __TEXT,__eh_frame contains .ascii because the assembler
  lacks support for cfi directives.

* There are also reports on AIX 7.2.5.0 and HP/UX 11.11.  In both cases, one
  sees

FAIL: gcc.dg/scantest-lto.c (test for excess errors)
UNRESOLVED: gcc.dg/scantest-lto.c scan-assembler-not ascii
UNRESOLVED: gcc.dg/scantest-lto.c scan-assembler-times ascii 0

It seems there's more than one thing wrong with the test.

[Bug testsuite/112728] gcc.dg/scantest-lto.c FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112728

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0

[Bug testsuite/112728] gcc.dg/scantest-lto.c FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112728

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2023-Novembe
                   |                            |r/638465.html

--- Comment #1 from Rainer Orth <ro at gcc dot gnu.org> ---
Patch for Solaris/SPARC as issue posted.

[Bug testsuite/112728] gcc.dg/scantest-lto.c FAILs

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112728

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Rainer Orth <ro@gcc.gnu.org>:

https://gcc.gnu.org/g:77f713a64aead2bcc68567de8431bdb67cb6b196

commit r14-5959-g77f713a64aead2bcc68567de8431bdb67cb6b196
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date:   Wed Nov 29 10:29:50 2023 +0100

    testsuite: Handle double-quoted LTO section names [PR112728]

    The gcc.dg/scantest-lto.c test FAILs on Solaris/SPARC with the native as:

    FAIL: gcc.dg/scantest-lto.c scan-assembler-not ascii
    FAIL: gcc.dg/scantest-lto.c scan-assembler-times ascii 0

    It requires double-quoting the section name which scanasm.exp doesn't
    allow for.

    This patch fixes that.

    Tested on sparc-sun-solaris2.11 (as and gas) and i386-pc-solaris2.11 (as
    and gas).

    2023-11-23  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

            gcc/testsuite:
            PR testsuite/112728
            * lib/scanasm.exp (dg-scan): Allow for double-quoted LTO section
names.
            (scan-assembler-times): Likewise.
            (scan-assembler-dem-not): Likewise.

[Bug testsuite/112728] gcc.dg/scantest-lto.c FAILs

[amylaar at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112728

--- Comment #3 from Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> ---
(In reply to Rainer Orth from comment #0)
> The gcc.dg/scantest-lto.c FAILs on quite a number of targets:
... 
> * On Darwin, the __TEXT,__eh_frame contains .ascii because the assembler
>   lacks support for cfi directives.

I suppose we could handle the darwin case by:

- Not doing the common scan-assembler* tests for darwin
- doing a scan-assembler-times test that expects exactly how many .ascii are
emitted for cfi.

[Bug testsuite/112728] gcc.dg/scantest-lto.c FAILs

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112728

--- Comment #4 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #3 from Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> ---
> (In reply to Rainer Orth from comment #0)
>> The gcc.dg/scantest-lto.c FAILs on quite a number of targets:
> ... 
>> * On Darwin, the __TEXT,__eh_frame contains .ascii because the assembler
>>   lacks support for cfi directives.
>
> I suppose we could handle the darwin case by:
>
> - Not doing the common scan-assembler* tests for darwin

I guess it would be better to use the recently introduce cfi
effective-target keyword to catch targets that would show ascii in
there.

> - doing a scan-assembler-times test that expects exactly how many .ascii are
> emitted for cfi.

While that's an option, I suspect that's going too far actually.

[Bug testsuite/112728] gcc.dg/scantest-lto.c FAILs

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112728

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|14.0                        |14.2

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 14.1 is being released, retargeting bugs to GCC 14.2.

[Bug testsuite/112728] gcc.dg/scantest-lto.c FAILs

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112728

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2024-05-11
                 CC|                            |iains at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW

--- Comment #6 from Iain Sandoe <iains at gcc dot gnu.org> ---
it also fails on Darwin because the LTO section names are different (and
therefore are not being excluded)

 -- I have patches to fix the two issues mentioned for Darwin, 

For the EH case, we can imply omit the EH frames from the test.

For the other case, I'll fix up the scanasm code to allow the correct LTO
section name introducer on Darwin - that seems a better solution than doing a
dance with counting the number of .ascii every time.

No idea if either of those issues is relevant to the remaining affected
platforms.

[Bug testsuite/112728] gcc.dg/scantest-lto.c FAILs

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112728

--- Comment #7 from Iain Sandoe <iains at gcc dot gnu.org> ---
I happened to do an AIX build on cfarm119 - and looking at this, not sure why
AIX is failing; although the LTO is handled in a different way in AIX, there
are actually no instances of "ascii" in the assembler output - so I'd have
expected it to pass "by accident".

[Bug testsuite/112728] gcc.dg/scantest-lto.c FAILs

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112728

--- Comment #8 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Iain Sandoe from comment #7)
> I happened to do an AIX build on cfarm119 - and looking at this, not sure
> why AIX is failing; although the LTO is handled in a different way in AIX,
> there are actually no instances of "ascii" in the assembler output - so I'd
> have expected it to pass "by accident".

and, indeed, testing on r15-384 on powerpc-ibm-aix7.3.1.0 the test passes.